Browse Source

Improvement TelemetryController, change TsData value to Object

pull/2450/head
YevhenBondarenko 7 years ago
committed by Andrew Shvayka
parent
commit
e207545ce0
  1. 23
      application/src/main/java/org/thingsboard/server/controller/TelemetryController.java
  2. 6
      application/src/main/java/org/thingsboard/server/service/telemetry/TsData.java

23
application/src/main/java/org/thingsboard/server/controller/TelemetryController.java

@ -182,11 +182,12 @@ public class TelemetryController extends BaseController {
@ResponseBody @ResponseBody
public DeferredResult<ResponseEntity> getLatestTimeseries( public DeferredResult<ResponseEntity> getLatestTimeseries(
@PathVariable("entityType") String entityType, @PathVariable("entityId") String entityIdStr, @PathVariable("entityType") String entityType, @PathVariable("entityId") String entityIdStr,
@RequestParam(name = "keys", required = false) String keysStr) throws ThingsboardException { @RequestParam(name = "keys", required = false) String keysStr,
@RequestParam(name = "useStrictType", required = false, defaultValue = "false") Boolean useStrictType) throws ThingsboardException {
SecurityUser user = getCurrentUser(); SecurityUser user = getCurrentUser();
return accessValidator.validateEntityAndCallback(getCurrentUser(), Operation.READ_TELEMETRY, entityType, entityIdStr, return accessValidator.validateEntityAndCallback(getCurrentUser(), Operation.READ_TELEMETRY, entityType, entityIdStr,
(result, tenantId, entityId) -> getLatestTimeseriesValuesCallback(result, user, entityId, keysStr)); (result, tenantId, entityId) -> getLatestTimeseriesValuesCallback(result, user, entityId, keysStr, useStrictType));
} }
@ -200,8 +201,8 @@ public class TelemetryController extends BaseController {
@RequestParam(name = "endTs") Long endTs, @RequestParam(name = "endTs") Long endTs,
@RequestParam(name = "interval", defaultValue = "0") Long interval, @RequestParam(name = "interval", defaultValue = "0") Long interval,
@RequestParam(name = "limit", defaultValue = "100") Integer limit, @RequestParam(name = "limit", defaultValue = "100") Integer limit,
@RequestParam(name = "agg", defaultValue = "NONE") String aggStr @RequestParam(name = "agg", defaultValue = "NONE") String aggStr,
) throws ThingsboardException { @RequestParam(name = "useStrictType", required = false, defaultValue = "false") Boolean useStrictType) throws ThingsboardException {
return accessValidator.validateEntityAndCallback(getCurrentUser(), Operation.READ_TELEMETRY, entityType, entityIdStr, return accessValidator.validateEntityAndCallback(getCurrentUser(), Operation.READ_TELEMETRY, entityType, entityIdStr,
(result, tenantId, entityId) -> { (result, tenantId, entityId) -> {
// If interval is 0, convert this to a NONE aggregation, which is probably what the user really wanted // If interval is 0, convert this to a NONE aggregation, which is probably what the user really wanted
@ -209,7 +210,7 @@ public class TelemetryController extends BaseController {
List<ReadTsKvQuery> queries = toKeysList(keys).stream().map(key -> new BaseReadTsKvQuery(key, startTs, endTs, interval, limit, agg)) List<ReadTsKvQuery> queries = toKeysList(keys).stream().map(key -> new BaseReadTsKvQuery(key, startTs, endTs, interval, limit, agg))
.collect(Collectors.toList()); .collect(Collectors.toList());
Futures.addCallback(tsService.findAll(tenantId, entityId, queries), getTsKvListCallback(result)); Futures.addCallback(tsService.findAll(tenantId, entityId, queries), getTsKvListCallback(result, useStrictType));
}); });
} }
@ -454,14 +455,14 @@ public class TelemetryController extends BaseController {
}); });
} }
private void getLatestTimeseriesValuesCallback(@Nullable DeferredResult<ResponseEntity> result, SecurityUser user, EntityId entityId, String keys) { private void getLatestTimeseriesValuesCallback(@Nullable DeferredResult<ResponseEntity> result, SecurityUser user, EntityId entityId, String keys, Boolean useStrictType) {
ListenableFuture<List<TsKvEntry>> future; ListenableFuture<List<TsKvEntry>> future;
if (StringUtils.isEmpty(keys)) { if (StringUtils.isEmpty(keys)) {
future = tsService.findAllLatest(user.getTenantId(), entityId); future = tsService.findAllLatest(user.getTenantId(), entityId);
} else { } else {
future = tsService.findLatest(user.getTenantId(), entityId, toKeysList(keys)); future = tsService.findLatest(user.getTenantId(), entityId, toKeysList(keys));
} }
Futures.addCallback(future, getTsKvListCallback(result)); Futures.addCallback(future, getTsKvListCallback(result, useStrictType));
} }
private void getAttributeValuesCallback(@Nullable DeferredResult<ResponseEntity> result, SecurityUser user, EntityId entityId, String scope, String keys) { private void getAttributeValuesCallback(@Nullable DeferredResult<ResponseEntity> result, SecurityUser user, EntityId entityId, String scope, String keys) {
@ -544,7 +545,7 @@ public class TelemetryController extends BaseController {
@Override @Override
public void onSuccess(List<AttributeKvEntry> attributes) { public void onSuccess(List<AttributeKvEntry> attributes) {
List<AttributeData> values = attributes.stream().map(attribute -> List<AttributeData> values = attributes.stream().map(attribute ->
new AttributeData(attribute.getLastUpdateTs(), attribute.getKey(), getKvValue(attribute)) new AttributeData(attribute.getLastUpdateTs(), attribute.getKey(), getKvValue(attribute))
).collect(Collectors.toList()); ).collect(Collectors.toList());
logAttributesRead(user, entityId, scope, keyList, null); logAttributesRead(user, entityId, scope, keyList, null);
response.setResult(new ResponseEntity<>(values, HttpStatus.OK)); response.setResult(new ResponseEntity<>(values, HttpStatus.OK));
@ -559,14 +560,14 @@ public class TelemetryController extends BaseController {
}; };
} }
private FutureCallback<List<TsKvEntry>> getTsKvListCallback(final DeferredResult<ResponseEntity> response) { private FutureCallback<List<TsKvEntry>> getTsKvListCallback(final DeferredResult<ResponseEntity> response, Boolean useStrictType) {
return new FutureCallback<List<TsKvEntry>>() { return new FutureCallback<List<TsKvEntry>>() {
@Override @Override
public void onSuccess(List<TsKvEntry> data) { public void onSuccess(List<TsKvEntry> data) {
Map<String, List<TsData>> result = new LinkedHashMap<>(); Map<String, List<TsData>> result = new LinkedHashMap<>();
for (TsKvEntry entry : data) { for (TsKvEntry entry : data) {
result.computeIfAbsent(entry.getKey(), k -> new ArrayList<>()) Object value = useStrictType ? getKvValue(entry) : entry.getValueAsString();
.add(new TsData(entry.getTs(), entry.getValueAsString())); result.computeIfAbsent(entry.getKey(), k -> new ArrayList<>()).add(new TsData(entry.getTs(), value));
} }
response.setResult(new ResponseEntity<>(result, HttpStatus.OK)); response.setResult(new ResponseEntity<>(result, HttpStatus.OK));
} }

6
application/src/main/java/org/thingsboard/server/service/telemetry/TsData.java

@ -18,9 +18,9 @@ package org.thingsboard.server.service.telemetry;
public class TsData implements Comparable<TsData>{ public class TsData implements Comparable<TsData>{
private final long ts; private final long ts;
private final String value; private final Object value;
public TsData(long ts, String value) { public TsData(long ts, Object value) {
super(); super();
this.ts = ts; this.ts = ts;
this.value = value; this.value = value;
@ -30,7 +30,7 @@ public class TsData implements Comparable<TsData>{
return ts; return ts;
} }
public String getValue() { public Object getValue() {
return value; return value;
} }

Loading…
Cancel
Save