Browse Source

Fix version comparison in EdgeVersionUtils

pull/14952/head
Nikita Mazurenko 8 months ago
parent
commit
f82f4017fd
  1. 3
      application/src/main/java/org/thingsboard/server/service/edge/rpc/utils/EdgeVersionUtils.java
  2. 10
      application/src/test/java/org/thingsboard/server/edge/EdgeLatestVersionTest.java

3
application/src/main/java/org/thingsboard/server/service/edge/rpc/utils/EdgeVersionUtils.java

@ -16,13 +16,14 @@
package org.thingsboard.server.service.edge.rpc.utils;
import lombok.extern.slf4j.Slf4j;
import org.thingsboard.edge.rpc.EdgeVersionComparator;
import org.thingsboard.server.gen.edge.v1.EdgeVersion;
@Slf4j
public final class EdgeVersionUtils {
public static boolean isEdgeVersionOlderThan(EdgeVersion currentVersion, EdgeVersion requiredVersion) {
return currentVersion.ordinal() < requiredVersion.ordinal();
return EdgeVersionComparator.INSTANCE.compare(currentVersion, requiredVersion) < 0;
}
}

10
application/src/test/java/org/thingsboard/server/edge/EdgeLatestVersionTest.java

@ -17,20 +17,14 @@ package org.thingsboard.server.edge;
import org.junit.Assert;
import org.junit.Test;
import org.thingsboard.edge.rpc.EdgeVersionComparator;
import org.thingsboard.server.gen.edge.v1.EdgeVersion;
import java.util.Arrays;
import java.util.Comparator;
public class EdgeLatestVersionTest {
@Test
public void edgeLatestVersionIsSynchronizedTest() {
EdgeVersion currentHighestEdgeVersion = Arrays.stream(EdgeVersion.values())
.filter(v -> v != EdgeVersion.UNRECOGNIZED)
.filter(v -> v != EdgeVersion.V_LATEST)
.max(Comparator.comparingInt(EdgeVersion::getNumber))
.orElseThrow();
EdgeVersion currentHighestEdgeVersion = EdgeVersionComparator.getNewestEdgeVersion();
String projectVersion = EdgeLatestVersionTest.class.getPackage().getImplementationVersion();
if (projectVersion == null || projectVersion.isBlank()) {

Loading…
Cancel
Save