tsai
/
thingsboard
mirror of https://github.com/thingsboard/thingsboard.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Extract PAGE_SIZE constant in AuditLogControllerTest 

Replace magic number 5 with a named constant that explains intent:
small enough to force multiple pages and verify pagination loop correctness.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pull/15200/head
Sergey Matvienko 7 months ago
parent
da12ee6dc0
commit
feae24fac8
1 changed files with 8 additions and 5 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 13
      application/src/test/java/org/thingsboard/server/controller/AuditLogControllerTest.java

13
application/src/test/java/org/thingsboard/server/controller/AuditLogControllerTest.java
View File

@ -62,6 +62,9 @@ import static org.mockito.Mockito.verify;
@DaoSqlTest @DaoSqlTest
public class AuditLogControllerTest extends AbstractControllerTest { public class AuditLogControllerTest extends AbstractControllerTest {
// Small enough to force multiple pages, verifying pagination loop correctness
private static final int PAGE_SIZE = 5;
private Tenant savedTenant; private Tenant savedTenant;
private User tenantAdmin; private User tenantAdmin;
@ -114,13 +117,13 @@ public class AuditLogControllerTest extends AbstractControllerTest {
} }
Awaitility.await().atMost(TIMEOUT, TimeUnit.SECONDS).untilAsserted(() -> Awaitility.await().atMost(TIMEOUT, TimeUnit.SECONDS).untilAsserted(() ->
assertThat(getAuditLogs(5, "/api/audit/logs?")).hasSize(11 + 1)); assertThat(getAuditLogs(PAGE_SIZE, "/api/audit/logs?")).hasSize(11 + 1));
Awaitility.await().atMost(TIMEOUT, TimeUnit.SECONDS).untilAsserted(() -> Awaitility.await().atMost(TIMEOUT, TimeUnit.SECONDS).untilAsserted(() ->
assertThat(getAuditLogs(5, "/api/audit/logs/customer/" + ModelConstants.NULL_UUID + "?")).hasSize(11 + 1)); assertThat(getAuditLogs(PAGE_SIZE, "/api/audit/logs/customer/" + ModelConstants.NULL_UUID + "?")).hasSize(11 + 1));
Awaitility.await().atMost(TIMEOUT, TimeUnit.SECONDS).untilAsserted(() -> Awaitility.await().atMost(TIMEOUT, TimeUnit.SECONDS).untilAsserted(() ->
assertThat(getAuditLogs(5, "/api/audit/logs/user/" + tenantAdmin.getId().getId().toString() + "?")).hasSize(11 + 1)); assertThat(getAuditLogs(PAGE_SIZE, "/api/audit/logs/user/" + tenantAdmin.getId().getId().toString() + "?")).hasSize(11 + 1));
} }
@Test @Test
@ -168,7 +171,7 @@ public class AuditLogControllerTest extends AbstractControllerTest {
} }
Awaitility.await().atMost(TIMEOUT, TimeUnit.SECONDS).untilAsserted(() -> Awaitility.await().atMost(TIMEOUT, TimeUnit.SECONDS).untilAsserted(() ->
assertThat(getAuditLogs(5, "/api/audit/logs/entity/DEVICE/" + savedDevice.getId().getId() + "?")).hasSize(11 + 1)); assertThat(getAuditLogs(PAGE_SIZE, "/api/audit/logs/entity/DEVICE/" + savedDevice.getId().getId() + "?")).hasSize(11 + 1));
} }
@Test @Test
@ -185,7 +188,7 @@ public class AuditLogControllerTest extends AbstractControllerTest {
tenantProfile = doPost("/api/tenantProfile", tenantProfile, TenantProfile.class); tenantProfile = doPost("/api/tenantProfile", tenantProfile, TenantProfile.class);
Awaitility.await().atMost(TIMEOUT, TimeUnit.SECONDS).untilAsserted(() -> Awaitility.await().atMost(TIMEOUT, TimeUnit.SECONDS).untilAsserted(() ->
assertThat(getAuditLogs(5, "/api/audit/logs/entity/" + tenantProfile.getId().getEntityType() + "/" + tenantProfile.getId().getId() + "?")) assertThat(getAuditLogs(PAGE_SIZE, "/api/audit/logs/entity/" + tenantProfile.getId().getEntityType() + "/" + tenantProfile.getId().getId() + "?"))
.as("Audit logs count by Tenant Profile entity").hasSize(2)); .as("Audit logs count by Tenant Profile entity").hasSize(2));
//cleanup //cleanup

Write Preview
Loading…
Cancel
Save