thingsboard

Open-source IoT Platform - Device management, data collection, processing and visualization.

dashboard java cloud coap iot iot-analytics iot-platform iot-solutions kafka lwm2m microservices middleware mqtt netty platform snmp thingsboard visualization websockets widgets

History

pon0marev 14cb5103a1 fix(monitoring): address CoAPS PR review feedback Moves the DTLS/wildcard-verification code out of common/util into monitoring (the only consumer), so the shared module doesn't pull in Californium and httpclient5. CoAP secure-vs-plain detection now goes through CoAP.isSecureScheme(CoAP.getSchemeFromUri(...)) instead of a raw startsWith("coaps") check, and the CoAP/MQTT transport health checkers now share a single reconnect-choreography helper instead of duplicating it. Also, per review: - guards WildcardAwareCertificateVerifier against an empty CertPath (delegate skipped validation entirely) instead of NPE-ing on it - switches session-expiry tracking to System.nanoTime() so NTP/clock adjustments can't shorten or extend a session - preserves exception stack traces in client-teardown warning logs instead of logging only getMessage() - removes a dead, exception-throwing block in Lwm2mClient that computed an unused Configuration and crashed on port-less target URLs - corrects the LwM2M yml docs: the port is not auto-defaulted like the other transports, and DTLS isn't supported since the client always registers with noSec regardless of scheme - fixes "Connecting" being logged after the client had already connected - adds test coverage for the verifyCertificate() override (including the CertificateParsingException fail-closed path) and for session expiry Verified with a live deployment against a real wildcard-cert CoAPS server, exercising all four transports end to end including session-expiry reconnects.	2 weeks ago
..
src	fix(monitoring): address CoAPS PR review feedback	2 weeks ago
pom.xml	fix(monitoring): address CoAPS PR review feedback	2 weeks ago

pon0marev 14cb5103a1 fix(monitoring): address CoAPS PR review feedback

Moves the DTLS/wildcard-verification code out of common/util into monitoring
(the only consumer), so the shared module doesn't pull in Californium and
httpclient5. CoAP secure-vs-plain detection now goes through
CoAP.isSecureScheme(CoAP.getSchemeFromUri(...)) instead of a raw
startsWith("coaps") check, and the CoAP/MQTT transport health checkers now
share a single reconnect-choreography helper instead of duplicating it.

Also, per review:
- guards WildcardAwareCertificateVerifier against an empty CertPath (delegate
  skipped validation entirely) instead of NPE-ing on it
- switches session-expiry tracking to System.nanoTime() so NTP/clock
  adjustments can't shorten or extend a session
- preserves exception stack traces in client-teardown warning logs instead of
  logging only getMessage()
- removes a dead, exception-throwing block in Lwm2mClient that computed an
  unused Configuration and crashed on port-less target URLs
- corrects the LwM2M yml docs: the port is not auto-defaulted like the other
  transports, and DTLS isn't supported since the client always registers
  with noSec regardless of scheme
- fixes "Connecting" being logged after the client had already connected
- adds test coverage for the verifyCertificate() override (including the
  CertificateParsingException fail-closed path) and for session expiry

Verified with a live deployment against a real wildcard-cert CoAPS server,
exercising all four transports end to end including session-expiry reconnects.

2 weeks ago

src

fix(monitoring): address CoAPS PR review feedback

2 weeks ago

pom.xml

fix(monitoring): address CoAPS PR review feedback

2 weeks ago