Browse Source

Address some policheck-ness

- Skip scanning test logs (common source of issues)
  These can have generated names that contain violations

- Address a policheck violation in our code
pull/79/head
Ryan Nowak 6 years ago
parent
commit
508de1f071
  1. 3
      azure-pipelines.yml
  2. 3
      eng/PoliCheckExclusions.xml
  3. 2
      src/Tye.Hosting/DockerRunner.cs

3
azure-pipelines.yml

@ -182,4 +182,5 @@ stages:
-TsaIterationPath $(_TsaIterationPath)
-TsaRepositoryName "Tye"
-TsaCodebaseName "Tye"
-TsaPublish $True'
-TsaPublish $True
-PoliCheckAdditionalRunConfigParams @("UserExclusionPath < $(Build.SourcesDirectory)/eng/PoliCheckExclusions.xml")'

3
eng/PoliCheckExclusions.xml

@ -0,0 +1,3 @@
<PoliCheckExclusions>
<Exclusion Type="FolderPathFull">LINUX_TEST_RESULTS|MACOS_TEST_RESULTS|WINDOWS_TEST_RESULTS|LINUX_TEST_LOGS|MACOS_TEST_LOGS|WINDOWS_TEST_LOGS</Exclusion>
</PoliCheckExclusions>

2
src/Tye.Hosting/DockerRunner.cs

@ -162,7 +162,7 @@ namespace Tye.Hosting
_logger.LogInformation("docker logs collection for {ContainerName} complete with exit code {ExitCode}", replica, result.ExitCode);
// Docker has a tendency to hang so we're going to timeout this shutdown process
// Docker has a tendency to get stuck so we're going to timeout this shutdown process
var timeoutCts = new CancellationTokenSource(TimeSpan.FromSeconds(5));
_logger.LogInformation("Stopping container {ContainerName} with ID {ContainerId}", replica, shortContainerId);

Loading…
Cancel
Save