Browse Source

remove some redundant params

pull/229/head
SimonCropp 7 years ago
committed by Ryan Nowak
parent
commit
bc10694e18
  1. 4
      src/Microsoft.Tye.Hosting.Diagnostics/DiagnosticsCollector.cs
  2. 4
      src/tye/Program.DeployCommand.cs

4
src/Microsoft.Tye.Hosting.Diagnostics/DiagnosticsCollector.cs

@ -124,7 +124,7 @@ namespace Microsoft.Tye.Hosting.Diagnostics
// Create the logger factory for this replica // Create the logger factory for this replica
using var loggerFactory = LoggerFactory.Create(builder => ConfigureLogging(serviceName, replicaName, builder)); using var loggerFactory = LoggerFactory.Create(builder => ConfigureLogging(serviceName, replicaName, builder));
var processor = new SimpleSpanProcessor(CreateSpanExporter(serviceName, replicaName)); var processor = new SimpleSpanProcessor(CreateSpanExporter(serviceName));
var providers = new List<EventPipeProvider>() var providers = new List<EventPipeProvider>()
{ {
@ -778,7 +778,7 @@ namespace Microsoft.Tye.Hosting.Diagnostics
} }
private SpanExporter CreateSpanExporter(string serviceName, string replicaName) private SpanExporter CreateSpanExporter(string serviceName)
{ {
if (string.Equals(_options.DistributedTraceProvider.Key, "zipkin", StringComparison.OrdinalIgnoreCase) && if (string.Equals(_options.DistributedTraceProvider.Key, "zipkin", StringComparison.OrdinalIgnoreCase) &&
!string.IsNullOrEmpty(_options.DistributedTraceProvider.Value)) !string.IsNullOrEmpty(_options.DistributedTraceProvider.Value))

4
src/tye/Program.DeployCommand.cs

@ -83,10 +83,10 @@ namespace Microsoft.Tye
await executor.ExecuteAsync(service); await executor.ExecuteAsync(service);
} }
await DeployApplicationManifestAsync(output, application, application.Source.Directory.Name, environment); await DeployApplicationManifestAsync(output, application, application.Source.Directory.Name);
} }
private static async Task DeployApplicationManifestAsync(OutputContext output, ApplicationBuilder application, string applicationName, string environment) private static async Task DeployApplicationManifestAsync(OutputContext output, ApplicationBuilder application, string applicationName)
{ {
using var step = output.BeginStep("Deploying Application Manifests..."); using var step = output.BeginStep("Deploying Application Manifests...");

Loading…
Cancel
Save