From cb0a3d5c2bf35e26ab999fa2b155431db2bc9b1f Mon Sep 17 00:00:00 2001 From: Ryan Nowak Date: Sun, 1 Mar 2020 22:16:28 -0800 Subject: [PATCH] Use imagePullPolicy: Always This isn't optimal, but right now it's easy to get into problems using tye because we don't generate manifests with digests. As an example, if you don't have any versioning in your project, right now we will *just* tag everything with 1.0.0. This can lead to pods getting deployed with stale images, even though you pushed! A better solution is for us to use digests instead of tags. --- src/opulence/dotnet-opulence/KubernetesManifestGenerator.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/opulence/dotnet-opulence/KubernetesManifestGenerator.cs b/src/opulence/dotnet-opulence/KubernetesManifestGenerator.cs index 803652a6..c9328c23 100644 --- a/src/opulence/dotnet-opulence/KubernetesManifestGenerator.cs +++ b/src/opulence/dotnet-opulence/KubernetesManifestGenerator.cs @@ -132,6 +132,7 @@ namespace Opulence containers.Add(container); container.Add("name", service.Service.Name); // NOTE: to really support multiple images we'd need to generate unique names. container.Add("image", $"{image.ImageName}:{image.ImageTag}"); + container.Add("imagePullPolicy", "Always"); // helps avoid problems with development + weak versioning if (service.Service.Environment.Count > 0 ||