From f9903e237cb53dce26f1f129f409db142cfb5a3f Mon Sep 17 00:00:00 2001 From: Tim Potze Date: Fri, 1 Oct 2021 22:52:51 +0200 Subject: [PATCH] Only add ports with http and https protocol to ASPNETCORE_URLS (#1153) --- src/Microsoft.Tye.Hosting/DockerRunner.cs | 3 ++- src/Microsoft.Tye.Hosting/ProcessRunner.cs | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Microsoft.Tye.Hosting/DockerRunner.cs b/src/Microsoft.Tye.Hosting/DockerRunner.cs index d9fa2ed1..f0d27ab2 100644 --- a/src/Microsoft.Tye.Hosting/DockerRunner.cs +++ b/src/Microsoft.Tye.Hosting/DockerRunner.cs @@ -242,7 +242,8 @@ namespace Microsoft.Tye.Hosting if (docker.IsAspNet) { // 2. Configure ASP.NET Core to bind to those same ports - environment["ASPNETCORE_URLS"] = string.Join(";", ports.Select(p => $"{p.Protocol ?? "http"}://*:{p.ContainerPort ?? p.Port}")); + var urlPorts = ports.Where(p => p.Protocol == null || p.Protocol == "http" || p.Protocol == "https"); + environment["ASPNETCORE_URLS"] = string.Join(";", urlPorts.Select(p => $"{p.Protocol ?? "http"}://*:{p.ContainerPort ?? p.Port}")); // Set the HTTPS port for the redirect middleware foreach (var p in ports) diff --git a/src/Microsoft.Tye.Hosting/ProcessRunner.cs b/src/Microsoft.Tye.Hosting/ProcessRunner.cs index 57920dad..9dca622c 100644 --- a/src/Microsoft.Tye.Hosting/ProcessRunner.cs +++ b/src/Microsoft.Tye.Hosting/ProcessRunner.cs @@ -220,7 +220,8 @@ namespace Microsoft.Tye.Hosting // These are the ports that the application should use for binding // 1. Configure ASP.NET Core to bind to those same ports - environment["ASPNETCORE_URLS"] = string.Join(";", ports.Select(p => $"{p.Protocol ?? "http"}://{application.ContainerEngine.AspNetUrlsHost}:{p.Port}")); + var urlPorts = ports.Where(p => p.Protocol == null || p.Protocol == "http" || p.Protocol == "https"); + environment["ASPNETCORE_URLS"] = string.Join(";", urlPorts.Select(p => $"{p.Protocol ?? "http"}://{application.ContainerEngine.AspNetUrlsHost}:{p.Port}")); // Set the HTTPS port for the redirect middleware foreach (var p in ports)