fix(@vben/request): preserve response metadata on errors (#8377)

* fix(request): preserve response metadata on errors

* style(request): order interceptor test imports

.changeset/gentle-requests-return.md

@@ -0,0 +1,5 @@
+---
+'@vben/request': patch
+---
+
+fix: preserve response metadata when requests fail

packages/effects/request/src/request-client/request-client.test.ts

@@ -2,6 +2,10 @@ import axios from 'axios';
 import MockAdapter from 'axios-mock-adapter';
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
 
+import {
+  defaultResponseInterceptor,
+  errorMessageResponseInterceptor,
+} from './preset-interceptors';
 import { RequestClient } from './request-client';
 
 describe('requestClient', () => {
@@ -64,6 +68,38 @@ describe('requestClient', () => {
     });
   });
 
+  it('should preserve response metadata when an interceptor rejects', async () => {
+    requestClient.addResponseInterceptor(
+      defaultResponseInterceptor({
+        codeField: 'code',
+        dataField: 'data',
+        successCode: 0,
+      }),
+    );
+    requestClient.addResponseInterceptor(errorMessageResponseInterceptor());
+    mock.onGet('/test/interceptor-error').reply(200, {
+      code: 1001,
+      data: null,
+      message: 'request failed',
+    });
+
+    await expect(
+      requestClient.get('/test/interceptor-error', {
+        responseReturn: 'data',
+      }),
+    ).rejects.toMatchObject({
+      response: {
+        data: {
+          code: 1001,
+          data: null,
+          message: 'request failed',
+        },
+        status: 200,
+      },
+      status: 200,
+    });
+  });
+
   it('should successfully upload a file', async () => {
     const fileData = new Blob(['file contents'], { type: 'text/plain' });
 

packages/effects/request/src/request-client/request-client.ts

@@ -146,18 +146,14 @@ class RequestClient {
     url: string,
     config: RequestClientConfig,
   ): Promise<T> {
-    try {
-      const response: AxiosResponse<T> = await this.instance({
-        url,
-        ...config,
-        ...(config.paramsSerializer
-          ? { paramsSerializer: getParamsSerializer(config.paramsSerializer) }
-          : {}),
-      });
-      return response as T;
-    } catch (error: any) {
-      throw error.response ? error.response.data : error;
-    }
+    const response: AxiosResponse<T> = await this.instance({
+      url,
+      ...config,
+      ...(config.paramsSerializer
+        ? { paramsSerializer: getParamsSerializer(config.paramsSerializer) }
+        : {}),
+    });
+    return response as T;
   }
 }