various improvements. slightly changed ColorPicker style to match the rest of the dropdown controls.

ExtendedWPFToolkitSolution/Src/WPFToolkit.Extended/ColorPicker/Themes/Generic.xaml

@@ -104,25 +104,31 @@
             <Setter.Value>
                 <ControlTemplate TargetType="ToggleButton">
                     <Grid SnapsToDevicePixels="True">
-                        <chrome:ButtonChrome x:Name="ToggleButtonChrome"
+
+                        <Grid>
+                            <Grid.ColumnDefinitions>
+                                <ColumnDefinition Width="*"/>
+                                <ColumnDefinition Width="Auto"/>
+                            </Grid.ColumnDefinitions>
+
+                            <Border Background="{TemplateBinding Background}" BorderBrush="{TemplateBinding BorderBrush}" BorderThickness="{TemplateBinding BorderThickness}" Padding="{TemplateBinding Padding}" SnapsToDevicePixels="True">
+                                <ContentPresenter Content="{TemplateBinding Content}" ContentTemplate="{TemplateBinding ContentTemplate}" ContentTemplateSelector="{TemplateBinding ContentTemplateSelector}"
+                                                  VerticalAlignment="{TemplateBinding VerticalContentAlignment}" HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}"/>
+                            </Border>
+
+                            <chrome:ButtonChrome x:Name="ToggleButtonChrome" Grid.Column="1"
+                                             CornerRadius="0,2.75,2.75,0"
                                             RenderChecked="{Binding IsOpen, RelativeSource={RelativeSource Mode=FindAncestor, AncestorType=local:ColorPicker}}"
                                             RenderEnabled="{Binding IsEnabled, RelativeSource={RelativeSource Mode=FindAncestor, AncestorType=local:ColorPicker}}"
 											RenderMouseOver="{TemplateBinding IsMouseOver}"
 											RenderPressed="{TemplateBinding IsPressed}" >
 
-                            <Grid>
-                                <Grid.ColumnDefinitions>
-                                    <ColumnDefinition Width="*"/>
-                                    <ColumnDefinition Width="Auto"/>
-                                </Grid.ColumnDefinitions>
-
-                                <ContentPresenter HorizontalAlignment="Stretch" VerticalAlignment="Stretch" SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" />
-
                                 <Grid x:Name="arrowGlyph" IsHitTestVisible="False" Grid.Column="1" Margin="5">
                                     <Path Width="7" Height="4" Data="M 0,1 C0,1 0,0 0,0 0,0 3,0 3,0 3,0 3,1 3,1 3,1 4,1 4,1 4,1 4,0 4,0 4,0 7,0 7,0 7,0 7,1 7,1 7,1 6,1 6,1 6,1 6,2 6,2 6,2 5,2 5,2 5,2 5,3 5,3 5,3 4,3 4,3 4,3 4,4 4,4 4,4 3,4 3,4 3,4 3,3 3,3 3,3 2,3 2,3 2,3 2,2 2,2 2,2 1,2 1,2 1,2 1,1 1,1 1,1 0,1 0,1 z" Fill="#FF000000"/>
                                 </Grid>
-                            </Grid>
+                            </chrome:ButtonChrome>
-                        </chrome:ButtonChrome>
+                        </Grid>
+
                     </Grid>
                 </ControlTemplate>
             </Setter.Value>
@@ -139,18 +145,27 @@
     </Style>
 
     <Style TargetType="{x:Type local:ColorPicker}">
+        <Setter Property="Background" Value="White" />
         <Setter Property="BorderBrush" Value="{StaticResource ColorPickerDarkBorderBrush}" />
-        <Setter Property="BorderThickness" Value="1" />
+        <Setter Property="BorderThickness" Value="1,1,0,1" />
         <Setter Property="ButtonStyle" Value="{StaticResource ColorPickerToggleButtonStyle}" />
         <Setter Property="Focusable" Value="False" />
+        <Setter Property="HorizontalContentAlignment" Value="Left" />
+        <Setter Property="VerticalContentAlignment" Value="Center" />
         <Setter Property="Template">
             <Setter.Value>
                 <ControlTemplate TargetType="{x:Type local:ColorPicker}">
                     <Grid>
-                        <ToggleButton x:Name="PART_ColorPickerToggleButton" IsTabStop="True" MinHeight="22" IsChecked="{Binding IsOpen, RelativeSource={RelativeSource TemplatedParent}, Mode=TwoWay}"
+                        <ToggleButton x:Name="PART_ColorPickerToggleButton" IsTabStop="True" MinHeight="22" 
+                                      Background="{TemplateBinding Background}" 
+                                      BorderBrush="{TemplateBinding BorderBrush}" 
+                                      BorderThickness="{TemplateBinding BorderThickness}" 
+                                      VerticalContentAlignment="{TemplateBinding VerticalContentAlignment}" HorizontalContentAlignment="{TemplateBinding HorizontalContentAlignment}"
+                                      Padding="{TemplateBinding Padding}"
+                                      IsChecked="{Binding IsOpen, RelativeSource={RelativeSource TemplatedParent}, Mode=TwoWay}"
                                       IsHitTestVisible="{Binding IsOpen, RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource InverseBoolConverter}}"
                                       Style="{TemplateBinding ButtonStyle}">
-                            <Grid Margin="2,2,0,2">
+                            <Grid Margin="2">
                                 <Border x:Name="ColorOnly" Style="{StaticResource ColorDisplayStyle}" />
 
                                 <Border x:Name="ColorAndName" Background="White" Visibility="Hidden">
@@ -162,7 +177,7 @@
                             </Grid>
                         </ToggleButton>
 
-                        <Popup x:Name="PART_ColorPickerPalettePopup"  VerticalAlignment="Bottom" IsOpen="{Binding ElementName=PART_ColorPickerToggleButton, Path=IsChecked}" StaysOpen="False" AllowsTransparency="True" Focusable="False"  HorizontalOffset="1" VerticalOffset="1"  >
+                        <Popup x:Name="PART_ColorPickerPalettePopup"  VerticalAlignment="Bottom" IsOpen="{Binding ElementName=PART_ColorPickerToggleButton, Path=IsChecked}" StaysOpen="False" AllowsTransparency="True" Focusable="False"  HorizontalOffset="1" VerticalOffset="1" PopupAnimation="Slide"  >
                             <Border BorderThickness="1" Background="{StaticResource PopupBackgroundBrush}" BorderBrush="{StaticResource ColorPickerDarkBorderBrush}" Padding="3">
                                 <Grid>
                                     <Grid.RowDefinitions>

ExtendedWPFToolkitSolution/Src/WPFToolkit.Extended/PropertyGrid/Implementation/Editors/CollectionEditor.xaml

@@ -1,14 +1,50 @@
 <UserControl x:Class="Microsoft.Windows.Controls.PropertyGrid.Editors.CollectionEditor"
              xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
-             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
+             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-    <Grid>
+             xmlns:chrome="clr-namespace:Microsoft.Windows.Controls.Chromes" >
-        <Grid.ColumnDefinitions>
+
-            <ColumnDefinition Width="*" />
+    <UserControl.Resources>
-            <ColumnDefinition Width="Auto" />
+        <Style x:Key="ButtonStyle" TargetType="Button">
-        </Grid.ColumnDefinitions>
+            <Setter Property="Background" Value="White"/>
-        <TextBlock Text="(Collection)" VerticalAlignment="Center" />
+            <Setter Property="BorderThickness" Value="0" />
-        <Button x:Name="_editorButton" Grid.Column="1"
+            <Setter Property="Padding" Value="2,0,0,0" />
-                Content=" ... "
+            <Setter Property="HorizontalContentAlignment" Value="Left" />
-                Click="Button_Click"/>
+            <Setter Property="VerticalContentAlignment" Value="Center" />
-    </Grid>
+            <Setter Property="Template">
+                <Setter.Value>
+                    <ControlTemplate TargetType="Button">
+                        <Grid SnapsToDevicePixels="True">
+
+                            <Grid>
+                                <Grid.ColumnDefinitions>
+                                    <ColumnDefinition Width="*"/>
+                                    <ColumnDefinition Width="Auto"/>
+                                </Grid.ColumnDefinitions>
+
+                                <Border Background="{TemplateBinding Background}" BorderBrush="{TemplateBinding BorderBrush}" BorderThickness="{TemplateBinding BorderThickness}" Padding="{TemplateBinding Padding}" SnapsToDevicePixels="True">
+                                    <ContentPresenter Content="{TemplateBinding Content}" ContentTemplate="{TemplateBinding ContentTemplate}" ContentTemplateSelector="{TemplateBinding ContentTemplateSelector}"
+                                                  VerticalAlignment="{TemplateBinding VerticalContentAlignment}" HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}"/>
+                                </Border>
+
+                                <chrome:ButtonChrome x:Name="ToggleButtonChrome" Grid.Column="1"
+                                             CornerRadius="0,2.75,2.75,0"
+                                            RenderEnabled="{Binding IsEnabled, RelativeSource={RelativeSource Mode=FindAncestor, AncestorType=UserControl}}"
+											RenderMouseOver="{TemplateBinding IsMouseOver}" >
+
+                                    <Grid x:Name="arrowGlyph" IsHitTestVisible="False" Grid.Column="1" Margin="5">
+                                        <Path Width="7" Height="4" Data="M 0,1 C0,1 0,0 0,0 0,0 3,0 3,0 3,0 3,1 3,1 3,1 4,1 4,1 4,1 4,0 4,0 4,0 7,0 7,0 7,0 7,1 7,1 7,1 6,1 6,1 6,1 6,2 6,2 6,2 5,2 5,2 5,2 5,3 5,3 5,3 4,3 4,3 4,3 4,4 4,4 4,4 3,4 3,4 3,4 3,3 3,3 3,3 2,3 2,3 2,3 2,2 2,2 2,2 1,2 1,2 1,2 1,1 1,1 1,1 0,1 0,1 z" Fill="#FF000000"/>
+                                    </Grid>
+                                </chrome:ButtonChrome>
+                            </Grid>
+
+                        </Grid>
+                    </ControlTemplate>
+                </Setter.Value>
+            </Setter>
+        </Style>
+    </UserControl.Resources>
+
+    <Button Grid.Column="1" IsTabStop="True" MinHeight="22" SnapsToDevicePixels="True"
+            Content="(Collection)"
+            Style="{StaticResource ButtonStyle}" Click="Button_Click" />
 </UserControl>

ExtendedWPFToolkitSolution/Src/WPFToolkit.Extended/PropertyGrid/Implementation/Editors/CollectionEditor.xaml.cs

@@ -17,12 +17,6 @@ namespace Microsoft.Windows.Controls.PropertyGrid.Editors
             InitializeComponent();
         }
 
-        public CollectionEditor(bool isEditable) : this()
-        {
-            if (!isEditable)
-                _editorButton.Visibility = System.Windows.Visibility.Collapsed;
-        }
-
         public void Attach(PropertyItem propertyItem)
         {
             _item = propertyItem;

ExtendedWPFToolkitSolution/Src/WPFToolkit.Extended/PropertyGrid/Implementation/Editors/ColorEditor.cs

@@ -1,5 +1,4 @@
 using System;
-using Microsoft.Windows.Controls.Core.Converters;
 
 namespace Microsoft.Windows.Controls.PropertyGrid.Editors
 {
@@ -7,6 +6,7 @@ namespace Microsoft.Windows.Controls.PropertyGrid.Editors
     {
         protected override void SetControlProperties()
         {
+            Editor.BorderThickness = new System.Windows.Thickness(0);
             Editor.DisplayColorAndName = true;
         }
         protected override void SetValueDependencyProperty()

ExtendedWPFToolkitSolution/Src/WPFToolkit.Extended/PropertyGrid/Implementation/Editors/DateTimeUpDownEditor.cs

@@ -4,6 +4,10 @@ namespace Microsoft.Windows.Controls.PropertyGrid.Editors
 {
     public class DateTimeUpDownEditor : TypeEditor<DateTimeUpDown>
     {
+        protected override void SetControlProperties()
+        {
+            Editor.BorderThickness = new System.Windows.Thickness(0);
+        }
         protected override void SetValueDependencyProperty()
         {
             ValueProperty = DateTimeUpDown.ValueProperty;

ExtendedWPFToolkitSolution/Src/WPFToolkit.Extended/PropertyGrid/Implementation/Editors/PrimitiveTypeCollectionEditor.cs

@@ -6,6 +6,7 @@ namespace Microsoft.Windows.Controls.PropertyGrid.Editors
     {
         protected override void SetControlProperties()
         {
+            Editor.BorderThickness = new System.Windows.Thickness(0);
             Editor.Content = "(Collection)";
         }
 

ExtendedWPFToolkitSolution/Src/WPFToolkit.Extended/PropertyGrid/Implementation/Editors/TextBoxEditor.cs

@@ -3,8 +3,13 @@ using System.Windows.Controls;
 
 namespace Microsoft.Windows.Controls.PropertyGrid.Editors
 {
-    public class TextBoxEditor : TypeEditor<TextBox>
+    public class TextBoxEditor : TypeEditor<WatermarkTextBox>
     {
+        protected override void SetControlProperties()
+        {
+            Editor.BorderThickness = new System.Windows.Thickness(0);
+        }
+
         protected override void SetValueDependencyProperty()
         {
             ValueProperty = TextBox.TextProperty;

ExtendedWPFToolkitSolution/Src/WPFToolkit.Extended/WatermarkTextBox/Implementation/WatermarkTextBox.cs

@@ -57,15 +57,15 @@ namespace Microsoft.Windows.Controls
 
         protected override void OnGotKeyboardFocus(KeyboardFocusChangedEventArgs e)
         {
+            base.OnGotKeyboardFocus(e);
+
             if (SelectAllOnGotFocus)
                 SelectAll();
-
-            base.OnGotKeyboardFocus(e);
         }
 
         protected override void OnPreviewMouseLeftButtonDown(MouseButtonEventArgs e)
         {
-            if (!IsKeyboardFocused)
+            if (!IsKeyboardFocused && SelectAllOnGotFocus)
             {
                 e.Handled = true;
                 Focus();