Browse Source

Remove legacy performance hack of remove _revs from component definitions as this was sometimes leading to invalid JSON, preventing the app from loading

master
Andrew Kingston 5 years ago
parent
commit
0a3dede736
  1. 12
      packages/builder/src/components/design/AppPreview/CurrentItemPreview.svelte

12
packages/builder/src/components/design/AppPreview/CurrentItemPreview.svelte

@ -69,15 +69,7 @@
previewDevice: $store.previewDevice,
messagePassing: $store.clientFeatures.messagePassing,
}
// Saving pages and screens to the DB causes them to have _revs.
// These revisions change every time a save happens and causes
// these reactive statements to fire, even though the actual
// definition hasn't changed.
// By deleting all _rev properties we can avoid this and increase
// performance.
$: json = JSON.stringify(previewData)
$: strippedJson = json.replace(/"_rev":\s*"[^"]+"/g, `"_rev":""`)
// Update the iframe with the builder info to render the correct preview
const refreshContent = message => {
@ -87,7 +79,7 @@
}
// Refresh the preview when required
$: refreshContent(strippedJson)
$: refreshContent(json)
function receiveMessage(message) {
const handlers = {
@ -102,7 +94,7 @@
if (!$store.clientFeatures.intelligentLoading) {
loading = false
}
refreshContent(strippedJson)
refreshContent(json)
},
[MessageTypes.ERROR]: event => {
// Catch any app errors

Loading…
Cancel
Save