Browse Source
Merge pull request #1625 from Budibase/octet-stream-issue
set content type on client lib upload
gh-pages
Martin McKeaveney
5 years ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with
7 additions and
5 deletions
-
packages/auth/src/objectStore/index.js
-
packages/server/src/api/controllers/static/templates/BudibaseApp.svelte
-
packages/server/src/utilities/fileSystem/newApp.js
|
|
|
@ -159,7 +159,7 @@ exports.upload = async ({ |
|
|
|
* Similar to the upload function but can be used to send a file stream |
|
|
|
* through to the object store. |
|
|
|
*/ |
|
|
|
exports.streamUpload = async (bucketName, filename, stream) => { |
|
|
|
exports.streamUpload = async (bucketName, filename, stream, extra = {}) => { |
|
|
|
const objectStore = exports.ObjectStore(bucketName) |
|
|
|
await exports.makeSureBucketExists(objectStore, bucketName) |
|
|
|
|
|
|
|
@ -167,6 +167,7 @@ exports.streamUpload = async (bucketName, filename, stream) => { |
|
|
|
Bucket: sanitizeBucket(bucketName), |
|
|
|
Key: sanitizeKey(filename), |
|
|
|
Body: stream, |
|
|
|
...extra, |
|
|
|
} |
|
|
|
return objectStore.upload(params).promise() |
|
|
|
} |
|
|
|
|
|
|
|
@ -31,7 +31,6 @@ |
|
|
|
margin: 0; |
|
|
|
padding: 0; |
|
|
|
} |
|
|
|
|
|
|
|
*, |
|
|
|
*:before, |
|
|
|
*:after { |
|
|
|
@ -41,9 +40,9 @@ |
|
|
|
</svelte:head> |
|
|
|
|
|
|
|
<body id="app"> |
|
|
|
<script src={clientLibPath}> |
|
|
|
<script type="application/javascript" src={clientLibPath}> |
|
|
|
</script> |
|
|
|
<script> |
|
|
|
<script type="application/javascript"> |
|
|
|
loadBudibase() |
|
|
|
</script> |
|
|
|
</body> |
|
|
|
|
|
|
|
@ -30,5 +30,7 @@ exports.uploadClientLibrary = async appId => { |
|
|
|
const sourcepath = require.resolve("@budibase/client") |
|
|
|
const destPath = join(appId, "budibase-client.js") |
|
|
|
|
|
|
|
await streamUpload(BUCKET_NAME, destPath, fs.createReadStream(sourcepath)) |
|
|
|
await streamUpload(BUCKET_NAME, destPath, fs.createReadStream(sourcepath), { |
|
|
|
ContentType: "application/javascript", |
|
|
|
}) |
|
|
|
} |
|
|
|
|
