Browse Source

Merge pull request #940 from Budibase/bugfix/csv-charset-problem

fixes encoding issue of file to work with non-english chars
gh-pages
Kevin Åberg Kultalahti 6 years ago
committed by GitHub
parent
commit
1f5898763c
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      packages/builder/src/components/backend/TableNavigator/TableDataImport.svelte
  2. 2
      packages/server/src/utilities/tests/__snapshots__/csvParser.spec.js.snap
  3. 2
      packages/server/src/utilities/tests/csvParser.spec.js
  4. 2
      packages/server/src/utilities/tests/test.csv

2
packages/builder/src/components/backend/TableNavigator/TableDataImport.svelte

@ -82,7 +82,7 @@
files = fileArray files = fileArray
validateCSV() validateCSV()
}) })
reader.readAsBinaryString(fileArray[0]) reader.readAsText(fileArray[0])
} }
async function omitColumn(columnName) { async function omitColumn(columnName) {

2
packages/server/src/utilities/tests/__snapshots__/csvParser.spec.js.snap

@ -5,7 +5,7 @@ Array [
Object { Object {
"Address": "5 Sesame Street", "Address": "5 Sesame Street",
"Age": 4324, "Age": 4324,
"Name": "Bert", "Name": "Bertå",
}, },
Object { Object {
"Address": "1 World Trade Center", "Address": "1 World Trade Center",

2
packages/server/src/utilities/tests/csvParser.spec.js

@ -89,7 +89,7 @@ describe("CSV Parser", () => {
}) })
).toEqual([ ).toEqual([
{ {
Name: "Bert", Name: "Bertå",
}, },
{ {
Name: "Ernie", Name: "Ernie",

2
packages/server/src/utilities/tests/test.csv

@ -1,4 +1,4 @@
"Name","Age","Address" "Name","Age","Address"
"Bert","4324","5 Sesame Street" "Bertå","4324","5 Sesame Street"
"Ernie","34","1 World Trade Center" "Ernie","34","1 World Trade Center"
"Big Bird","23423","44 Second Avenue" "Big Bird","23423","44 Second Avenue"
1 Name Age Address
2 Bert Bertå 4324 5 Sesame Street
3 Ernie 34 1 World Trade Center
4 Big Bird 23423 44 Second Avenue
Loading…
Cancel
Save