From 439043c6daa465254ca1d0ffc8ae3c87b3906dd8 Mon Sep 17 00:00:00 2001
From: Peter Clement <peter@budibase.com>
Date: Tue, 15 Feb 2022 15:05:36 +0000
Subject: [PATCH] disallow bindings selection for other actions

---
 .../integration/createAutomation.spec.js      |  8 +++---
 .../FlowChart/FlowItem.svelte                 | 28 +++++++++++--------
 2 files changed, 20 insertions(+), 16 deletions(-)

diff --git a/packages/builder/cypress/integration/createAutomation.spec.js b/packages/builder/cypress/integration/createAutomation.spec.js
index efd3c7d02..6be0e07e0 100644
--- a/packages/builder/cypress/integration/createAutomation.spec.js
+++ b/packages/builder/cypress/integration/createAutomation.spec.js
@@ -19,19 +19,19 @@ context("Create a automation", () => {
 
     // Setup trigger
     cy.contains("Setup").click()
-    cy.get(".spectrum-Picker-label").click()
+    cy.get(".spectrum-Picker-label").first().click()
     cy.wait(500)
     cy.contains("dog").click()
     cy.wait(2000)
     // Create action
-    cy.get(".block > .spectrum-Icon").click()
+    cy.get(".block > .spectrum-Icon").first().click()
     cy.get(".modal-inner-wrapper").within(() => {
       cy.wait(1000)
       cy.contains("Create Row").trigger('mouseover').click().click()
       cy.get(".spectrum-Button--cta").click()
     })
     cy.contains("Setup").click()
-    cy.get(".spectrum-Picker-label").click()
+    cy.get(".spectrum-Picker-label").first().click()
     cy.contains("dog").click()
     cy.get(".spectrum-Textfield-input")
     .first()
@@ -43,7 +43,7 @@ context("Create a automation", () => {
 
     cy.get(".modal-inner-wrapper").within(() => {
       cy.wait(1000)
-      cy.get(".spectrum-Picker-label").click()
+      cy.get(".spectrum-Picker-label").first().click()
       cy.contains("dog").click()
       cy.wait(1000)
       cy.get(".spectrum-Textfield-input")
diff --git a/packages/builder/src/components/automation/AutomationBuilder/FlowChart/FlowItem.svelte b/packages/builder/src/components/automation/AutomationBuilder/FlowChart/FlowItem.svelte
index 984c4e906..0b3344b60 100644
--- a/packages/builder/src/components/automation/AutomationBuilder/FlowChart/FlowItem.svelte
+++ b/packages/builder/src/components/automation/AutomationBuilder/FlowChart/FlowItem.svelte
@@ -29,7 +29,9 @@
   let blockComplete
 
   $: rowControl = $automationStore.selectedAutomation.automation.rowControl
-
+  $: showBindingPicker =
+    block.stepId === "CREATE_ROW" || block.stepId === "UPDATE_ROW"
+  $: console.log(showBindingPicker)
   $: testResult = $automationStore.selectedAutomation.testResults?.steps.filter(
     step => (block.id ? step.id === block.id : step.stepId === block.stepId)
   )
@@ -153,17 +155,19 @@
           </ActionButton>
           {#if !isTrigger}
             <div class="block-options">
-              <div>
-                <Select
-                  on:change={toggleFieldControl}
-                  quiet
-                  defaultValue="Use values"
-                  autoWidth
-                  value={rowControl ? "Use bindings" : "Use values"}
-                  options={["Use values", "Use bindings"]}
-                  placeholder={null}
-                />
-              </div>
+              {#if showBindingPicker}
+                <div>
+                  <Select
+                    on:change={toggleFieldControl}
+                    quiet
+                    defaultValue="Use values"
+                    autoWidth
+                    value={rowControl ? "Use bindings" : "Use values"}
+                    options={["Use values", "Use bindings"]}
+                    placeholder={null}
+                  />
+                </div>
+              {/if}
               <div class="delete-padding" on:click={() => deleteStep()}>
                 <Icon name="DeleteOutline" />
               </div>