Browse Source

Merge pull request #746 from Budibase/mike-fixes

Mike fixes
gh-pages
Michael Shanks 6 years ago
committed by GitHub
parent
commit
77ed92b444
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      packages/builder/src/builderStore/store/screenTemplates/sanitizeUrl.js
  2. 6
      packages/client/src/render/screenRouter.js

2
packages/builder/src/builderStore/store/screenTemplates/sanitizeUrl.js

@ -4,7 +4,7 @@ export default function(url) {
.map(part => {
// if parameter, then use as is
if (part.startsWith(":")) return part
return encodeURIComponent(part.replace(" ", "-"))
return encodeURIComponent(part.replace(/ /g, "-"))
})
.join("/")
.toLowerCase()

6
packages/client/src/render/screenRouter.js

@ -44,7 +44,7 @@ export const screenRouter = ({ screens, onScreenSelected, window }) => {
}
const routes = screens.map(s => makeRootedPath(s.route))
let fallback = routes.findIndex(([p]) => p === "*")
let fallback = routes.findIndex(([p]) => p === makeRootedPath("*"))
if (fallback < 0) fallback = 0
let current
@ -53,7 +53,7 @@ export const screenRouter = ({ screens, onScreenSelected, window }) => {
const _url = makeRootedPath(url.state || url)
current = routes.findIndex(
p =>
p !== "*" &&
p !== makeRootedPath("*") &&
new RegExp("^" + p.toLowerCase() + "$").test(_url.toLowerCase())
)
@ -61,6 +61,8 @@ export const screenRouter = ({ screens, onScreenSelected, window }) => {
if (current === -1) {
routes.forEach((p, i) => {
// ignore home - which matched everything
if (p === makeRootedPath("*")) return
const pm = regexparam(p)
const matches = pm.pattern.exec(_url)

Loading…
Cancel
Save