Merge pull request #6883 from Budibase/fix/quota-409s

Ignore harmless 409s in write-through cache

packages/backend-core/src/cache/writethrough.ts

@@ -1,5 +1,6 @@
 import BaseCache from "./base"
 import { getWritethroughClient } from "../redis/init"
+import { logWarn } from "../logging"
 
 const DEFAULT_WRITE_RATE_MS = 10000
 let CACHE: BaseCache | null = null
@@ -51,10 +52,8 @@ export async function put(
       if (err.status !== 409) {
         throw err
       } else {
-        // get the rev, update over it - this is risky, may change in future
+        // Swallow 409s but log them
-        const readDoc = await db.get(doc._id)
+        logWarn(`Ignoring conflict in write-through cache`)
-        doc._rev = readDoc._rev
-        await writeDb(doc)
       }
     }
   }

packages/backend-core/src/logging.ts

@@ -15,6 +15,11 @@ export function logAlert(message: string, e?: any) {
   console.error(`bb-alert: ${message} ${errorJson}`)
 }
 
+export function logWarn(message: string) {
+  console.warn(`bb-warn: ${message}`)
+}
+
 export default {
   logAlert,
+  logWarn,
 }