Merge remote-tracking branch 'origin/develop' into feature/required-field-focus

lerna.json

@@ -1,5 +1,5 @@
 {
-  "version": "1.0.176",
+  "version": "1.0.177",
   "npmClient": "yarn",
   "packages": [
     "packages/*"

packages/backend-core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@budibase/backend-core",
-  "version": "1.0.176",
+  "version": "1.0.177",
   "description": "Budibase backend core libraries used in server and worker",
   "main": "src/index.js",
   "author": "Budibase",

packages/bbui/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@budibase/bbui",
   "description": "A UI solution used in the different Budibase projects.",
-  "version": "1.0.176",
+  "version": "1.0.177",
   "license": "MPL-2.0",
   "svelte": "src/index.js",
   "module": "dist/bbui.es.js",
@@ -38,7 +38,7 @@
   ],
   "dependencies": {
     "@adobe/spectrum-css-workflow-icons": "^1.2.1",
-    "@budibase/string-templates": "^1.0.176",
+    "@budibase/string-templates": "^1.0.177",
     "@spectrum-css/actionbutton": "^1.0.1",
     "@spectrum-css/actiongroup": "^1.0.1",
     "@spectrum-css/avatar": "^3.0.2",

packages/builder/cypress/integration/templates/HR/hrTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter HR Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/HR/jobApplicationTracker.spec.js

@@ -8,13 +8,13 @@ filterTests(["all"], () => {
     before(() => {
         cy.login()
         cy.deleteApp(templateName)
-        cy.visit(`${Cypress.config().baseUrl}/builder`, {
+        // Template navigation
+        cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`, {
             onBeforeLoad(win) {
                 cy.stub(win, 'open')
             }
         })
         cy.wait(2000)
-        cy.templateNavigation()
         })
 
     it("should create and publish app with Job Application Tracker template", () => {
@@ -35,19 +35,10 @@ filterTests(["all"], () => {
             cy.get(".spectrum-Button").contains("Create app").click({ force: true })
         })
 
-        // Publish App
+        // Publish App & Verify it opened
         cy.wait(2000) // Wait for app to generate
-        cy.get(".toprightnav").contains("Publish").click({ force: true })
+        cy.publishApp(true)
-        cy.get(".spectrum-Dialog-grid").within(() => {
+        cy.window().its('open').should('be.calledOnce')
-            cy.get(".spectrum-Button").contains("Publish").click({ force: true })
-        })
-
-        // Verify Published app
-        cy.wait(2000) // Wait for App to publish and modal to appear
-        cy.get(".spectrum-Dialog-grid").within(() => {
-            cy.get(".spectrum-Button").contains("View App").click({ force: true })
-            cy.window().its('open').should('be.calledOnce')
-        })
     })
 
     it("should add active/inactive vacancies", () => {

packages/builder/cypress/integration/templates/IT/ITTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter IT Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/IT/ITTicketingSystem.spec.js

@@ -8,13 +8,13 @@ filterTests(["all"], () => {
     before(() => {
         cy.login()
         cy.deleteApp(templateName)
-        cy.visit(`${Cypress.config().baseUrl}/builder`, {
+        // Template navigation
+        cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`, {
             onBeforeLoad(win) {
                 cy.stub(win, 'open')
             }
         })
         cy.wait(2000)
-        cy.templateNavigation()
         })
 
     it("should create and publish app with IT Ticketing System template", () => {
@@ -35,19 +35,10 @@ filterTests(["all"], () => {
             cy.get(".spectrum-Button").contains("Create app").click({ force: true })
         })
 
-        // Publish App
+        // Publish App & Verify it opened
         cy.wait(2000) // Wait for app to generate
-        cy.get(".toprightnav").contains("Publish").click({ force: true })
+        cy.publishApp(true)
-        cy.get(".spectrum-Dialog-grid").within(() => {
+        cy.window().its('open').should('be.calledOnce')
-            cy.get(".spectrum-Button").contains("Publish").click({ force: true })
-        })
-
-        // Verify Published app
-        cy.wait(2000) // Wait for App to publish and modal to appear
-        cy.get(".spectrum-Dialog-grid").within(() => {
-            cy.get(".spectrum-Button").contains("View App").click({ force: true })
-            cy.window().its('open').should('be.calledOnce')
-        })
     })
 
     xit("should filter tickets by status", () => {

packages/builder/cypress/integration/templates/adminPanels/adminPanelsTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter Admin Panels Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/approvalApps/approvalAppsTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter Approval Apps Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/businessApps/businessAppsTemplateDetails.spec.js

@@ -7,14 +7,8 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
+      
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
-
       // Filter Business Apps Templates
       cy.get(".template-category-filters").within(() => {
         cy.get('[data-cy="Business Apps"]').click()

packages/builder/cypress/integration/templates/directories/directoriesTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter Directories Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/forms/formsTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter Forms Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/healthcare/healthcareTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter Healthcare Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/legal/legalTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter Legal Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/logistics/logisticsTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter Logistics Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/manufacturing/manufacturingTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter Manufacturing Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/marketing/leadGenerationForm.spec.js

@@ -0,0 +1,44 @@
+import filterTests from "../../../support/filterTests"
+
+filterTests(["all"], () => {
+  context("Lead Generation Form Template Functionality", () => {
+    const templateName = "Lead Generation Form"
+    const templateNameParsed = templateName.toLowerCase().replace(/\s+/g, '-')
+    
+    before(() => {
+        cy.login()
+        cy.deleteApp(templateName)
+        // Template navigation
+        cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`, {
+            onBeforeLoad(win) {
+                cy.stub(win, 'open')
+            }
+        })
+        cy.wait(2000)
+        })
+
+    it("should create and publish app with Lead Generation Form template", () => {
+        // Select Lead Generation Form template
+        cy.get(".template-thumbnail-text")
+            .contains(templateName).parentsUntil(".template-grid").within(() => {
+                cy.get(".spectrum-Button").contains("Use template").click({ force: true })
+            })
+
+        // Confirm URL matches template name
+        const appUrl = cy.get(".app-server")
+        appUrl.invoke('text').then(appUrlText => {
+            expect(appUrlText).to.equal(`${Cypress.config().baseUrl}/app/` + templateNameParsed)
+        })
+
+        // Create App
+        cy.get(".spectrum-Dialog-grid").within(() => {
+            cy.get(".spectrum-Button").contains("Create app").click({ force: true })
+        })
+
+        // Publish App & Verify it opened
+        cy.wait(2000) // Wait for app to generate
+        cy.publishApp(true)
+        cy.window().its('open').should('be.calledOnce')
+        })
+    })
+})

packages/builder/cypress/integration/templates/marketing/marketingTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter Marketing Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/operations/operationsTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter Operations Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/integration/templates/portals/portalsTemplateDetails.spec.js

@@ -7,21 +7,15 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
+
-      .then(val => {
+      // Filter Portal Templates
-        if (val.length > 0) {
+      cy.get(".template-category-filters").within(() => {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
+        cy.get('[data-cy="Portal"]').click()
-        }
+    })
-      })
     })
 
   it("should verify the details option for Portal templates", () => {
-    // Filter Portal Templates
-    cy.get(".template-category-filters").within(() => {
-        cy.get('[data-cy="Portal"]').click()
-      })
-    
     cy.get(".template-grid").find(".template-card").its('length')
     .then(len => {
       for (let i = 0; i < len; i++) {

packages/builder/cypress/integration/templates/professionalServices/professionalServicesTemplateDetails.spec.js

@@ -7,13 +7,7 @@ filterTests(["all"], () => {
       cy.login()
 
       // Template navigation
-      cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
+      cy.visit(`${Cypress.config().baseUrl}/builder/portal/apps/templates`)
-      .its("body")
-      .then(val => {
-        if (val.length > 0) {
-          cy.get(".spectrum-Button").contains("Templates").click({force: true})
-        }
-      })
 
       // Filter Professional Services Templates
       cy.get(".template-category-filters").within(() => {

packages/builder/cypress/support/commands.js

@@ -35,7 +35,7 @@ Cypress.Commands.add("login", () => {
 Cypress.Commands.add("closeModal", () => {
   cy.get(".spectrum-Modal").within(() => {
     cy.get(".close-icon").click()
-    cy.wait(500)
+    cy.wait(1000) // Wait for modal to close
   })
 })
 
@@ -222,6 +222,21 @@ Cypress.Commands.add("createTestTableWithData", () => {
   cy.addColumn("dog", "age", "Number")
 })
 
+Cypress.Commands.add("publishApp", (viewApp = false) => {
+  cy.get(".toprightnav").contains("Publish").click({ force: true })
+  cy.get(".spectrum-Dialog-grid").within(() => {
+    cy.get(".spectrum-Button").contains("Publish").click({ force: true })
+  })
+  cy.wait(2000) // Wait for App to publish and modal to appear
+  cy.get(".spectrum-Dialog-grid").within(() => {
+    if (viewApp) {
+      cy.get(".spectrum-Button").contains("View App").click({ force: true })
+    } else {
+      cy.get(".spectrum-Button").contains("Done").click({ force: true })
+    }
+  })
+})
+
 Cypress.Commands.add("createTable", (tableName, initialTable) => {
   if (!initialTable) {
     cy.navigateToDataSection()
@@ -671,15 +686,3 @@ Cypress.Commands.add("createRestQuery", (method, restUrl, queryPrettyName) => {
     .should("contain", method)
     .and("contain", queryPrettyName)
 })
-
-Cypress.Commands.add("templateNavigation", () => {
-  // Navigates to templates section
-  cy.request(`${Cypress.config().baseUrl}/api/applications?status=all`)
-    .its("body")
-    .then(val => {
-      // Templates button needs clicked if apps already exist
-      if (val.length > 0) {
-        cy.get(".spectrum-Button").contains("Templates").click({ force: true })
-      }
-    })
-})

packages/builder/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@budibase/builder",
-  "version": "1.0.176",
+  "version": "1.0.177",
   "license": "GPL-3.0",
   "private": true,
   "scripts": {
@@ -69,10 +69,10 @@
     }
   },
   "dependencies": {
-    "@budibase/bbui": "^1.0.176",
+    "@budibase/bbui": "^1.0.177",
-    "@budibase/client": "^1.0.176",
+    "@budibase/client": "^1.0.177",
-    "@budibase/frontend-core": "^1.0.176",
+    "@budibase/frontend-core": "^1.0.177",
-    "@budibase/string-templates": "^1.0.176",
+    "@budibase/string-templates": "^1.0.177",
     "@sentry/browser": "5.19.1",
     "@spectrum-css/page": "^3.0.1",
     "@spectrum-css/vars": "^3.0.1",

packages/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@budibase/cli",
-  "version": "1.0.176",
+  "version": "1.0.177",
   "description": "Budibase CLI, for developers, self hosting and migrations.",
   "main": "src/index.js",
   "bin": {

packages/client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@budibase/client",
-  "version": "1.0.176",
+  "version": "1.0.177",
   "license": "MPL-2.0",
   "module": "dist/budibase-client.js",
   "main": "dist/budibase-client.js",
@@ -19,9 +19,9 @@
     "dev:builder": "rollup -cw"
   },
   "dependencies": {
-    "@budibase/bbui": "^1.0.176",
+    "@budibase/bbui": "^1.0.177",
-    "@budibase/frontend-core": "^1.0.176",
+    "@budibase/frontend-core": "^1.0.177",
-    "@budibase/string-templates": "^1.0.176",
+    "@budibase/string-templates": "^1.0.177",
     "@spectrum-css/button": "^3.0.3",
     "@spectrum-css/card": "^3.0.3",
     "@spectrum-css/divider": "^1.0.3",

packages/frontend-core/package.json

@@ -1,12 +1,12 @@
 {
   "name": "@budibase/frontend-core",
-  "version": "1.0.176",
+  "version": "1.0.177",
   "description": "Budibase frontend core libraries used in builder and client",
   "author": "Budibase",
   "license": "MPL-2.0",
   "svelte": "src/index.js",
   "dependencies": {
-    "@budibase/bbui": "^1.0.176",
+    "@budibase/bbui": "^1.0.177",
     "lodash": "^4.17.21",
     "svelte": "^3.46.2"
   }

packages/server/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@budibase/server",
   "email": "hi@budibase.com",
-  "version": "1.0.176",
+  "version": "1.0.177",
   "description": "Budibase Web Server",
   "main": "src/index.ts",
   "repository": {
@@ -70,10 +70,10 @@
   "license": "GPL-3.0",
   "dependencies": {
     "@apidevtools/swagger-parser": "^10.0.3",
-    "@budibase/backend-core": "^1.0.175",
+    "@budibase/backend-core": "^1.0.177",
-    "@budibase/client": "^1.0.176",
+    "@budibase/client": "^1.0.177",
     "@budibase/pro": "^1.0.175",
-    "@budibase/string-templates": "^1.0.176",
+    "@budibase/string-templates": "^1.0.177",
     "@bull-board/api": "^3.7.0",
     "@bull-board/koa": "^3.7.0",
     "@elastic/elasticsearch": "7.10.0",

packages/string-templates/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@budibase/string-templates",
-  "version": "1.0.176",
+  "version": "1.0.177",
   "description": "Handlebars wrapper for Budibase templating.",
   "main": "src/index.cjs",
   "module": "dist/bundle.mjs",

packages/worker/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@budibase/worker",
   "email": "hi@budibase.com",
-  "version": "1.0.176",
+  "version": "1.0.177",
   "description": "Budibase background service",
   "main": "src/index.ts",
   "repository": {
@@ -32,9 +32,9 @@
   "author": "Budibase",
   "license": "GPL-3.0",
   "dependencies": {
-    "@budibase/backend-core": "^1.0.175",
+    "@budibase/backend-core": "^1.0.177",
     "@budibase/pro": "^1.0.175",
-    "@budibase/string-templates": "^1.0.176",
+    "@budibase/string-templates": "^1.0.177",
     "@koa/router": "^8.0.0",
     "@sentry/node": "6.17.7",
     "@techpass/passport-openidconnect": "^0.3.0",