Browse Source

Extra analytics logging from code review

gh-pages
Michael Shanks 6 years ago
parent
commit
a1db3bfecf
  1. 1
      packages/builder/src/analytics.js
  2. 2
      packages/builder/src/components/database/DataTable/popovers/Calculate.svelte
  3. 4
      packages/builder/src/components/database/DataTable/popovers/Filter.svelte
  4. 1
      packages/builder/src/components/start/CreateAppModal.svelte

1
packages/builder/src/analytics.js

@ -50,6 +50,7 @@ async function identifyByApiKey(apiKey) {
function captureException(err) { function captureException(err) {
if (!analyticsEnabled) return if (!analyticsEnabled) return
Sentry.captureException(err) Sentry.captureException(err)
captureEvent("Error", { error: err.message ? err.message : err })
} }
function captureEvent(eventName, props = {}) { function captureEvent(eventName, props = {}) {

2
packages/builder/src/components/database/DataTable/popovers/Calculate.svelte

@ -36,7 +36,7 @@
function saveView() { function saveView() {
backendUiStore.actions.views.save(view) backendUiStore.actions.views.save(view)
notifier.success(`View ${view.name} saved.`) notifier.success(`View ${view.name} saved.`)
analytics.captureEvent("Added View Calculate") analytics.captureEvent("Added View Calculate", { field: view.field })
dropdown.hide() dropdown.hide()
} }
</script> </script>

4
packages/builder/src/components/database/DataTable/popovers/Filter.svelte

@ -64,7 +64,9 @@
backendUiStore.actions.views.save(view) backendUiStore.actions.views.save(view)
notifier.success(`View ${view.name} saved.`) notifier.success(`View ${view.name} saved.`)
dropdown.hide() dropdown.hide()
analytics.captureEvent("Added View Filter") analytics.captureEvent("Added View Filter", {
filters: JSON.stringify(view.filters),
})
} }
function removeFilter(idx) { function removeFilter(idx) {

1
packages/builder/src/components/start/CreateAppModal.svelte

@ -30,6 +30,7 @@
// make sure we only fetch once, unless API Key is changed // make sure we only fetch once, unless API Key is changed
if (isApiKeyValid === undefined || apiKey !== lastApiKey) { if (isApiKeyValid === undefined || apiKey !== lastApiKey) {
lastApiKey = apiKey
// svelte reactivity was causing a requst to get fired mutiple times // svelte reactivity was causing a requst to get fired mutiple times
// so, we make everything await the same promise, if one exists // so, we make everything await the same promise, if one exists
if (!fetchApiKeyPromise) { if (!fetchApiKeyPromise) {

Loading…
Cancel
Save