Merge pull request #4911 from Budibase/pc/csv-bug-fix

fix button action export for csv

packages/client/src/utils/buttonActions.js

@@ -250,9 +250,9 @@ const exportDataHandler = async action => {
       const data = await API.exportRows({
         tableId: selection.tableId,
         rows: selection.selectedRows,
+        format: action.parameters.type,
       })
-
+      download(data, `${selection.tableId}.${action.parameters.type}`)
-      download(JSON.stringify(data), `export.${action.parameters.type}`)
     } catch (error) {
       notificationStore.actions.error("There was an error exporting the data")
     }

packages/frontend-core/src/api/rows.js

@@ -66,12 +66,15 @@ export const buildRowEndpoints = API => ({
    * @param tableId the table ID to export the rows from
    * @param rows the array of rows to export
    */
-  exportRows: async ({ tableId, rows }) => {
+  exportRows: async ({ tableId, rows, format }) => {
     return await API.post({
-      url: `/api/${tableId}/rows/exportRows`,
+      url: `/api/${tableId}/rows/exportRows?format=${format}`,
       body: {
         rows,
       },
+      parseResponse: async response => {
+        return await response.text()
+      },
     })
   },
 })

packages/server/src/api/controllers/row/external.js

@@ -10,6 +10,8 @@ const {
 } = require("../../../integrations/utils")
 const ExternalRequest = require("./ExternalRequest")
 const { getAppDB } = require("@budibase/backend-core/context")
+const exporters = require("../view/exporters")
+const { apiFileReturn } = require("../../../utilities/fileSystem")
 
 async function handleRequest(operation, tableId, opts = {}) {
   // make sure the filters are cleaned up, no empty strings for equals, fuzzy or string
@@ -155,6 +157,7 @@ exports.validate = async () => {
 exports.exportRows = async ctx => {
   const { datasourceId, tableName } = breakExternalTableId(ctx.params.tableId)
   const db = getAppDB()
+  let format = ctx.query.format
   const datasource = await db.get(datasourceId)
   if (!datasource || !datasource.entities) {
     ctx.throw(400, "Datasource has not been configured for plus API.")
@@ -164,13 +167,22 @@ exports.exportRows = async ctx => {
   ctx.request.body = {
     query: {
       oneOf: {
-        [table.primaryDisplay]: ctx.request.body.map(
+        [table.primaryDisplay]: ctx.request.body.rows.map(
           id => breakRowIdField(id)[0]
         ),
       },
     },
   }
-  return exports.search(ctx)
+
+  let result = await exports.search(ctx)
+
+  let headers = Object.keys(result.rows[0])
+  const exporter = exporters[format]
+  const filename = `export.${format}`
+
+  // send down the file
+  ctx.attachment(filename)
+  return apiFileReturn(exporter(headers, result.rows))
 }
 
 exports.fetchEnrichedRow = async ctx => {

packages/server/src/api/controllers/row/internal.js

@@ -27,6 +27,8 @@ const {
 const { cloneDeep } = require("lodash/fp")
 const { getAppDB } = require("@budibase/backend-core/context")
 const { finaliseRow, updateRelatedFormula } = require("./staticFormula")
+const exporters = require("../view/exporters")
+const { apiFileReturn } = require("../../../utilities/fileSystem")
 
 const CALCULATION_TYPES = {
   SUM: "sum",
@@ -366,6 +368,7 @@ exports.exportRows = async ctx => {
   const db = getAppDB()
   const table = await db.get(ctx.params.tableId)
   const rowIds = ctx.request.body.rows
+  let format = ctx.query.format
   let response = (
     await db.allDocs({
       include_docs: true,
@@ -375,7 +378,13 @@ exports.exportRows = async ctx => {
 
   let rows = await outputProcessing(table, response)
 
-  return rows
+  let headers = Object.keys(rows[0])
+  const exporter = exporters[format]
+  const filename = `export.${format}`
+
+  // send down the file
+  ctx.attachment(filename)
+  return apiFileReturn(exporter(headers, rows))
 }
 
 exports.fetchEnrichedRow = async ctx => {