Merge pull request #1280 from Budibase/fix/deployment-error-modal

Fix/deployment error modal

packages/builder/src/components/deploy/DeploymentHistory.svelte

@@ -80,6 +80,7 @@
   }
 
   function showErrorReasonModal(err) {
+    if (!err) return
     errorReason = err
     errorReasonModal.show()
   }
@@ -118,13 +119,11 @@
             {#if deployment.status.toLowerCase() === 'pending'}
               <Spinner size="10" />
             {/if}
-            <div class={`deployment-status ${deployment.status}`}>
+            <div on:click={() => showErrorReasonModal(deployment.err)} class={`deployment-status ${deployment.status}`}>
               <span>
                 {deployment.status}
                 {#if deployment.status === DeploymentStatus.FAILURE}
-                  <i
-                    class="ri-information-line"
-                    on:click={() => showErrorReasonModal(deployment.err)} />
+                  <i class="ri-information-line"/>
                 {/if}
               </span>
             </div>

packages/builder/src/components/settings/tabs/APIKeys.svelte

@@ -19,6 +19,7 @@
     const response = await api.put(`/api/keys/${key}`, { value })
     const res = await response.json()
     keys = { ...keys, ...res }
+    notifier.success("API Key saved.")
   }
 
   // Get Keys