Browse Source

amended code following recommendations in PR comments

master
NEOLPAR 4 years ago
parent
commit
eb9db559e0
  1. 4
      packages/builder/src/components/automation/AutomationBuilder/FlowChart/TestDataModal.svelte
  2. 2
      packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte
  3. 2
      packages/builder/src/components/automation/SetupPanel/FieldSelector.svelte

4
packages/builder/src/components/automation/AutomationBuilder/FlowChart/TestDataModal.svelte

@ -15,8 +15,6 @@
let trigger = {} let trigger = {}
let schemaProperties = {} let schemaProperties = {}
$: trigger
$: schemaProperties
$: { $: {
// clone the trigger so we're not mutating the reference // clone the trigger so we're not mutating the reference
trigger = cloneDeep( trigger = cloneDeep(
@ -27,7 +25,7 @@
let schema = Object.entries(trigger.schema?.outputs?.properties || {}) let schema = Object.entries(trigger.schema?.outputs?.properties || {})
if (trigger?.event === "app:trigger") { if (trigger?.event === "app:trigger") {
schema = Object.entries({ fields: { customType: "fields" } }) schema = [["fields", { customType: "fields" }]]
} }
schemaProperties = schema schemaProperties = schema

2
packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte

@ -53,7 +53,7 @@
$: getInputData(testData, block.inputs) $: getInputData(testData, block.inputs)
const getInputData = (testData, blockInputs) => { const getInputData = (testData, blockInputs) => {
let newInputData = testData ? testData : blockInputs let newInputData = testData || blockInputs
if (block.event === "app:trigger" && !newInputData?.fields) { if (block.event === "app:trigger" && !newInputData?.fields) {
newInputData = cloneDeep(blockInputs) newInputData = cloneDeep(blockInputs)

2
packages/builder/src/components/automation/SetupPanel/FieldSelector.svelte

@ -87,8 +87,6 @@
} }
</script> </script>
FieldSelector
{#if schemaFields.length && isTestModal} {#if schemaFields.length && isTestModal}
<div class="schema-fields"> <div class="schema-fields">
{#each schemaFields as [field, schema]} {#each schemaFields as [field, schema]}

Loading…
Cancel
Save