diff --git a/packages/builder/src/builderStore/fetchBindableProperties.js b/packages/builder/src/builderStore/fetchBindableProperties.js index 92359ae63..fbb3b1b30 100644 --- a/packages/builder/src/builderStore/fetchBindableProperties.js +++ b/packages/builder/src/builderStore/fetchBindableProperties.js @@ -90,6 +90,8 @@ const contextToBindables = (models, walkResult) => context => { runtimeBinding: `${contextParentPath}data.${key}`, // how the binding exressions looks to the user of the builder readableBinding: `${context.instance._instanceName}.${model.name}.${key}`, + // model / view info + model: context.model, }) // see ModelViewSelect.svelte for the format of context.model diff --git a/packages/builder/src/components/backend/DataTable/popovers/FilterPopover.svelte b/packages/builder/src/components/backend/DataTable/popovers/FilterPopover.svelte index 3d6241f0a..0a76ee1ef 100644 --- a/packages/builder/src/components/backend/DataTable/popovers/FilterPopover.svelte +++ b/packages/builder/src/components/backend/DataTable/popovers/FilterPopover.svelte @@ -79,7 +79,7 @@ } function fieldOptions(field) { - return viewModel.schema[field].type === "string" + return viewModel.schema[field].type === "options" ? viewModel.schema[field].constraints.inclusion : [true, false] } diff --git a/packages/builder/src/components/userInterface/NewScreenModal.svelte b/packages/builder/src/components/userInterface/NewScreenModal.svelte index 0a9bc8198..0fb31edcd 100644 --- a/packages/builder/src/components/userInterface/NewScreenModal.svelte +++ b/packages/builder/src/components/userInterface/NewScreenModal.svelte @@ -3,6 +3,7 @@ import { Input, Button, Spacer, Select, ModalContent } from "@budibase/bbui" import getTemplates from "builderStore/store/screenTemplates" import { some } from "lodash/fp" + import analytics from "analytics" const CONTAINER = "@budibase/standard-components/container" @@ -29,7 +30,7 @@ const templateChanged = newTemplateIndex => { if (newTemplateIndex === undefined) return - + const template = templates[newTemplateIndex] draftScreen = templates[newTemplateIndex].create() if (draftScreen.props._instanceName) { name = draftScreen.props._instanceName @@ -63,6 +64,13 @@ store.createScreen(draftScreen) + if (templateIndex !== undefined) { + const template = templates[templateIndex] + analytics.captureEvent("Screen Created", { + template: template.id || template.name, + }) + } + finished() } diff --git a/packages/builder/src/components/userInterface/ScreenSelect.svelte b/packages/builder/src/components/userInterface/ScreenSelect.svelte index 412f0719f..8bc22e95a 100644 --- a/packages/builder/src/components/userInterface/ScreenSelect.svelte +++ b/packages/builder/src/components/userInterface/ScreenSelect.svelte @@ -1,18 +1,75 @@ + {#each urls as url} + {/each} diff --git a/packages/builder/src/components/userInterface/pagesParsing/createProps.js b/packages/builder/src/components/userInterface/pagesParsing/createProps.js index 44d23c5c3..b628b6e15 100644 --- a/packages/builder/src/components/userInterface/pagesParsing/createProps.js +++ b/packages/builder/src/components/userInterface/pagesParsing/createProps.js @@ -1,4 +1,4 @@ -import { isString, isUndefined } from "lodash/fp" +import { isString, isUndefined, cloneDeep } from "lodash/fp" import { TYPE_MAP } from "./types" import { assign } from "lodash" import { uuid } from "builderStore/uuid" @@ -83,13 +83,13 @@ const parsePropDef = propDef => { if (isString(propDef)) { if (!TYPE_MAP[propDef]) return error(`Type ${propDef} is not recognised.`) - return TYPE_MAP[propDef].default + return cloneDeep(TYPE_MAP[propDef].default) } const type = TYPE_MAP[propDef.type] if (!type) return error(`Type ${propDef.type} is not recognised.`) - return propDef.default + return cloneDeep(propDef.default) } export const arrayElementComponentName = (parentComponentName, arrayPropName) => diff --git a/packages/builder/src/components/userInterface/pagesParsing/types.js b/packages/builder/src/components/userInterface/pagesParsing/types.js index b5f073e68..b8867cc8d 100644 --- a/packages/builder/src/components/userInterface/pagesParsing/types.js +++ b/packages/builder/src/components/userInterface/pagesParsing/types.js @@ -10,7 +10,6 @@ export const TYPE_MAP = { }, options: { default: [], - options: [], }, event: { default: [], diff --git a/packages/builder/src/components/userInterface/temporaryPanelStructure.js b/packages/builder/src/components/userInterface/temporaryPanelStructure.js index 3f853efcf..b628e86e2 100644 --- a/packages/builder/src/components/userInterface/temporaryPanelStructure.js +++ b/packages/builder/src/components/userInterface/temporaryPanelStructure.js @@ -356,7 +356,7 @@ export default { { label: "destinationUrl", key: "destinationUrl", - control: Input, + control: ScreenSelect, placeholder: "/table/_id", }, ], @@ -405,7 +405,7 @@ export default { { label: "Link Url", key: "linkUrl", - control: Input, + control: ScreenSelect, placeholder: "Link URL", }, { @@ -480,7 +480,7 @@ export default { { label: "Link Url", key: "linkUrl", - control: Input, + control: ScreenSelect, placeholder: "Link URL", }, { diff --git a/packages/builder/src/constants/backend/index.js b/packages/builder/src/constants/backend/index.js index 55a2d2c6c..a735e4b86 100644 --- a/packages/builder/src/constants/backend/index.js +++ b/packages/builder/src/constants/backend/index.js @@ -15,7 +15,7 @@ export const FIELDS = { type: "options", constraints: { type: "string", - presence: { allowEmpty: true }, + presence: false, inclusion: [], }, }, @@ -67,7 +67,7 @@ export const FIELDS = { type: "link", constraints: { type: "array", - presence: { allowEmpty: true }, + presence: false, }, }, }