Fix remaining broken tests

src/Numerics.Tests/LinearAlgebraTests/Complex/DenseMatrixTests.cs

@@ -166,8 +166,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Complex
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => DenseMatrix.CreateIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());

src/Numerics.Tests/LinearAlgebraTests/Complex/DiagonalMatrixTests.cs

@@ -177,8 +177,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Complex
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => DiagonalMatrix.CreateIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());

src/Numerics.Tests/LinearAlgebraTests/Complex/MatrixTests.Arithmetic.cs

@@ -1047,7 +1047,7 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Complex
         /// Create random matrix with non-positive number of rows throw <c>ArgumentException</c>.
         /// </summary>
         /// <param name="numberOfRows">Number of rows.</param>
-        [TestCase(0)]
+        [TestCase(-1)]
         [TestCase(-2)]
         public void RandomWithNonPositiveNumberOfRowsThrowsArgumentException(int numberOfRows)
         {

src/Numerics.Tests/LinearAlgebraTests/Complex/SparseMatrixTests.cs

@@ -151,8 +151,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Complex
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => SparseMatrix.CreateIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());

src/Numerics.Tests/LinearAlgebraTests/Complex32/DenseMatrixTests.cs

@@ -166,8 +166,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Complex32
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => DenseMatrix.CreateIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());

src/Numerics.Tests/LinearAlgebraTests/Complex32/DiagonalMatrixTests.cs

@@ -177,8 +177,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Complex32
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => DiagonalMatrix.CreateIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());

src/Numerics.Tests/LinearAlgebraTests/Complex32/MatrixTests.Arithmetic.cs

@@ -1044,7 +1044,7 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Complex32
         /// Create random matrix with non-positive number of rows throw <c>ArgumentException</c>.
         /// </summary>
         /// <param name="numberOfRows">Number of rows.</param>
-        [TestCase(0)]
+        [TestCase(-1)]
         [TestCase(-2)]
         public void RandomWithNonPositiveNumberOfRowsThrowsArgumentException(int numberOfRows)
         {

src/Numerics.Tests/LinearAlgebraTests/Complex32/SparseMatrixTests.cs

@@ -151,8 +151,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Complex32
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => SparseMatrix.CreateIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());

src/Numerics.Tests/LinearAlgebraTests/Double/DenseMatrixTests.cs

@@ -167,8 +167,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Double
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => Matrix<double>.Build.DenseIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());

src/Numerics.Tests/LinearAlgebraTests/Double/DiagonalMatrixTests.cs

@@ -176,8 +176,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Double
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => Matrix<double>.Build.DiagonalIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());

src/Numerics.Tests/LinearAlgebraTests/Double/MatrixTests.Arithmetic.cs

@@ -1037,7 +1037,7 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Double
         /// Create random matrix with non-positive number of rows throw <c>ArgumentException</c>.
         /// </summary>
         /// <param name="numberOfRows">Number of rows.</param>
-        [TestCase(0)]
+        [TestCase(-1)]
         [TestCase(-2)]
         public void RandomWithNonPositiveNumberOfRowsThrowsArgumentException(int numberOfRows)
         {

src/Numerics.Tests/LinearAlgebraTests/Double/SparseMatrixTests.cs

@@ -150,8 +150,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Double
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => Matrix<double>.Build.SparseIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());

src/Numerics.Tests/LinearAlgebraTests/MatrixStructureTheory.Access.cs

@@ -126,7 +126,6 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests
             Assert.That(() => matrix.Row(-1, 0, 2), Throws.InstanceOf<ArgumentOutOfRangeException>());
             Assert.That(() => matrix.Row(matrix.RowCount, 0, 1), Throws.InstanceOf<ArgumentOutOfRangeException>());
             Assert.That(() => matrix.Row(0, -1, 1), Throws.InstanceOf<ArgumentOutOfRangeException>());
-            Assert.That(() => matrix.Row(0, 1, 0), Throws.InstanceOf<ArgumentOutOfRangeException>());
             Assert.That(() => matrix.Row(0, 0, matrix.ColumnCount + 1), Throws.InstanceOf<ArgumentOutOfRangeException>());
         }
 
@@ -226,7 +225,6 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests
             Assert.That(() => matrix.Column(-1, 0, 2), Throws.InstanceOf<ArgumentOutOfRangeException>());
             Assert.That(() => matrix.Column(matrix.ColumnCount, 0, 1), Throws.InstanceOf<ArgumentOutOfRangeException>());
             Assert.That(() => matrix.Column(0, -1, 1), Throws.InstanceOf<ArgumentOutOfRangeException>());
-            Assert.That(() => matrix.Column(0, 1, 0), Throws.InstanceOf<ArgumentOutOfRangeException>());
             Assert.That(() => matrix.Column(0, 0, matrix.RowCount + 1), Throws.InstanceOf<ArgumentOutOfRangeException>());
         }
 
@@ -667,10 +665,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests
             // Invalid
             Assert.That(() => matrix.SubMatrix(-1, 1, 0, 1), Throws.InstanceOf<ArgumentOutOfRangeException>());
             Assert.That(() => matrix.SubMatrix(matrix.RowCount, 1, 0, 1), Throws.InstanceOf<ArgumentOutOfRangeException>());
-            Assert.That(() => matrix.SubMatrix(0, 0, 0, 1), Throws.InstanceOf<ArgumentOutOfRangeException>());
             Assert.That(() => matrix.SubMatrix(0, 1, -1, 1), Throws.InstanceOf<ArgumentOutOfRangeException>());
             Assert.That(() => matrix.SubMatrix(0, 1, matrix.ColumnCount, 1), Throws.InstanceOf<ArgumentOutOfRangeException>());
-            Assert.That(() => matrix.SubMatrix(0, 1, 0, 0), Throws.InstanceOf<ArgumentOutOfRangeException>());
         }
 
         [Theory]

src/Numerics.Tests/LinearAlgebraTests/MatrixStructureTheory.cs

@@ -141,7 +141,7 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests
             Assert.That(clone.RowCount, Is.EqualTo(matrix.RowCount));
             Assert.That(clone.ColumnCount, Is.EqualTo(matrix.ColumnCount));
         }
-        
+
         [Theory]
         public void CanCloneUsingICloneable(TestMatrix testMatrix)
         {
@@ -415,8 +415,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests
             Assert.That(empty, Is.EqualTo(Matrix<T>.Build.Dense(5, 6)));
             Assert.That(empty.Storage.IsDense, Is.EqualTo(matrix.Storage.IsDense));
 
-            Assert.That(() => Matrix<T>.Build.SameAs(matrix, 0, 2), Throws.InstanceOf<ArgumentOutOfRangeException>());
-            Assert.That(() => Matrix<T>.Build.SameAs(matrix, 2, 0), Throws.InstanceOf<ArgumentOutOfRangeException>());
+            Assert.That(() => Matrix<T>.Build.SameAs(matrix, -1, 2), Throws.InstanceOf<ArgumentOutOfRangeException>());
+            Assert.That(() => Matrix<T>.Build.SameAs(matrix, 2, -1), Throws.InstanceOf<ArgumentOutOfRangeException>());
             Assert.That(() => Matrix<T>.Build.SameAs(matrix, -1, -1), Throws.InstanceOf<ArgumentOutOfRangeException>());
         }
 

src/Numerics.Tests/LinearAlgebraTests/Single/DenseMatrixTests.cs

@@ -164,8 +164,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Single
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => DenseMatrix.CreateIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());

src/Numerics.Tests/LinearAlgebraTests/Single/DiagonalMatrixTests.cs

@@ -174,8 +174,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Single
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => DiagonalMatrix.CreateIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());

src/Numerics.Tests/LinearAlgebraTests/Single/MatrixTests.Arithmetic.cs

@@ -1032,7 +1032,7 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Single
         /// Create random matrix with non-positive number of rows throw <c>ArgumentException</c>.
         /// </summary>
         /// <param name="numberOfRows">Number of rows.</param>
-        [TestCase(0)]
+        [TestCase(-1)]
         [TestCase(-2)]
         public void RandomWithNonPositiveNumberOfRowsThrowsArgumentException(int numberOfRows)
         {

src/Numerics.Tests/LinearAlgebraTests/Single/SparseMatrixTests.cs

@@ -149,8 +149,8 @@ namespace MathNet.Numerics.UnitTests.LinearAlgebraTests.Single
         /// Identity with wrong order throws <c>ArgumentOutOfRangeException</c>.
         /// </summary>
         /// <param name="order">The size of the square matrix</param>
-        [TestCase(0)]
         [TestCase(-1)]
+        [TestCase(-2)]
         public void IdentityWithWrongOrderThrowsArgumentOutOfRangeException(int order)
         {
             Assert.That(() => SparseMatrix.CreateIdentity(order), Throws.TypeOf<ArgumentOutOfRangeException>());