From 5b1fd6fe6295d849d375d3e783f58e597053fbd8 Mon Sep 17 00:00:00 2001 From: jnyrup Date: Sat, 20 Jan 2018 09:03:11 +0100 Subject: [PATCH] Argument checks --- src/Numerics/Distance.cs | 4 ++-- src/Numerics/Optimization/NelderMeadSimplex.cs | 2 +- .../LinearAlgebra/ManagedLinearAlgebraProvider.Complex.cs | 5 ----- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/Numerics/Distance.cs b/src/Numerics/Distance.cs index be3ca36a..d940c467 100644 --- a/src/Numerics/Distance.cs +++ b/src/Numerics/Distance.cs @@ -427,7 +427,7 @@ namespace MathNet.Numerics throw new ArgumentException(Resources.ArgumentVectorsSameLength); } - if ((a.Length == 0 && b.Length == 0) || (a == null && b == null)) + if (a.Length == 0 && b.Length == 0) { return 0; } @@ -473,7 +473,7 @@ namespace MathNet.Numerics throw new ArgumentException(Resources.ArgumentVectorsSameLength); } - if ((a.Length == 0 && b.Length == 0) || (a == null && b == null)) + if (a.Length == 0 && b.Length == 0) { return 0; } diff --git a/src/Numerics/Optimization/NelderMeadSimplex.cs b/src/Numerics/Optimization/NelderMeadSimplex.cs index 2aebb9dc..088f3d82 100644 --- a/src/Numerics/Optimization/NelderMeadSimplex.cs +++ b/src/Numerics/Optimization/NelderMeadSimplex.cs @@ -113,7 +113,7 @@ namespace MathNet.Numerics.Optimization if (initialGuess == null) throw new ArgumentNullException("initialGuess", "initialGuess must be initialized"); - if (initialGuess == null) + if (initalPertubation == null) throw new ArgumentNullException("initalPertubation", "initalPertubation must be initialized, if unknown use overloaded version of FindMinimum()"); SimplexConstant[] simplexConstants = SimplexConstant.CreateSimplexConstantsFromVectors(initialGuess,initalPertubation); diff --git a/src/Numerics/Providers/LinearAlgebra/ManagedLinearAlgebraProvider.Complex.cs b/src/Numerics/Providers/LinearAlgebra/ManagedLinearAlgebraProvider.Complex.cs index 997f4db2..fa7649df 100644 --- a/src/Numerics/Providers/LinearAlgebra/ManagedLinearAlgebraProvider.Complex.cs +++ b/src/Numerics/Providers/LinearAlgebra/ManagedLinearAlgebraProvider.Complex.cs @@ -70,11 +70,6 @@ namespace MathNet.Numerics.Providers.LinearAlgebra throw new ArgumentException(Resources.ArgumentVectorsSameLength); } - if (y.Length != x.Length) - { - throw new ArgumentException(Resources.ArgumentVectorsSameLength); - } - if (alpha.IsZero()) { y.Copy(result);