Merge pull request #940 from Budibase/bugfix/csv-charset-problem

fixes encoding issue of file to work with non-english chars
6 years ago · be9f036b40
4 changed files with 4 additions and 4 deletions
--- a/packages/builder/src/components/backend/TableNavigator/TableDataImport.svelte
+++ b/packages/builder/src/components/backend/TableNavigator/TableDataImport.svelte
@ -82,7 +82,7 @@
      files = fileArray
      validateCSV()
    })
-    reader.readAsBinaryString(fileArray[0])
+    reader.readAsText(fileArray[0])
  }

  async function omitColumn(columnName) {
--- a/packages/server/src/utilities/tests/snapshots/csvParser.spec.js.snap
+++ b/packages/server/src/utilities/tests/snapshots/csvParser.spec.js.snap
@ -5,7 +5,7 @@ Array [
  Object {
    "Address": "5 Sesame Street",
    "Age": 4324,
-    "Name": "Bert",
+    "Name": "Bertå",
  },
  Object {
    "Address": "1 World Trade Center",
--- a/packages/server/src/utilities/tests/csvParser.spec.js
+++ b/packages/server/src/utilities/tests/csvParser.spec.js
@ -89,7 +89,7 @@ describe("CSV Parser", () => {
        })
      ).toEqual([
        {
-          Name: "Bert",
+          Name: "Bertå",
        },
        {
          Name: "Ernie",
--- a/packages/server/src/utilities/tests/test.csv
+++ b/packages/server/src/utilities/tests/test.csv
@ -1,4 +1,4 @@
 "Name","Age","Address"
-"Bert","4324","5 Sesame Street"
+"Bertå","4324","5 Sesame Street"
 "Ernie","34","1 World Trade Center"
 "Big Bird","23423","44 Second Avenue"