Browse Source

Fixing issue with HBS insert, not including curlies as required. Also fixing an issue with value not always being correctly updated.

master
mike12345567 5 years ago
parent
commit
ce28aff3f9
  1. 5
      packages/builder/src/components/common/bindings/BindingPanel.svelte
  2. 5
      packages/builder/src/components/common/bindings/utils.js

5
packages/builder/src/components/common/bindings/BindingPanel.svelte

@ -51,8 +51,9 @@
}) })
$: codeMirrorHints = bindings?.map(x => `$("${x.readableBinding}")`) $: codeMirrorHints = bindings?.map(x => `$("${x.readableBinding}")`)
const updateValue = value => { const updateValue = val => {
valid = isValid(readableToRuntimeBinding(bindings, value)) valid = isValid(readableToRuntimeBinding(bindings, val))
value = val
if (valid) { if (valid) {
dispatch("change", value) dispatch("change", value)
} }

5
packages/builder/src/components/common/bindings/utils.js

@ -1,7 +1,10 @@
export function addHBSBinding(value, caretPos, binding) { export function addHBSBinding(value, caretPos, binding) {
binding = typeof binding === "string" ? binding : binding.path binding = typeof binding === "string" ? binding : binding.path
value = value == null ? "" : value value = value == null ? "" : value
if (!value.includes("{{") && !value.includes("}}")) {
const left = caretPos?.start ? value.substring(0, caretPos.start) : ""
const right = caretPos?.end ? value.substring(caretPos.end) : ""
if (!left.includes("{{") || !right.includes("}}")) {
binding = `{{ ${binding} }}` binding = `{{ ${binding} }}`
} }
if (caretPos.start) { if (caretPos.start) {

Loading…
Cancel
Save