Minor optimization how we call Array.Copy

Reasoning and motivation see dotnet/corefx#3615

src/Numerics/ArrayExtensions.cs

@@ -71,7 +71,7 @@ namespace MathNet.Numerics
         {
             Array.Copy(source, 0, dest, 0, source.Length);
         }
-        
+
         /// <summary>
         /// Copies the values from on array to another.
         /// </summary>

src/Numerics/LinearAlgebra/Complex/DiagonalMatrix.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2014 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -353,8 +353,8 @@ namespace MathNet.Numerics.LinearAlgebra.Complex
             {
                 var thisDataCopy = new Complex[diagonalResult._data.Length];
                 var otherDataCopy = new Complex[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }
@@ -406,8 +406,8 @@ namespace MathNet.Numerics.LinearAlgebra.Complex
             {
                 var thisDataCopy = new Complex[diagonalResult._data.Length];
                 var otherDataCopy = new Complex[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }
@@ -450,8 +450,8 @@ namespace MathNet.Numerics.LinearAlgebra.Complex
             {
                 var thisDataCopy = new Complex[diagonalResult._data.Length];
                 var otherDataCopy = new Complex[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 // TODO: merge/MulByConj
                 Control.LinearAlgebraProvider.ConjugateArray(otherDataCopy, otherDataCopy);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
@@ -496,8 +496,8 @@ namespace MathNet.Numerics.LinearAlgebra.Complex
             {
                 var thisDataCopy = new Complex[diagonalResult._data.Length];
                 var otherDataCopy = new Complex[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }
@@ -549,8 +549,8 @@ namespace MathNet.Numerics.LinearAlgebra.Complex
             {
                 var thisDataCopy = new Complex[diagonalResult._data.Length];
                 var otherDataCopy = new Complex[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 // TODO: merge/MulByConj
                 Control.LinearAlgebraProvider.ConjugateArray(thisDataCopy, thisDataCopy);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
@@ -746,7 +746,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex
                 throw new ArgumentException(Resources.ArgumentArraysSameLength, "source");
             }
 
-            Array.Copy(source, _data, source.Length);
+            Array.Copy(source, 0, _data, 0, source.Length);
         }
 
         /// <summary>
@@ -772,7 +772,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex
                 throw new ArgumentException(Resources.ArgumentVectorsSameLength, "source");
             }
 
-            Array.Copy(denseSource.Values, _data, denseSource.Values.Length);
+            Array.Copy(denseSource.Values, 0, _data, 0, denseSource.Values.Length);
         }
 
         /// <summary>Calculates the induced L1 norm of this matrix.</summary>

src/Numerics/LinearAlgebra/Complex/Factorization/DenseCholesky.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2013 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -112,7 +112,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex.Factorization
             }
 
             // Copy the contents of input to result.
-            Array.Copy(dinput.Values, dresult.Values, dinput.Values.Length);
+            Array.Copy(dinput.Values, 0, dresult.Values, 0, dinput.Values.Length);
 
             // Cholesky solve by overwriting result.
             var dfactor = (DenseMatrix) Factor;
@@ -149,7 +149,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex.Factorization
             }
 
             // Copy the contents of input to result.
-            Array.Copy(dinput.Values, dresult.Values, dinput.Values.Length);
+            Array.Copy(dinput.Values, 0, dresult.Values, 0, dinput.Values.Length);
 
             // Cholesky solve by overwriting result.
             var dfactor = (DenseMatrix) Factor;

src/Numerics/LinearAlgebra/Complex/Factorization/DenseLU.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2013 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -131,7 +131,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex.Factorization
             }
 
             // Copy the contents of input to result.
-            Array.Copy(dinput.Values, dresult.Values, dinput.Values.Length);
+            Array.Copy(dinput.Values, 0, dresult.Values, 0, dinput.Values.Length);
 
             // LU solve by overwriting result.
             var dfactors = (DenseMatrix) Factors;
@@ -180,7 +180,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex.Factorization
             }
 
             // Copy the contents of input to result.
-            Array.Copy(dinput.Values, dresult.Values, dinput.Values.Length);
+            Array.Copy(dinput.Values, 0, dresult.Values, 0, dinput.Values.Length);
 
             // LU solve by overwriting result.
             var dfactors = (DenseMatrix) Factors;

src/Numerics/LinearAlgebra/Complex/SparseVector.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2013 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -397,7 +397,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex
                 sparseResult._storage.Indices = new int[_storage.ValueCount];
                 Buffer.BlockCopy(_storage.Indices, 0, sparseResult._storage.Indices, 0, _storage.ValueCount*Constants.SizeOfInt);
                 sparseResult._storage.Values = new Complex[_storage.ValueCount];
-                Array.Copy(_storage.Values, sparseResult._storage.Values, _storage.ValueCount);
+                Array.Copy(_storage.Values, 0, sparseResult._storage.Values, 0, _storage.ValueCount);
             }
 
             Control.LinearAlgebraProvider.ScaleArray(-Complex.One, sparseResult._storage.Values, sparseResult._storage.Values);
@@ -418,7 +418,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex
                     sparseResult._storage.Indices = new int[_storage.ValueCount];
                     Buffer.BlockCopy(_storage.Indices, 0, sparseResult._storage.Indices, 0, _storage.ValueCount*Constants.SizeOfInt);
                     sparseResult._storage.Values = new Complex[_storage.ValueCount];
-                    Array.Copy(_storage.Values, sparseResult._storage.Values, _storage.ValueCount);
+                    Array.Copy(_storage.Values, 0, sparseResult._storage.Values, 0, _storage.ValueCount);
                 }
 
                 Control.LinearAlgebraProvider.ConjugateArray(sparseResult._storage.Values, sparseResult._storage.Values);
@@ -460,7 +460,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex
                     sparseResult._storage.Indices = new int[_storage.ValueCount];
                     Buffer.BlockCopy(_storage.Indices, 0, sparseResult._storage.Indices, 0, _storage.ValueCount * Constants.SizeOfInt);
                     sparseResult._storage.Values = new Complex[_storage.ValueCount];
-                    Array.Copy(_storage.Values, sparseResult._storage.Values, _storage.ValueCount);
+                    Array.Copy(_storage.Values, 0, sparseResult._storage.Values, 0, _storage.ValueCount);
                 }
 
                 Control.LinearAlgebraProvider.ScaleArray(scalar, sparseResult._storage.Values, sparseResult._storage.Values);

src/Numerics/LinearAlgebra/Complex32/DiagonalMatrix.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2014 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -347,8 +347,8 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32
             {
                 var thisDataCopy = new Complex32[diagonalResult._data.Length];
                 var otherDataCopy = new Complex32[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }
@@ -400,8 +400,8 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32
             {
                 var thisDataCopy = new Complex32[diagonalResult._data.Length];
                 var otherDataCopy = new Complex32[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }
@@ -444,8 +444,8 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32
             {
                 var thisDataCopy = new Complex32[diagonalResult._data.Length];
                 var otherDataCopy = new Complex32[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 // TODO: merge/MulByConj
                 Control.LinearAlgebraProvider.ConjugateArray(otherDataCopy, otherDataCopy);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
@@ -490,8 +490,8 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32
             {
                 var thisDataCopy = new Complex32[diagonalResult._data.Length];
                 var otherDataCopy = new Complex32[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }
@@ -543,8 +543,8 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32
             {
                 var thisDataCopy = new Complex32[diagonalResult._data.Length];
                 var otherDataCopy = new Complex32[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 // TODO: merge/MulByConj
                 Control.LinearAlgebraProvider.ConjugateArray(thisDataCopy, thisDataCopy);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
@@ -740,7 +740,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32
                 throw new ArgumentException(Resources.ArgumentArraysSameLength, "source");
             }
 
-            Array.Copy(source, _data, source.Length);
+            Array.Copy(source, 0, _data, 0, source.Length);
         }
 
         /// <summary>
@@ -766,7 +766,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32
                 throw new ArgumentException(Resources.ArgumentVectorsSameLength, "source");
             }
 
-            Array.Copy(denseSource.Values, _data, denseSource.Values.Length);
+            Array.Copy(denseSource.Values, 0, _data, 0, denseSource.Values.Length);
         }
 
         /// <summary>Calculates the induced L1 norm of this matrix.</summary>

src/Numerics/LinearAlgebra/Complex32/Factorization/DenseCholesky.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2013 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -107,7 +107,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32.Factorization
             }
 
             // Copy the contents of input to result.
-            Array.Copy(dinput.Values, dresult.Values, dinput.Values.Length);
+            Array.Copy(dinput.Values, 0, dresult.Values, 0, dinput.Values.Length);
 
             // Cholesky solve by overwriting result.
             var dfactor = (DenseMatrix) Factor;
@@ -144,7 +144,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32.Factorization
             }
 
             // Copy the contents of input to result.
-            Array.Copy(dinput.Values, dresult.Values, dinput.Values.Length);
+            Array.Copy(dinput.Values, 0, dresult.Values, 0, dinput.Values.Length);
 
             // Cholesky solve by overwriting result.
             var dfactor = (DenseMatrix) Factor;

src/Numerics/LinearAlgebra/Complex32/Factorization/DenseLU.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2013 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -126,7 +126,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32.Factorization
             }
 
             // Copy the contents of input to result.
-            Array.Copy(dinput.Values, dresult.Values, dinput.Values.Length);
+            Array.Copy(dinput.Values, 0, dresult.Values, 0, dinput.Values.Length);
 
             // LU solve by overwriting result.
             var dfactors = (DenseMatrix) Factors;
@@ -175,7 +175,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32.Factorization
             }
 
             // Copy the contents of input to result.
-            Array.Copy(dinput.Values, dresult.Values, dinput.Values.Length);
+            Array.Copy(dinput.Values, 0, dresult.Values, 0, dinput.Values.Length);
 
             // LU solve by overwriting result.
             var dfactors = (DenseMatrix) Factors;

src/Numerics/LinearAlgebra/Complex32/SparseVector.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2013 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -392,7 +392,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32
                 sparseResult._storage.Indices = new int[_storage.ValueCount];
                 Buffer.BlockCopy(_storage.Indices, 0, sparseResult._storage.Indices, 0, _storage.ValueCount*Constants.SizeOfInt);
                 sparseResult._storage.Values = new Complex32[_storage.ValueCount];
-                Array.Copy(_storage.Values, sparseResult._storage.Values, _storage.ValueCount);
+                Array.Copy(_storage.Values, 0, sparseResult._storage.Values, 0, _storage.ValueCount);
             }
 
             Control.LinearAlgebraProvider.ScaleArray(-Complex32.One, sparseResult._storage.Values, sparseResult._storage.Values);
@@ -413,7 +413,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32
                     sparseResult._storage.Indices = new int[_storage.ValueCount];
                     Buffer.BlockCopy(_storage.Indices, 0, sparseResult._storage.Indices, 0, _storage.ValueCount*Constants.SizeOfInt);
                     sparseResult._storage.Values = new Complex32[_storage.ValueCount];
-                    Array.Copy(_storage.Values, sparseResult._storage.Values, _storage.ValueCount);
+                    Array.Copy(_storage.Values, 0, sparseResult._storage.Values, 0, _storage.ValueCount);
                 }
 
                 Control.LinearAlgebraProvider.ConjugateArray(sparseResult._storage.Values, sparseResult._storage.Values);
@@ -455,7 +455,7 @@ namespace MathNet.Numerics.LinearAlgebra.Complex32
                     sparseResult._storage.Indices = new int[_storage.ValueCount];
                     Buffer.BlockCopy(_storage.Indices, 0, sparseResult._storage.Indices, 0, _storage.ValueCount * Constants.SizeOfInt);
                     sparseResult._storage.Values = new Complex32[_storage.ValueCount];
-                    Array.Copy(_storage.Values, sparseResult._storage.Values, _storage.ValueCount);
+                    Array.Copy(_storage.Values, 0, sparseResult._storage.Values, 0, _storage.ValueCount);
                 }
 
                 Control.LinearAlgebraProvider.ScaleArray(scalar, sparseResult._storage.Values, sparseResult._storage.Values);

src/Numerics/LinearAlgebra/Double/DiagonalMatrix.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2014 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -326,8 +326,8 @@ namespace MathNet.Numerics.LinearAlgebra.Double
             {
                 var thisDataCopy = new double[diagonalResult._data.Length];
                 var otherDataCopy = new double[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }
@@ -379,8 +379,8 @@ namespace MathNet.Numerics.LinearAlgebra.Double
             {
                 var thisDataCopy = new double[diagonalResult._data.Length];
                 var otherDataCopy = new double[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }
@@ -423,8 +423,8 @@ namespace MathNet.Numerics.LinearAlgebra.Double
             {
                 var thisDataCopy = new double[diagonalResult._data.Length];
                 var otherDataCopy = new double[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }

src/Numerics/LinearAlgebra/Double/SparseVector.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2013 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -392,7 +392,7 @@ namespace MathNet.Numerics.LinearAlgebra.Double
                 sparseResult._storage.Indices = new int[_storage.ValueCount];
                 Buffer.BlockCopy(_storage.Indices, 0, sparseResult._storage.Indices, 0, _storage.ValueCount * Constants.SizeOfInt);
                 sparseResult._storage.Values = new double[_storage.ValueCount];
-                Array.Copy(_storage.Values, sparseResult._storage.Values, _storage.ValueCount);
+                Array.Copy(_storage.Values, 0, sparseResult._storage.Values, 0, _storage.ValueCount);
             }
 
             Control.LinearAlgebraProvider.ScaleArray(-1.0d, sparseResult._storage.Values, sparseResult._storage.Values);
@@ -426,7 +426,7 @@ namespace MathNet.Numerics.LinearAlgebra.Double
                     sparseResult._storage.Indices = new int[_storage.ValueCount];
                     Buffer.BlockCopy(_storage.Indices, 0, sparseResult._storage.Indices, 0, _storage.ValueCount * Constants.SizeOfInt);
                     sparseResult._storage.Values = new double[_storage.ValueCount];
-                    Array.Copy(_storage.Values, sparseResult._storage.Values, _storage.ValueCount);
+                    Array.Copy(_storage.Values, 0, sparseResult._storage.Values, 0, _storage.ValueCount);
                 }
 
                 Control.LinearAlgebraProvider.ScaleArray(scalar, sparseResult._storage.Values, sparseResult._storage.Values);

src/Numerics/LinearAlgebra/Single/DiagonalMatrix.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2014 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -326,8 +326,8 @@ namespace MathNet.Numerics.LinearAlgebra.Single
             {
                 var thisDataCopy = new float[diagonalResult._data.Length];
                 var otherDataCopy = new float[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }
@@ -379,8 +379,8 @@ namespace MathNet.Numerics.LinearAlgebra.Single
             {
                 var thisDataCopy = new float[diagonalResult._data.Length];
                 var otherDataCopy = new float[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }
@@ -423,8 +423,8 @@ namespace MathNet.Numerics.LinearAlgebra.Single
             {
                 var thisDataCopy = new float[diagonalResult._data.Length];
                 var otherDataCopy = new float[diagonalResult._data.Length];
-                Array.Copy(_data, thisDataCopy, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
-                Array.Copy(diagonalOther._data, otherDataCopy, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
+                Array.Copy(_data, 0, thisDataCopy, 0, (diagonalResult._data.Length > _data.Length) ? _data.Length : diagonalResult._data.Length);
+                Array.Copy(diagonalOther._data, 0, otherDataCopy, 0, (diagonalResult._data.Length > diagonalOther._data.Length) ? diagonalOther._data.Length : diagonalResult._data.Length);
                 Control.LinearAlgebraProvider.PointWiseMultiplyArrays(thisDataCopy, otherDataCopy, diagonalResult._data);
                 return;
             }

src/Numerics/LinearAlgebra/Single/SparseVector.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2013 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
@@ -393,7 +393,7 @@ namespace MathNet.Numerics.LinearAlgebra.Single
                 sparseResult._storage.Indices = new int[_storage.ValueCount];
                 Buffer.BlockCopy(_storage.Indices, 0, sparseResult._storage.Indices, 0, _storage.ValueCount * Constants.SizeOfInt);
                 sparseResult._storage.Values = new float[_storage.ValueCount];
-                Array.Copy(_storage.Values, sparseResult._storage.Values, _storage.ValueCount);
+                Array.Copy(_storage.Values, 0, sparseResult._storage.Values, 0, _storage.ValueCount);
             }
 
             Control.LinearAlgebraProvider.ScaleArray(-1.0f, sparseResult._storage.Values, sparseResult._storage.Values);
@@ -427,7 +427,7 @@ namespace MathNet.Numerics.LinearAlgebra.Single
                     sparseResult._storage.Indices = new int[_storage.ValueCount];
                     Buffer.BlockCopy(_storage.Indices, 0, sparseResult._storage.Indices, 0, _storage.ValueCount * Constants.SizeOfInt);
                     sparseResult._storage.Values = new float[_storage.ValueCount];
-                    Array.Copy(_storage.Values, sparseResult._storage.Values, _storage.ValueCount);
+                    Array.Copy(_storage.Values, 0, sparseResult._storage.Values, 0, _storage.ValueCount);
                 }
 
                 Control.LinearAlgebraProvider.ScaleArray(scalar, sparseResult._storage.Values, sparseResult._storage.Values);

src/Numerics/LinearAlgebra/Storage/DenseColumnMajorMatrixStorage.cs

@@ -332,7 +332,7 @@ namespace MathNet.Numerics.LinearAlgebra.Storage
             if (arrayData != null)
             {
                 var copy = new T[arrayData.Length];
-                Array.Copy(arrayData, copy, arrayData.Length);
+                Array.Copy(arrayData, 0, copy, 0, arrayData.Length);
                 return new DenseColumnMajorMatrixStorage<T>(rows, columns, copy);
             }
 
@@ -588,7 +588,7 @@ namespace MathNet.Numerics.LinearAlgebra.Storage
         public override T[] ToColumnMajorArray()
         {
             var ret = new T[Data.Length];
-            Array.Copy(Data, ret, Data.Length);
+            Array.Copy(Data, 0, ret, 0, Data.Length);
             return ret;
         }
 

src/Numerics/LinearAlgebra/Storage/DenseVectorStorage.cs

@@ -158,7 +158,7 @@ namespace MathNet.Numerics.LinearAlgebra.Storage
             if (arrayData != null)
             {
                 var copy = new T[arrayData.Length];
-                Array.Copy(arrayData, copy, arrayData.Length);
+                Array.Copy(arrayData, 0, copy, 0, arrayData.Length);
                 return new DenseVectorStorage<T>(copy.Length, copy);
             }
 

src/Numerics/LinearAlgebra/Storage/DiagonalMatrixStorage.cs

@@ -228,7 +228,7 @@ namespace MathNet.Numerics.LinearAlgebra.Storage
             if (arrayData != null)
             {
                 var copy = new T[arrayData.Length];
-                Array.Copy(arrayData, copy, arrayData.Length);
+                Array.Copy(arrayData, 0, copy, 0, arrayData.Length);
                 return new DiagonalMatrixStorage<T>(rows, columns, copy);
             }
 

src/Numerics/LinearAlgebra/Storage/SparseCompressedRowMatrixStorage.cs

@@ -880,7 +880,7 @@ namespace MathNet.Numerics.LinearAlgebra.Storage
 
             if (ValueCount != 0)
             {
-                Array.Copy(Values, target.Values, ValueCount);
+                Array.Copy(Values, 0, target.Values, 0, ValueCount);
                 Buffer.BlockCopy(ColumnIndices, 0, target.ColumnIndices, 0, ValueCount*Constants.SizeOfInt);
                 Buffer.BlockCopy(RowPointers, 0, target.RowPointers, 0, (RowCount + 1)*Constants.SizeOfInt);
             }
@@ -2037,7 +2037,7 @@ namespace MathNet.Numerics.LinearAlgebra.Storage
         {
             if (!ReferenceEquals(state, target))
             {
-                Array.Copy(state, target, state.Length);
+                Array.Copy(state, 0, target, 0, state.Length);
             }
             if (zeros == Zeros.AllowSkip)
             {

src/Numerics/LinearAlgebra/Storage/SparseVectorStorage.cs

@@ -463,7 +463,7 @@ namespace MathNet.Numerics.LinearAlgebra.Storage
 
             if (ValueCount != 0)
             {
-                Array.Copy(Values, target.Values, ValueCount);
+                Array.Copy(Values, 0, target.Values, 0, ValueCount);
                 Buffer.BlockCopy(Indices, 0, target.Indices, 0, ValueCount * Constants.SizeOfInt);
             }
         }

src/Numerics/Providers/LinearAlgebra/ManagedLinearAlgebraProvider.Complex.cs

@@ -1794,7 +1794,7 @@ namespace MathNet.Numerics.Providers.LinearAlgebra
             var sol = new Complex[b.Length];
 
             // Copy B matrix to "sol", so B data will not be changed
-            Array.Copy(b, sol, b.Length);
+            Array.Copy(b, 0, sol, 0, b.Length);
 
             // Compute Y = transpose(Q)*B
             var column = new Complex[rowsA];
@@ -1896,7 +1896,7 @@ namespace MathNet.Numerics.Providers.LinearAlgebra
             }
 
             var work = new Complex[rowsA];
-  
+
             const int maxiter = 1000;
 
             var e = new Complex[columnsA];
@@ -2507,7 +2507,7 @@ namespace MathNet.Numerics.Providers.LinearAlgebra
             // Copy stemp to s with size adjustment. We are using ported copy of linpack's svd code and it uses
             // a singular vector of length rows+1 when rows < columns. The last element is not used and needs to be removed.
             // We should port lapack's svd routine to remove this problem.
-            Array.Copy(stemp, s, Math.Min(rowsA, columnsA));
+            Array.Copy(stemp, 0, s, 0, Math.Min(rowsA, columnsA));
         }
 
         /// <summary>
@@ -2704,7 +2704,7 @@ namespace MathNet.Numerics.Providers.LinearAlgebra
                 throw new ArgumentException(String.Format(Resources.ArgumentArrayWrongLength, order*order), "matrixD");
             }
             var matrixCopy = new Complex[matrix.Length];
-            Array.Copy(matrix, matrixCopy, matrix.Length);
+            Array.Copy(matrix, 0, matrixCopy, 0, matrix.Length);
 
             if (isSymmetric)
             {

src/Numerics/Providers/LinearAlgebra/ManagedLinearAlgebraProvider.Complex32.cs

@@ -1499,7 +1499,7 @@ namespace MathNet.Numerics.Providers.LinearAlgebra
             }
 
             var work = new Complex32[rowsA*columnsA];
- 
+
             var minmn = Math.Min(rowsA, columnsA);
             for (var i = 0; i < minmn; i++)
             {
@@ -1789,7 +1789,7 @@ namespace MathNet.Numerics.Providers.LinearAlgebra
             var sol = new Complex32[b.Length];
 
             // Copy B matrix to "sol", so B data will not be changed
-            Array.Copy(b, sol, b.Length);
+            Array.Copy(b, 0, sol, 0, b.Length);
 
             // Compute Y = transpose(Q)*B
             var column = new Complex32[rowsA];
@@ -1891,7 +1891,7 @@ namespace MathNet.Numerics.Providers.LinearAlgebra
             }
 
             var work = new Complex32[rowsA];
- 
+
             const int maxiter = 1000;
 
             var e = new Complex32[columnsA];
@@ -2502,7 +2502,7 @@ namespace MathNet.Numerics.Providers.LinearAlgebra
             // Copy stemp to s with size adjustment. We are using ported copy of linpack's svd code and it uses
             // a singular vector of length rows+1 when rows < columns. The last element is not used and needs to be removed.
             // We should port lapack's svd routine to remove this problem.
-            Array.Copy(stemp, s, Math.Min(rowsA, columnsA));
+            Array.Copy(stemp, 0, s, 0, Math.Min(rowsA, columnsA));
         }
 
         /// <summary>
@@ -2700,7 +2700,7 @@ namespace MathNet.Numerics.Providers.LinearAlgebra
             }
 
             var matrixCopy = new Complex32[matrix.Length];
-            Array.Copy(matrix, matrixCopy, matrix.Length);
+            Array.Copy(matrix, 0, matrixCopy, 0, matrix.Length);
             var v = new DenseVector(order);
             if (isSymmetric)
             {

src/Numerics/RootFinding/Broyden.cs

@@ -3,9 +3,9 @@
 // http://numerics.mathdotnet.com
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
-// 
+//
 // Copyright (c) 2009-2013 Math.NET
-// 
+//
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
 // files (the "Software"), to deal in the Software without
@@ -14,10 +14,10 @@
 // copies of the Software, and to permit persons to whom the
 // Software is furnished to do so, subject to the following
 // conditions:
-// 
+//
 // The above copyright notice and this permission notice shall be
 // included in all copies or substantial portions of the Software.
-// 
+//
 // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 // EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
 // OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
@@ -130,7 +130,7 @@ namespace MathNet.Numerics.RootFinding
             var B = new DenseMatrix(dim);
 
             var x = new double[dim];
-            Array.Copy(x0, x, dim);
+            Array.Copy(x0, 0, x, 0, dim);
 
             for (int j = 0; j < dim; j++)
             {

src/Numerics/Statistics/ArrayStatistics.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2014 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation

src/Numerics/Statistics/MCMC/HybridMC.cs

@@ -203,7 +203,7 @@ namespace MathNet.Numerics.Statistics.Mcmc
         protected override double[] Copy(double[] source)
         {
             var destination = new double[_length];
-            Array.Copy(source, destination, _length);
+            Array.Copy(source, 0, destination, 0, _length);
             return destination;
         }
 
@@ -270,8 +270,8 @@ namespace MathNet.Numerics.Statistics.Mcmc
             var increment = new double[length];
             var decrement = new double[length];
 
-            Array.Copy(x, increment, length);
-            Array.Copy(x, decrement, length);
+            Array.Copy(x, 0, increment, 0, length);
+            Array.Copy(x, 0, decrement, 0, length);
 
             for (int i = 0; i < length; i++)
             {

src/Numerics/Statistics/Statistics.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2014 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation

src/Numerics/Statistics/StreamingStatistics.cs

@@ -4,7 +4,7 @@
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
 //
-// Copyright (c) 2009-2014 Math.NET
+// Copyright (c) 2009-2015 Math.NET
 //
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation

src/UnitTests/LinearAlgebraProviderTests/Complex/LinearAlgebraProviderTests.cs

@@ -3,9 +3,9 @@
 // http://numerics.mathdotnet.com
 // http://github.com/mathnet/mathnet-numerics
 // http://mathnetnumerics.codeplex.com
-// 
+//
 // Copyright (c) 2009-2015 Math.NET
-// 
+//
 // Permission is hereby granted, free of charge, to any person
 // obtaining a copy of this software and associated documentation
 // files (the "Software"), to deal in the Software without
@@ -14,10 +14,10 @@
 // copies of the Software, and to permit persons to whom the
 // Software is furnished to do so, subject to the following
 // conditions:
-// 
+//
 // The above copyright notice and this permission notice shall be
 // included in all copies or substantial portions of the Software.
-// 
+//
 // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 // EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
 // OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND