From a302612eb9ecb40c4fd91d710876549511118331 Mon Sep 17 00:00:00 2001 From: Ryan Nowak Date: Sat, 25 Apr 2020 11:53:21 -0700 Subject: [PATCH] Remove namespace from this step (dead code) --- src/Microsoft.Tye.Core/GenerateKubernetesManifestStep.cs | 3 --- src/tye/GenerateHost.cs | 4 ++-- src/tye/Program.DeployCommand.cs | 2 +- src/tye/Program.PushCommand.cs | 2 +- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/Microsoft.Tye.Core/GenerateKubernetesManifestStep.cs b/src/Microsoft.Tye.Core/GenerateKubernetesManifestStep.cs index b49c307d..94eb5302 100644 --- a/src/Microsoft.Tye.Core/GenerateKubernetesManifestStep.cs +++ b/src/Microsoft.Tye.Core/GenerateKubernetesManifestStep.cs @@ -12,9 +12,6 @@ namespace Microsoft.Tye public string Environment { get; set; } = "production"; - public string? Namespace { get; set; } = null; - - public override Task ExecuteAsync(OutputContext output, ApplicationBuilder application, ServiceBuilder service) { if (SkipWithoutContainerOutput(output, service)) diff --git a/src/tye/GenerateHost.cs b/src/tye/GenerateHost.cs index 32726c62..b758ba0d 100644 --- a/src/tye/GenerateHost.cs +++ b/src/tye/GenerateHost.cs @@ -37,7 +37,7 @@ namespace Microsoft.Tye var executor = new ApplicationExecutor(output) { - ServiceSteps = + ServiceSteps = { new CombineStep() { Environment = environment, }, new PublishProjectStep(), @@ -46,7 +46,7 @@ namespace Microsoft.Tye }, }; await executor.ExecuteAsync(application); - + await GenerateApplicationManifestAsync(output, application, environment); } diff --git a/src/tye/Program.DeployCommand.cs b/src/tye/Program.DeployCommand.cs index c49f45ff..93c96034 100644 --- a/src/tye/Program.DeployCommand.cs +++ b/src/tye/Program.DeployCommand.cs @@ -81,7 +81,7 @@ namespace Microsoft.Tye new BuildDockerImageStep() { Environment = environment, }, new PushDockerImageStep() { Environment = environment, }, new ValidateSecretStep() { Environment = environment, Interactive = interactive, Force = force, }, - new GenerateKubernetesManifestStep() { Environment = environment, Namespace = application.Namespace }, + new GenerateKubernetesManifestStep() { Environment = environment, }, new DeployServiceYamlStep() { Environment = environment, }, } }; diff --git a/src/tye/Program.PushCommand.cs b/src/tye/Program.PushCommand.cs index d296d7f0..ab9b71b9 100644 --- a/src/tye/Program.PushCommand.cs +++ b/src/tye/Program.PushCommand.cs @@ -56,7 +56,7 @@ namespace Microsoft.Tye var executor = new ApplicationExecutor(output) { - ServiceSteps = + ServiceSteps = { new CombineStep() { Environment = environment, }, new PublishProjectStep(),