From a9a1b83653d8a06a9a7b805a319ef911111c86c1 Mon Sep 17 00:00:00 2001 From: Phillip Hoff Date: Wed, 1 Dec 2021 14:08:01 -0800 Subject: [PATCH] Generally kill both parent and their child processes. (#1232) --- src/Microsoft.Tye.Core/ProcessExtensions.cs | 2 +- src/Microsoft.Tye.Core/ProcessUtil.cs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Microsoft.Tye.Core/ProcessExtensions.cs b/src/Microsoft.Tye.Core/ProcessExtensions.cs index cd7826a6..0c75938e 100644 --- a/src/Microsoft.Tye.Core/ProcessExtensions.cs +++ b/src/Microsoft.Tye.Core/ProcessExtensions.cs @@ -117,7 +117,7 @@ namespace Microsoft.Tye } else { - process?.Kill(); + process?.Kill(entireProcessTree: true); } } } diff --git a/src/Microsoft.Tye.Core/ProcessUtil.cs b/src/Microsoft.Tye.Core/ProcessUtil.cs index c89c4943..3df6303d 100644 --- a/src/Microsoft.Tye.Core/ProcessUtil.cs +++ b/src/Microsoft.Tye.Core/ProcessUtil.cs @@ -165,7 +165,7 @@ namespace Microsoft.Tye { if (!process.CloseMainWindow()) { - process.Kill(); + process.Kill(entireProcessTree: true); } } @@ -177,7 +177,7 @@ namespace Microsoft.Tye if (!process.HasExited) { - process.Kill(); + process.Kill(entireProcessTree: true); } } } @@ -197,7 +197,7 @@ namespace Microsoft.Tye try { using var process = Process.GetProcessById(pid); - process?.Kill(); + process?.Kill(entireProcessTree: true); } catch (ArgumentException) { } catch (InvalidOperationException) { }