Browse Source

do dispose async

davidfowl/dependencies
SimonCropp 7 years ago
committed by Ryan Nowak
parent
commit
5100f910bf
  1. 4
      src/Microsoft.Tye.Core/DeployServiceYamlStep.cs
  2. 4
      src/Microsoft.Tye.Core/DockerfileGenerator.cs
  3. 2
      src/Microsoft.Tye.Core/ProcessUtil.cs
  4. 4
      src/Microsoft.Tye.Core/ValidateSecretStep.cs
  5. 2
      src/Microsoft.Tye.Hosting/Infrastructure/ProxyExtensions.cs
  6. 4
      src/tye/GenerateHost.cs
  7. 4
      src/tye/Program.DeployCommand.cs

4
src/Microsoft.Tye.Core/DeployServiceYamlStep.cs

@ -40,8 +40,8 @@ namespace Microsoft.Tye
output.WriteDebugLine($"Writing output to '{tempFile.FilePath}'.");
{
using var stream = File.OpenWrite(tempFile.FilePath);
using var writer = new StreamWriter(stream, Encoding.UTF8, bufferSize: -1, leaveOpen: true);
await using var stream = File.OpenWrite(tempFile.FilePath);
await using var writer = new StreamWriter(stream, Encoding.UTF8, bufferSize: -1, leaveOpen: true);
var yamlStream = new YamlStream(yaml.Select(y => y.Yaml));
yamlStream.Save(writer, assignAnchors: false);
}

4
src/Microsoft.Tye.Core/DockerfileGenerator.cs

@ -39,8 +39,8 @@ namespace Microsoft.Tye
throw new ArgumentNullException(nameof(filePath));
}
using var stream = File.OpenWrite(filePath);
using var writer = new StreamWriter(stream, encoding: Encoding.UTF8, bufferSize: -1, leaveOpen: true);
await using var stream = File.OpenWrite(filePath);
await using var writer = new StreamWriter(stream, encoding: Encoding.UTF8, bufferSize: -1, leaveOpen: true);
var entryPoint = Path.GetFileNameWithoutExtension(project.ProjectFile.Name);
output.WriteDebugLine($"Writing Dockerfile to '{filePath}'.");

2
src/Microsoft.Tye.Core/ProcessUtil.cs

@ -109,7 +109,7 @@ namespace Microsoft.Tye
process.BeginErrorReadLine();
var cancelledTcs = new TaskCompletionSource<object?>();
using var _ = cancellationToken.Register(() => cancelledTcs.TrySetResult(null));
await using var _ = cancellationToken.Register(() => cancelledTcs.TrySetResult(null));
var result = await Task.WhenAny(processLifetimeTask.Task, cancelledTcs.Task);

4
src/Microsoft.Tye.Core/ValidateSecretStep.cs

@ -136,8 +136,8 @@ namespace Microsoft.Tye
output.WriteDebugLine($"Writing output to '{tempFile.FilePath}'.");
{
using var stream = File.OpenWrite(tempFile.FilePath);
using var writer = new StreamWriter(stream, Encoding.UTF8, bufferSize: -1, leaveOpen: true);
await using var stream = File.OpenWrite(tempFile.FilePath);
await using var writer = new StreamWriter(stream, Encoding.UTF8, bufferSize: -1, leaveOpen: true);
var yamlStream = new YamlStream(yaml.Select(y => y.Yaml));
yamlStream.Save(writer, assignAnchors: false);
}

2
src/Microsoft.Tye.Hosting/Infrastructure/ProxyExtensions.cs

@ -204,7 +204,7 @@ namespace Microsoft.AspNetCore.Proxy
// SendAsync removes chunking from the response. This removes the header so it doesn't expect a chunked response.
response.Headers.Remove("transfer-encoding");
using (var responseStream = await responseMessage.Content.ReadAsStreamAsync())
await using (var responseStream = await responseMessage.Content.ReadAsStreamAsync())
{
await responseStream.CopyToAsync(response.Body, StreamCopyBufferSize, context.RequestAborted);
}

4
src/tye/GenerateHost.cs

@ -50,8 +50,8 @@ namespace Microsoft.Tye
{
File.Delete(outputFilePath);
using var stream = File.OpenWrite(outputFilePath);
using var writer = new StreamWriter(stream, Encoding.UTF8, leaveOpen: true);
await using var stream = File.OpenWrite(outputFilePath);
await using var writer = new StreamWriter(stream, Encoding.UTF8, leaveOpen: true);
await ApplicationYamlWriter.WriteAsync(output, writer, application);
}

4
src/tye/Program.DeployCommand.cs

@ -94,8 +94,8 @@ namespace Microsoft.Tye
output.WriteInfoLine($"Writing output to '{tempFile.FilePath}'.");
{
using var stream = File.OpenWrite(tempFile.FilePath);
using var writer = new StreamWriter(stream, Encoding.UTF8, leaveOpen: true);
await using var stream = File.OpenWrite(tempFile.FilePath);
await using var writer = new StreamWriter(stream, Encoding.UTF8, leaveOpen: true);
await ApplicationYamlWriter.WriteAsync(output, writer, application);
}

Loading…
Cancel
Save