Browse Source

Rename ContextMenu Opening/Closing events removing type prefix

pull/11549/head
robloo 3 years ago
parent
commit
04c88b09fb
  1. 4
      samples/ControlCatalog/Pages/ContextMenuPage.xaml.cs
  2. 8
      src/Avalonia.Controls/ContextMenu.cs
  3. 6
      tests/Avalonia.Controls.UnitTests/ContextMenuTests.cs

4
samples/ControlCatalog/Pages/ContextMenuPage.xaml.cs

@ -19,8 +19,8 @@ namespace ControlCatalog.Pages
customContextRequestedBorder.AddHandler(ContextRequestedEvent, CustomContextRequested, RoutingStrategies.Tunnel);
var cancellableContextBorder = this.Get<Border>("CancellableContextBorder");
cancellableContextBorder.ContextMenu!.ContextMenuClosing += ContextFlyoutPage_Closing;
cancellableContextBorder.ContextMenu!.ContextMenuOpening += ContextFlyoutPage_Opening;
cancellableContextBorder.ContextMenu!.Closing += ContextFlyoutPage_Closing;
cancellableContextBorder.ContextMenu!.Opening += ContextFlyoutPage_Opening;
}
private ContextPageViewModel? _model;

8
src/Avalonia.Controls/ContextMenu.cs

@ -196,14 +196,14 @@ namespace Avalonia.Controls
/// <see cref="P:Avalonia.Controls.ContextMenu.IsOpen" />
/// property is changing from false to true.
/// </summary>
public event CancelEventHandler? ContextMenuOpening;
public event CancelEventHandler? Opening;
/// <summary>
/// Occurs when the value of the
/// <see cref="P:Avalonia.Controls.ContextMenu.IsOpen" />
/// property is changing from true to false.
/// </summary>
public event CancelEventHandler? ContextMenuClosing;
public event CancelEventHandler? Closing;
/// <summary>
/// Called when the <see cref="Control.ContextMenu"/> property changes on a control.
@ -446,14 +446,14 @@ namespace Avalonia.Controls
private bool CancelClosing()
{
var eventArgs = new CancelEventArgs();
ContextMenuClosing?.Invoke(this, eventArgs);
Closing?.Invoke(this, eventArgs);
return eventArgs.Cancel;
}
private bool CancelOpening()
{
var eventArgs = new CancelEventArgs();
ContextMenuOpening?.Invoke(this, eventArgs);
Opening?.Invoke(this, eventArgs);
return eventArgs.Cancel;
}
}

6
tests/Avalonia.Controls.UnitTests/ContextMenuTests.cs

@ -258,7 +258,7 @@ namespace Avalonia.Controls.UnitTests
var tracker = 0;
var c = new ContextMenu();
c.ContextMenuClosing += (s, e) =>
c.Closing += (s, e) =>
{
tracker++;
e.Cancel = true;
@ -430,7 +430,7 @@ namespace Avalonia.Controls.UnitTests
};
new Window { Content = target };
sut.ContextMenuOpening += (c, e) => { eventCalled = true; e.Cancel = true; };
sut.Opening += (c, e) => { eventCalled = true; e.Cancel = true; };
_mouse.Click(target, MouseButton.Right);
@ -574,7 +574,7 @@ namespace Avalonia.Controls.UnitTests
var window = PreparedWindow(target);
var overlay = LightDismissOverlayLayer.GetLightDismissOverlayLayer(window);
sut.ContextMenuClosing += (c, e) => { eventCalled = true; e.Cancel = true; };
sut.Closing += (c, e) => { eventCalled = true; e.Cancel = true; };
window.Show();

Loading…
Cancel
Save