Merge pull request #8860 from AvaloniaUI/remove-public-constructors-from-eventargs-from-avalonia.base

Remove public constructors for KeyEventArgs, PointerEventArgs and friends

src/Avalonia.Base/Controls/NameScopeEventArgs.cs

@@ -1,16 +0,0 @@
-using System;
-
-namespace Avalonia.Controls
-{
-    public class NameScopeEventArgs : EventArgs
-    {
-        public NameScopeEventArgs(string name, object element)
-        {
-            Name = name;
-            Element = element;
-        }
-
-        public string Name { get; }
-        public object Element { get; }
-    }
-}

src/Avalonia.Base/Input/DragEventArgs.cs

@@ -32,7 +32,7 @@ namespace Avalonia.Input
             return point;
         }
 
-        public DragEventArgs(RoutedEvent<DragEventArgs> routedEvent, IDataObject data, Interactive target, Point targetLocation, KeyModifiers keyModifiers)
+        internal DragEventArgs(RoutedEvent<DragEventArgs> routedEvent, IDataObject data, Interactive target, Point targetLocation, KeyModifiers keyModifiers)
             : base(routedEvent)
         {
             Data = data;

src/Avalonia.Base/Input/GotFocusEventArgs.cs

@@ -7,6 +7,11 @@ namespace Avalonia.Input
     /// </summary>
     public class GotFocusEventArgs : RoutedEventArgs
     {
+        internal GotFocusEventArgs()
+        {
+
+        }
+
         /// <summary>
         /// Gets or sets a value indicating how the change in focus occurred.
         /// </summary>

src/Avalonia.Base/Input/KeyEventArgs.cs

@@ -5,6 +5,11 @@ namespace Avalonia.Input
 {
     public class KeyEventArgs : RoutedEventArgs
     {
+        internal KeyEventArgs()
+        {
+
+        }
+
         public IKeyboardDevice? Device { get; set; }
 
         public Key Key { get; set; }

src/Avalonia.Base/Input/PointerDeltaEventArgs.cs

@@ -7,7 +7,7 @@ namespace Avalonia.Input
     {
         public Vector Delta { get; set; }
 
-        public PointerDeltaEventArgs(RoutedEvent routedEvent, IInteractive? source, 
+        internal PointerDeltaEventArgs(RoutedEvent routedEvent, IInteractive? source, 
             IPointer pointer, IVisual rootVisual, Point rootVisualPosition, ulong timestamp,
             PointerPointProperties properties, KeyModifiers modifiers, Vector delta) 
             : base(routedEvent, source, pointer, rootVisual, rootVisualPosition,

src/Avalonia.Base/Input/PointerEventArgs.cs

@@ -13,7 +13,7 @@ namespace Avalonia.Input
         private readonly PointerPointProperties _properties;
         private readonly Lazy<IReadOnlyList<RawPointerPoint>?>? _previousPoints;
 
-        public PointerEventArgs(RoutedEvent routedEvent,
+        internal PointerEventArgs(RoutedEvent routedEvent,
             IInteractive? source,
             IPointer pointer,
             IVisual? rootVisual, Point rootVisualPosition,
@@ -30,8 +30,8 @@ namespace Avalonia.Input
             Timestamp = timestamp;
             KeyModifiers = modifiers;
         }
-        
-        public PointerEventArgs(RoutedEvent routedEvent,
+
+        internal PointerEventArgs(RoutedEvent routedEvent,
             IInteractive? source,
             IPointer pointer,
             IVisual? rootVisual, Point rootVisualPosition,
@@ -124,7 +124,7 @@ namespace Avalonia.Input
 
     public class PointerPressedEventArgs : PointerEventArgs
     {
-        public PointerPressedEventArgs(
+        internal PointerPressedEventArgs(
             IInteractive source,
             IPointer pointer,
             IVisual rootVisual, Point rootVisualPosition,
@@ -143,7 +143,7 @@ namespace Avalonia.Input
 
     public class PointerReleasedEventArgs : PointerEventArgs
     {
-        public PointerReleasedEventArgs(
+        internal PointerReleasedEventArgs(
             IInteractive source, IPointer pointer,
             IVisual rootVisual, Point rootVisualPosition, ulong timestamp,
             PointerPointProperties properties, KeyModifiers modifiers,
@@ -164,7 +164,7 @@ namespace Avalonia.Input
     {
         public IPointer Pointer { get; }
 
-        public PointerCaptureLostEventArgs(IInteractive source, IPointer pointer) : base(InputElement.PointerCaptureLostEvent)
+        internal PointerCaptureLostEventArgs(IInteractive source, IPointer pointer) : base(InputElement.PointerCaptureLostEvent)
         {
             Pointer = pointer;
             Source = source;

src/Avalonia.Base/Input/PointerWheelEventArgs.cs

@@ -7,7 +7,7 @@ namespace Avalonia.Input
     {
         public Vector Delta { get; set; }
 
-        public PointerWheelEventArgs(IInteractive source, IPointer pointer, IVisual rootVisual,
+        internal PointerWheelEventArgs(IInteractive source, IPointer pointer, IVisual rootVisual,
             Point rootVisualPosition, ulong timestamp,
             PointerPointProperties properties, KeyModifiers modifiers, Vector delta) 
             : base(InputElement.PointerWheelChangedEvent, source, pointer, rootVisual, rootVisualPosition,

src/Avalonia.Base/Input/ScrollGestureEventArgs.cs

@@ -9,8 +9,8 @@ namespace Avalonia.Input
         private static int _nextId = 1;
 
         public static int GetNextFreeId() => _nextId++;
-        
-        public ScrollGestureEventArgs(int id, Vector delta) : base(Gestures.ScrollGestureEvent)
+
+        internal ScrollGestureEventArgs(int id, Vector delta) : base(Gestures.ScrollGestureEvent)
         {
             Id = id;
             Delta = delta;
@@ -21,7 +21,7 @@ namespace Avalonia.Input
     {
         public int Id { get; }
 
-        public ScrollGestureEndedEventArgs(int id) : base(Gestures.ScrollGestureEndedEvent)
+        internal ScrollGestureEndedEventArgs(int id) : base(Gestures.ScrollGestureEndedEvent)
         {
             Id = id;
         }

src/Avalonia.Base/Input/TappedEventArgs.cs

@@ -7,7 +7,7 @@ namespace Avalonia.Input
     {
         private readonly PointerEventArgs lastPointerEventArgs;
 
-        public TappedEventArgs(RoutedEvent routedEvent, PointerEventArgs lastPointerEventArgs)
+        internal TappedEventArgs(RoutedEvent routedEvent, PointerEventArgs lastPointerEventArgs)
             : base(routedEvent)
         {
             this.lastPointerEventArgs = lastPointerEventArgs;

src/Avalonia.Base/Input/TextInputEventArgs.cs

@@ -4,6 +4,10 @@ namespace Avalonia.Input
 {
     public class TextInputEventArgs : RoutedEventArgs
     {
+        internal TextInputEventArgs()
+        {
+
+        }
         public IKeyboardDevice? Device { get; set; }
 
         public string? Text { get; set; }

src/Avalonia.Base/Input/VectorEventArgs.cs

@@ -5,6 +5,11 @@ namespace Avalonia.Input
 {
     public class VectorEventArgs : RoutedEventArgs
     {
+        internal VectorEventArgs()
+        {
+
+        }
+
         public Vector Vector { get; set; }
     }
 }

src/Avalonia.Base/Layout/EffectiveViewportChangedEventArgs.cs

@@ -7,7 +7,7 @@ namespace Avalonia.Layout
     /// </summary>
     public class EffectiveViewportChangedEventArgs : EventArgs
     {
-        public EffectiveViewportChangedEventArgs(Rect effectiveViewport)
+        internal EffectiveViewportChangedEventArgs(Rect effectiveViewport)
         {
             EffectiveViewport = effectiveViewport;
         }

src/Avalonia.Base/Rendering/SceneInvalidatedEventArgs.cs

@@ -12,7 +12,7 @@ namespace Avalonia.Rendering
         /// </summary>
         /// <param name="root">The render root that has been updated.</param>
         /// <param name="dirtyRect">The updated area.</param>
-        public SceneInvalidatedEventArgs(
+        internal SceneInvalidatedEventArgs(
             IRenderRoot root,
             Rect dirtyRect)
         {