tsai/Avalonia: A cross-platform UI framework for .NET - Avalonia - Gitea: Git with a cup of tea

A cross-platform UI framework for .NET

csharp c-sharp dotnet xaml avaloniaui cross-platform cross-platform-xaml avalonia gui multi-platform user-interface dotnetcore

Branch: main

History

Benedikt Stebner 14d462439e Match font family names case-insensitively (#22163 ) * Tighten the comments on the synthetic caching fix Keep the invariant and the reason, drop the retelling of how the leak was found. Also plain-ASCII the dashes and correct the doc on the test counter: the alias resolution goes through the same overload, so the counter proves the cached result short-circuits the platform call too. * Match font family names case-insensitively in the glyph typeface cache Every other family-name comparison in FontCollectionBase is OrdinalIgnoreCase - the sorted family array, the binary search in TryGetGlyphTypeface, AddFontFamily's de-duplication - but the cache itself used the default ordinal comparer. Two consequences: - A request whose casing differs from the cached one misses the bucket and so skips the nearest-match branch entirely. The family-name search that picks it up afterwards returns the nearest match raw, without synthesis and without caching, so "MyAlias" at Black renders faux-bold while "MYALIAS" at Black renders regular weight. - SystemFontCollection registers a resolved face under both the platform's family name and the requested one. When those differ only in casing that stores two buckets, while AddFontFamily de-duplicates case-insensitively and publishes only the first, leaving the second unreachable from every family-name search. Also compares the requested and platform family names case-insensitively before the second registration, so the redundant add goes away rather than becoming a silent no-op. * Reuse an already cached synthetic glyph typeface TryCreateSyntheticGlyphTypeface synthesised unconditionally. When a synthetic for the same source family and key was already cached, the second one lost TryAddGlyphTypeface to the instance holding the slot, so it was handed to the caller but never cached - and GlyphTypeface has no finalizer, only an explicit Dispose reachable from the cache, so its native typeface stayed alive for the rest of the process. Each one costs a full copy of the font file, which TryGetStream reads into memory and SKTypeface.FromStream copies again. Return the cached synthetic instead when its simulations match the ones this call would apply. The source family's typefaces are already in hand for the early-out above; they were fetched and then never used. Caching under the requested family name removed the path that reached this on every call, but the method is public on IFontCollection and the race remains, so guard it at the source. * Match font family mappings case-insensitively FontManagerOptions.FontFamilyMappings is supplied by the application, so its comparer is whatever its author gave it - ordinal for a plain Dictionary<string, FontFamily>. Family names are matched case-insensitively everywhere else, so a mapping silently did not apply when the requested name differed in casing from the configured key. Copy the mappings into an OrdinalIgnoreCase dictionary in the constructor. Keys that collide only by casing were separate entries before; the last wins rather than throwing, since a mapping table is configuration and failing here would take the application down at startup. Two behaviour changes worth naming: a mapping now applies whatever casing the name arrives in, and FontManager no longer observes mutations made to the caller's dictionary after construction.		3 weeks ago
..
TextFormatting	Fix infinite loop when a text run shapes to no glyphs (#22119)	1 month ago
BitmapSaveTests.cs	Implement Bitmap.Save with a format (#21455)	3 months ago
CustomFontCollectionTests.cs	[Text] Glyph Outline Part 2/13 - GlyphTypeface.GetGlyphOutline implementation (#21406)	4 weeks ago
CustomFontManagerImpl.cs	Universal GlyphTypeface implementation (#19852)	9 months ago
EmbeddedFontCollectionTests.cs	Universal GlyphTypeface implementation (#19852)	9 months ago
FontCollectionDeterminismTests.cs	[Text] Rework text fallback itemization (#21631)	3 months ago
FontCollectionTests.cs	Match font family names case-insensitively (#22163)	3 weeks ago
FontCollectionTryMatchCharacterTests.cs	[Text] Rework text fallback itemization (#21631)	3 months ago
FontManagerTests.cs	Match font family names case-insensitively (#22163)	3 weeks ago
GlyphRunTests.cs	[Text] Fixes double reorder of cached bidi runs (#21351)	5 months ago
GlyphTypefaceShapingTests.cs	[Text] Rework text fallback itemization (#21631)	3 months ago
ImmutableBitmapTests.cs	Skia: avoid SKBitmap.Copy when creating ImmutableBitmap from pixels (#21675)	3 months ago