tsai/Avalonia: A cross-platform UI framework for .NET - Avalonia - Gitea: Git with a cup of tea

A cross-platform UI framework for .NET

csharp c-sharp dotnet xaml avaloniaui cross-platform cross-platform-xaml avalonia gui multi-platform user-interface dotnetcore

Branch: main

History

Benedikt Stebner 2e7d2c5c60 Fix infinite loop when a text run shapes to no glyphs (#22119 ) * Add failing tests for runs that shape to no glyphs A shaper hides the default ignorables it substitutes for line breaks behind the font's space glyph, and deletes them when the font has no such glyph. A run holding nothing but a line break then shapes to an empty glyph buffer while still owning its characters. - TextFormatter drops that run today, so the line covers no text and the layout loop never advances past it - measuring a wrapping TextBlock whose text starts with a newline never returns. - GlyphRun indexes its glyph list without checking it is non-empty, so hit-testing such a run throws IndexOutOfRangeException. Covers all three layers: GlyphRun hit-testing, the formatted line, and the TextLayout repro from the issue. The layout test bounds maxLines so a regression fails instead of hanging the test run. The Skia tests embed the headless platform's BareMinimum.ttf, which has four glyphs and no space, rather than a copy of it. * Keep text runs that shape to no glyphs ShapeTogether split the shaped buffer by glyph count, so a run whose glyphs were all deleted by the shaper was skipped and its characters rolled into previousLength for a following run to absorb. When no such run follows, the characters are lost: the line reports a length of 0 and TextLayout formats the same line forever. Splitting by text length preserves the case the accumulation exists for - a run whose glyphs merged into a neighbouring cluster splits off no text either - and stops discarding characters that shaped to nothing. That makes zero-glyph glyph runs reachable for the first time, so: - GetDistanceFromCharacterHit, FindGlyphIndex and FindNearestCharacterHit handle an empty glyph list. There is no cluster to snap to and the run sits at a single position, so it degenerates to one zero-width cluster. - InkBounds answers empty directly instead of building a platform glyph run. TextLineImpl reads it for every shaped run in a line, and the Skia implementation creates an SKFont and measures glyph widths in its constructor - wasted on a run that marks nothing. Fixes #22004 * Adjust GlyphRun.InkBounds xml comment		1 month ago
..
Tables	Universal GlyphTypeface implementation (#19852)	9 months ago
EmptyShapedBufferTests.cs	Fix infinite loop when a text run shapes to no glyphs (#22119)	1 month ago
MultiBufferTextSource.cs	Hide TextRange. It has no public usage. (#20893)	7 months ago
ShapedBufferSharedStorageTests.cs	[Text] Unicode and text layout optimizations (#21400)	4 months ago
ShapingCapabilityFallbackTests.cs	[Text] Rework text fallback itemization (#21631)	3 months ago
SingleBufferTextSource.cs	Enable nullability in various test projects (#20374)	9 months ago
SplitTextRunsTests.cs	[Text] Unicode and text layout optimizations (#21400)	4 months ago
TextCharactersTests.cs	[Text] Do not shape the space after fallback text with the fallback font (#22067)	1 month ago
TextCollapsingBidiTests.cs	TextCollapsingProperties bidirectional-text (BiDi) correctness fixes (#21446)	4 months ago
TextFormatterTests.cs	[Text] Do not shape the space after fallback text with the fallback font (#22067)	1 month ago
TextFormatterWrapCharacterizationTests.cs	[Text] Unicode and text layout optimizations (#21400)	4 months ago
TextLayoutTests.cs	[Text] Do not shape the space after fallback text with the fallback font (#22067)	1 month ago
TextLineTests.cs	[Text] Do not shape the space after fallback text with the fallback font (#22067)	1 month ago
TextRunCacheTests.cs	[Text] Fixes double reorder of cached bidi runs (#21351)	5 months ago
TextShaperTests.cs	[Text] Snap a right-to-left buffer split to the cluster boundary (#22066)	1 month ago