Browse Source

fix(theme-shared): improve code quality of error.handler

pull/1566/head
mehmet-erim 7 years ago
parent
commit
2809ec8d4e
  1. 29
      npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts

29
npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts

@ -68,17 +68,26 @@ export class ErrorHandler {
); );
break; break;
case 403: case 403:
this.show403(); this.createErrorComponent({
title: DEFAULTS.defaultError403.message,
details: DEFAULTS.defaultError403.details,
});
break; break;
case 404: case 404:
this.showError(DEFAULTS.defaultError404.details, DEFAULTS.defaultError404.message); this.showError(DEFAULTS.defaultError404.details, DEFAULTS.defaultError404.message);
break; break;
case 500: case 500:
this.show500(); this.createErrorComponent({
title: '500',
details: 'Sorry, an error has occured.',
});
break; break;
case 0: case 0:
if ((err as HttpErrorResponse).statusText === 'Unknown Error') { if ((err as HttpErrorResponse).statusText === 'Unknown Error') {
this.show500(); this.createErrorComponent({
title: 'Unknown Error',
details: 'Sorry, an error has occured.',
});
} }
break; break;
default: default:
@ -113,20 +122,6 @@ export class ErrorHandler {
); );
} }
private show500() {
this.createErrorComponent({
title: '500',
details: 'Sorry, an error has occured.',
});
}
private show403() {
this.createErrorComponent({
title: DEFAULTS.defaultError403.message,
details: DEFAULTS.defaultError403.details,
});
}
createErrorComponent(instance: Partial<ErrorComponent>) { createErrorComponent(instance: Partial<ErrorComponent>) {
const renderer = this.rendererFactory.createRenderer(null, null); const renderer = this.rendererFactory.createRenderer(null, null);
const host = renderer.selectRootElement('app-root', true); const host = renderer.selectRootElement('app-root', true);

Loading…
Cancel
Save