Browse Source

Remove Todo.

pull/1441/head
maliming 7 years ago
parent
commit
7bc3cad009
  1. 2
      framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/UpdateCommand.cs
  2. 1
      framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Analyticses/CliAnalyticsCollect.cs
  3. 2
      framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/ProjectBuilder.cs

2
framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/UpdateCommand.cs

@ -52,7 +52,7 @@ namespace Volo.Abp.Cli.Commands
{
Tool = _options.ToolName,
Command = commandLineArgs.Command,
Options = _jsonSerializer.Serialize(options) //TODO: JSON or comma separated string?
Options = _jsonSerializer.Serialize(options)
});
}

1
framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Analyticses/CliAnalyticsCollect.cs

@ -36,7 +36,6 @@ namespace Volo.Abp.Cli.ProjectBuilding.Analyticses
_cancellationTokenProvider.Token
);
// TODO: Do not output logs, keep silent?
if (!responseMessage.IsSuccessStatusCode)
{
_logger.LogInformation("Remote server returns error! HTTP status code: " +

2
framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/ProjectBuilder.cs

@ -83,7 +83,7 @@ namespace Volo.Abp.Cli.ProjectBuilding
Command = args.ExtraProperties.ContainsKey(CliConsts.Command) ? args.ExtraProperties[CliConsts.Command] : "",
DatabaseProvider = args.DatabaseProvider.ToProviderName(),
IsTiered = args.ExtraProperties.ContainsKey("tiered"),
Options = JsonSerializer.Serialize(options), //TODO: JSON or comma separated string?
Options = JsonSerializer.Serialize(options),
ProjectName = args.SolutionName.FullName,
TemplateName = args.TemplateName,
TemplateVersion = templateFile.Version

Loading…
Cancel
Save