refactor the global feature system

modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/Abp/GlobalFeatures/GlobalFeature.cs

@@ -10,6 +10,7 @@ namespace Volo.Abp.GlobalFeatures
         [NotNull]
         public GlobalFeatureManager FeatureManager { get; }
 
+        [NotNull]
         public string FeatureName { get; }
 
         public bool IsEnabled

modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/Abp/GlobalFeatures/GlobalFeatureManager.cs

@@ -8,6 +8,9 @@ namespace Volo.Abp.GlobalFeatures
     {
         public static GlobalFeatureManager Instance { get; protected set; } = new GlobalFeatureManager();
 
+        /// <summary>
+        /// A common dictionary to store arbitrary configurations.
+        /// </summary>
         [NotNull]
         public Dictionary<object, object> Configuration { get; }
 

modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/Abp/GlobalFeatures/GlobalFeatureManagerModuleConfigurator.cs

@@ -5,16 +5,16 @@ namespace Volo.Abp.GlobalFeatures
     public abstract class GlobalModuleFeatures
     {
         [NotNull]
-        public GlobalFeatureConfiguratorDictionary AllFeatures { get; }
+        public GlobalFeatureManager FeatureManager { get; }
 
         [NotNull]
-        public GlobalFeatureManager FeatureManager { get; }
+        protected GlobalFeatureConfiguratorDictionary AllFeatures { get; }
 
         protected GlobalModuleFeatures(
-            GlobalFeatureManager featureManager)
+            [NotNull] GlobalFeatureManager featureManager)
         {
+            FeatureManager = Check.NotNull(featureManager, nameof(featureManager));
             AllFeatures = new GlobalFeatureConfiguratorDictionary();
-            FeatureManager = featureManager;
         }
 
         public virtual void EnableAll()
@@ -43,10 +43,10 @@ namespace Volo.Abp.GlobalFeatures
             return AllFeatures[featureName];
         }
 
-        protected TFeature GetFeature<TFeature>(string featureName)
+        protected TFeature GetFeature<TFeature>()
             where TFeature : GlobalFeature
         {
-            return (TFeature) AllFeatures[featureName];
+            return (TFeature) GetFeature(GlobalFeatureNameAttribute.GetName<TFeature>());
         }
     }
 }

modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/Abp/GlobalFeatures/GlobalFeatureNameAttribute.cs

@@ -8,6 +8,7 @@ namespace Volo.Abp.GlobalFeatures
     [AttributeUsage(AttributeTargets.Class)]
     public class GlobalFeatureNameAttribute : Attribute
     {
+        [NotNull]
         public string Name { get; }
 
         public GlobalFeatureNameAttribute([NotNull] string name)
@@ -21,6 +22,7 @@ namespace Volo.Abp.GlobalFeatures
             return GetName(typeof(TFeature));
         }
 
+        [NotNull]
         public static string GetName(Type type)
         {
             var attribute = type

modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/GlobalFeatures/CommentsFeature.cs

@@ -8,7 +8,7 @@ namespace Volo.CmsKit.GlobalFeatures
     {
         public const string Name = "CmsKit.Comments";
 
-        public CommentsFeature(
+        internal CommentsFeature(
             [NotNull] GlobalCmsKitFeatures cmsKit
         ) : base(cmsKit)
         {

modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/GlobalFeatures/GlobalFeatureManagerCmsKitConfigurator.cs → modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/GlobalFeatures/GlobalCmsKitFeatures.cs

@@ -1,4 +1,5 @@
-using Volo.Abp.GlobalFeatures;
+using JetBrains.Annotations;
+using Volo.Abp.GlobalFeatures;
 
 namespace Volo.CmsKit.GlobalFeatures
 {
@@ -6,11 +7,10 @@ namespace Volo.CmsKit.GlobalFeatures
     {
         public const string ModuleName = "CmsKit";
 
-        public ReactionsFeature Reactions => GetFeature<ReactionsFeature>(ReactionsFeature.Name);
+        public ReactionsFeature Reactions => GetFeature<ReactionsFeature>();
+        public CommentsFeature Comments => GetFeature<CommentsFeature>();
 
-        public CommentsFeature Comments => GetFeature<CommentsFeature>(CommentsFeature.Name);
-
-        public GlobalCmsKitFeatures(GlobalFeatureManager featureManager)
+        public GlobalCmsKitFeatures([NotNull] GlobalFeatureManager featureManager)
             : base(featureManager)
         {
             AddFeature(new ReactionsFeature(this));

modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/GlobalFeatures/ReactionsFeature.cs

@@ -8,7 +8,7 @@ namespace Volo.CmsKit.GlobalFeatures
     {
         public const string Name = "CmsKit.Reactions";
 
-        public ReactionsFeature(
+        internal  ReactionsFeature(
             [NotNull] GlobalCmsKitFeatures cmsKit
             ) : base(cmsKit)
         {