Browse Source

fix: remove pristine check from validators

pull/6432/head
Arman Ozak 6 years ago
parent
commit
a234ccc98f
  1. 2
      npm/ng-packs/packages/core/src/lib/validators/age.validator.ts
  2. 2
      npm/ng-packs/packages/core/src/lib/validators/credit-card.validator.ts
  3. 2
      npm/ng-packs/packages/core/src/lib/validators/range.validator.ts
  4. 4
      npm/ng-packs/packages/core/src/lib/validators/required.validator.ts
  5. 2
      npm/ng-packs/packages/core/src/lib/validators/string-length.validator.ts
  6. 2
      npm/ng-packs/packages/core/src/lib/validators/url.validator.ts

2
npm/ng-packs/packages/core/src/lib/validators/age.validator.ts

@ -12,8 +12,6 @@ export interface MinAgeOptions {
export function validateMinAge({ age = 18 }: MinAgeOptions = {}): ValidatorFn { export function validateMinAge({ age = 18 }: MinAgeOptions = {}): ValidatorFn {
return (control: AbstractControl): MinAgeError | null => { return (control: AbstractControl): MinAgeError | null => {
if (control.pristine) return null;
if (['', null, undefined].indexOf(control.value) > -1) return null; if (['', null, undefined].indexOf(control.value) > -1) return null;
return isValidMinAge(control.value, age) ? null : { minAge: { age } }; return isValidMinAge(control.value, age) ? null : { minAge: { age } };

2
npm/ng-packs/packages/core/src/lib/validators/credit-card.validator.ts

@ -6,8 +6,6 @@ export interface CreditCardError {
export function validateCreditCard(): ValidatorFn { export function validateCreditCard(): ValidatorFn {
return (control: AbstractControl): CreditCardError | null => { return (control: AbstractControl): CreditCardError | null => {
if (control.pristine) return null;
if (['', null, undefined].indexOf(control.value) > -1) return null; if (['', null, undefined].indexOf(control.value) > -1) return null;
return isValidCreditCard(String(control.value)) ? null : { creditCard: true }; return isValidCreditCard(String(control.value)) ? null : { creditCard: true };

2
npm/ng-packs/packages/core/src/lib/validators/range.validator.ts

@ -14,8 +14,6 @@ export interface RangeOptions {
export function validateRange({ maximum = Infinity, minimum = 0 }: RangeOptions = {}): ValidatorFn { export function validateRange({ maximum = Infinity, minimum = 0 }: RangeOptions = {}): ValidatorFn {
return (control: AbstractControl): RangeError | null => { return (control: AbstractControl): RangeError | null => {
if (control.pristine) return null;
if (['', null, undefined].indexOf(control.value) > -1) return null; if (['', null, undefined].indexOf(control.value) > -1) return null;
const value = Number(control.value); const value = Number(control.value);

4
npm/ng-packs/packages/core/src/lib/validators/required.validator.ts

@ -10,9 +10,7 @@ export interface RequiredOptions {
export function validateRequired({ allowEmptyStrings }: RequiredOptions = {}): ValidatorFn { export function validateRequired({ allowEmptyStrings }: RequiredOptions = {}): ValidatorFn {
return (control: AbstractControl): RequiredError | null => { return (control: AbstractControl): RequiredError | null => {
return control.pristine || isValidRequired(control.value, allowEmptyStrings) return isValidRequired(control.value, allowEmptyStrings) ? null : { required: true };
? null
: { required: true };
}; };
} }

2
npm/ng-packs/packages/core/src/lib/validators/string-length.validator.ts

@ -19,8 +19,6 @@ export function validateStringLength({
minimumLength = 0, minimumLength = 0,
}: StringLengthOptions = {}): ValidatorFn { }: StringLengthOptions = {}): ValidatorFn {
return (control: AbstractControl): StringLengthError | null => { return (control: AbstractControl): StringLengthError | null => {
if (control.pristine) return null;
if (['', null, undefined].indexOf(control.value) > -1) return null; if (['', null, undefined].indexOf(control.value) > -1) return null;
const value = String(control.value); const value = String(control.value);

2
npm/ng-packs/packages/core/src/lib/validators/url.validator.ts

@ -6,8 +6,6 @@ export interface UrlError {
export function validateUrl(): ValidatorFn { export function validateUrl(): ValidatorFn {
return (control: AbstractControl): UrlError | null => { return (control: AbstractControl): UrlError | null => {
if (control.pristine) return null;
if (['', null, undefined].indexOf(control.value) > -1) return null; if (['', null, undefined].indexOf(control.value) > -1) return null;
return isValidUrl(control.value) ? null : { url: true }; return isValidUrl(control.value) ? null : { url: true };

Loading…
Cancel
Save