Browse Source

Clean up and update test imports and providers

Replaces deprecated HttpClientModule with provideHttpClient and provideHttpClientTesting in breadcrumb tests, removes unused imports and declarations from card, error handler, and validation utils test files for improved clarity and maintainability.
pull/23460/head
Fahri Gedik 8 months ago
parent
commit
e58841ddfe
  1. 7
      npm/ng-packs/packages/theme-shared/src/lib/tests/breadcrumb.component.spec.ts
  2. 1
      npm/ng-packs/packages/theme-shared/src/lib/tests/card.component.spec.ts
  3. 3
      npm/ng-packs/packages/theme-shared/src/lib/tests/error.handler.spec.ts
  4. 2
      npm/ng-packs/packages/theme-shared/src/lib/tests/validation-utils.spec.ts

7
npm/ng-packs/packages/theme-shared/src/lib/tests/breadcrumb.component.spec.ts

@ -6,7 +6,8 @@ import {
RoutesService, RoutesService,
LocalizationService, LocalizationService,
} from '@abp/ng.core'; } from '@abp/ng.core';
import { HttpClient, HttpClientModule } from '@angular/common/http'; import { provideHttpClient } from '@angular/common/http';
import { provideHttpClientTesting } from '@angular/common/http/testing';
import { RouterModule } from '@angular/router'; import { RouterModule } from '@angular/router';
import { createRoutingFactory, SpectatorRouting } from '@ngneat/spectator/jest'; import { createRoutingFactory, SpectatorRouting } from '@ngneat/spectator/jest';
import { BreadcrumbComponent, BreadcrumbItemsComponent } from '../components'; import { BreadcrumbComponent, BreadcrumbItemsComponent } from '../components';
@ -33,8 +34,9 @@ describe('BreadcrumbComponent', () => {
component: RouterOutletComponent, component: RouterOutletComponent,
stubsEnabled: false, stubsEnabled: false,
detectChanges: false, detectChanges: false,
mocks: [HttpClient],
providers: [ providers: [
provideHttpClient(),
provideHttpClientTesting(),
{ {
provide: CORE_OPTIONS, provide: CORE_OPTIONS,
useValue: { useValue: {
@ -61,7 +63,6 @@ describe('BreadcrumbComponent', () => {
declarations: [], declarations: [],
imports: [ imports: [
RouterModule, RouterModule,
HttpClientModule,
LocalizationPipe, LocalizationPipe,
BreadcrumbComponent, BreadcrumbComponent,
BreadcrumbItemsComponent, BreadcrumbItemsComponent,

1
npm/ng-packs/packages/theme-shared/src/lib/tests/card.component.spec.ts

@ -4,7 +4,6 @@ import {
CardBodyComponent, CardBodyComponent,
CardFooterComponent, CardFooterComponent,
CardHeaderComponent, CardHeaderComponent,
CardHeaderDirective,
CardTitleDirective, CardTitleDirective,
CardImgTopDirective, CardImgTopDirective,
CardSubtitleDirective, CardSubtitleDirective,

3
npm/ng-packs/packages/theme-shared/src/lib/tests/error.handler.spec.ts

@ -2,13 +2,12 @@ import { HttpErrorReporterService } from '@abp/ng.core';
import { CoreTestingModule } from '@abp/ng.core/testing'; import { CoreTestingModule } from '@abp/ng.core/testing';
import { APP_BASE_HREF } from '@angular/common'; import { APP_BASE_HREF } from '@angular/common';
import { HttpErrorResponse, HttpHeaders } from '@angular/common/http'; import { HttpErrorResponse, HttpHeaders } from '@angular/common/http';
import { Component, NgModule } from '@angular/core'; import { NgModule } from '@angular/core';
import { createServiceFactory, SpectatorService } from '@ngneat/spectator/jest'; import { createServiceFactory, SpectatorService } from '@ngneat/spectator/jest';
import { OAuthService } from 'angular-oauth2-oidc'; import { OAuthService } from 'angular-oauth2-oidc';
import { of, Subject } from 'rxjs'; import { of, Subject } from 'rxjs';
import { HttpErrorWrapperComponent } from '../components/http-error-wrapper/http-error-wrapper.component'; import { HttpErrorWrapperComponent } from '../components/http-error-wrapper/http-error-wrapper.component';
import { ErrorHandler } from '../handlers'; import { ErrorHandler } from '../handlers';
import { DEFAULT_ERROR_LOCALIZATIONS, DEFAULT_ERROR_MESSAGES } from '../constants/default-errors';
import { ConfirmationService } from '../services'; import { ConfirmationService } from '../services';
import { CUSTOM_ERROR_HANDLERS, HTTP_ERROR_CONFIG } from '../tokens/http-error.token'; import { CUSTOM_ERROR_HANDLERS, HTTP_ERROR_CONFIG } from '../tokens/http-error.token';
import { CustomHttpErrorHandlerService } from '../models'; import { CustomHttpErrorHandlerService } from '../models';

2
npm/ng-packs/packages/theme-shared/src/lib/tests/validation-utils.spec.ts

@ -2,12 +2,10 @@ import { AbpApplicationConfigurationService, ConfigStateService } from '@abp/ng.
import { CoreTestingModule } from '@abp/ng.core/testing'; import { CoreTestingModule } from '@abp/ng.core/testing';
import { HttpClient } from '@angular/common/http'; import { HttpClient } from '@angular/common/http';
import { Component, Injector } from '@angular/core'; import { Component, Injector } from '@angular/core';
import { Validators } from '@angular/forms';
import { createComponentFactory, Spectator } from '@ngneat/spectator/jest'; import { createComponentFactory, Spectator } from '@ngneat/spectator/jest';
import { OAuthService } from 'angular-oauth2-oidc'; import { OAuthService } from 'angular-oauth2-oidc';
import { of } from 'rxjs'; import { of } from 'rxjs';
import { getPasswordValidators, validatePassword } from '../utils'; import { getPasswordValidators, validatePassword } from '../utils';
import { PasswordRule } from '../models/validation';
@Component({ template: '', selector: 'abp-dummy' }) @Component({ template: '', selector: 'abp-dummy' })
class DummyComponent {} class DummyComponent {}

Loading…
Cancel
Save