Browse Source

Review comments.

pull/4214/head
mike12345567 5 years ago
parent
commit
b84b34d5ae
  1. 9
      packages/server/src/api/controllers/row/staticFormula.js
  2. 1
      packages/server/src/api/controllers/table/bulkFormula.js

9
packages/server/src/api/controllers/row/staticFormula.js

@ -38,12 +38,16 @@ exports.updateRelatedFormula = async (appId, table, enrichedRows) => {
} }
} }
for (let tableId of table.relatedFormula) { for (let tableId of table.relatedFormula) {
let relatedTable
try { try {
// no rows to update, skip // no rows to update, skip
if (!relatedRows[tableId] || relatedRows[tableId].length === 0) { if (!relatedRows[tableId] || relatedRows[tableId].length === 0) {
continue continue
} }
const relatedTable = await db.get(tableId) relatedTable = await db.get(tableId)
} catch (err) {
// no error scenario, table doesn't seem to exist anymore, ignore
}
for (let column of Object.values(relatedTable.schema)) { for (let column of Object.values(relatedTable.schema)) {
// needs updated in related rows // needs updated in related rows
if ( if (
@ -60,9 +64,6 @@ exports.updateRelatedFormula = async (appId, table, enrichedRows) => {
) )
} }
} }
} catch (err) {
// no error scenario, table doesn't seem to exist anymore, ignore
}
} }
} }
await Promise.all(promises) await Promise.all(promises)

1
packages/server/src/api/controllers/table/bulkFormula.js

@ -37,7 +37,6 @@ function getFormulaThatUseColumn(table, columnNames) {
* This functions checks for when a related table, column or related column is deleted, if any * This functions checks for when a related table, column or related column is deleted, if any
* tables need to have the formula column removed. * tables need to have the formula column removed.
*/ */
async function checkIfFormulaNeedsCleared( async function checkIfFormulaNeedsCleared(
appId, appId,
table, table,

Loading…
Cancel
Save