Browse Source

Avoid throwing errors if no condition is passed to a DataCondition

pull/6419/head
mohamedsalem401 2 years ago
parent
commit
a5e8994008
  1. 10
      packages/core/src/data_sources/model/conditional_variables/DataCondition.ts

10
packages/core/src/data_sources/model/conditional_variables/DataCondition.ts

@ -8,6 +8,7 @@ import { GenericOperation } from './operators/GenericOperator';
import { LogicalOperation } from './operators/LogicalOperator';
import { NumberOperation } from './operators/NumberOperator';
import { StringOperation } from './operators/StringOperations';
import { isUndefined } from 'underscore';
export const DataConditionType = 'data-condition';
@ -45,8 +46,8 @@ export class DataCondition extends Model<DataConditionPropsDefined> {
public ifFalse: any,
opts: { em: EditorModel; onValueChange?: () => void },
) {
if (typeof condition === 'undefined') {
throw new MissingConditionError();
if (isUndefined(condition)) {
opts.em.logError('No condition was provided to a conditional component.');
}
const conditionInstance = new Condition(condition, { em: opts.em });
@ -128,8 +129,3 @@ export class DataCondition extends Model<DataConditionPropsDefined> {
};
}
}
export class MissingConditionError extends Error {
constructor() {
super('No condition was provided to a conditional component.');
}
}

Loading…
Cancel
Save