Browse Source

Corrected the fix.

pull/593/head
Sebastian 5 years ago
parent
commit
1f7084c66d
  1. 2
      backend/src/Squidex.Domain.Apps.Entities.MongoDb/Assets/Visitors/FindExtensions.cs
  2. 2
      backend/src/Squidex.Infrastructure/DomainId.cs
  3. 24
      backend/tests/Squidex.Infrastructure.Tests/DomainIdTests.cs

2
backend/src/Squidex.Domain.Apps.Entities.MongoDb/Assets/Visitors/FindExtensions.cs

@ -46,7 +46,7 @@ namespace Squidex.Domain.Apps.Entities.MongoDb.Assets.Visitors
if (parentId.HasValue) if (parentId.HasValue)
{ {
if (parentId.Value == DomainId.Empty) if (parentId == DomainId.Empty)
{ {
filters.Add( filters.Add(
Filter.Or( Filter.Or(

2
backend/src/Squidex.Infrastructure/DomainId.cs

@ -31,7 +31,7 @@ namespace Squidex.Infrastructure
return null; return null;
} }
return new DomainId(value); return Create(value);
} }
public static DomainId Create(string value) public static DomainId Create(string value)

24
backend/tests/Squidex.Infrastructure.Tests/DomainIdTests.cs

@ -91,6 +91,30 @@ namespace Squidex.Infrastructure
Assert.Equal(text, domainId.ToString()); Assert.Equal(text, domainId.ToString());
} }
[Fact]
public void Should_compare_with_nullable()
{
DomainId? value = DomainId.Empty;
Assert.True(value == DomainId.Empty);
}
[Fact]
public void Should_compare_with_nullable2()
{
DomainId? value = DomainId.Create(Guid.Empty.ToString());
Assert.True(value == DomainId.Empty);
}
[Fact]
public void Should_compare_with_non_shared_nullable()
{
DomainId? value = DomainId.Create("0");
Assert.True(value == DomainId.Create("0"));
}
[Fact] [Fact]
public void Should_make_correct_equal_comparisons() public void Should_make_correct_equal_comparisons()
{ {

Loading…
Cancel
Save