Browse Source

Disable graphql cache for tests.

pull/632/head
Sebastian 5 years ago
parent
commit
9a5282a600
  1. 18
      backend/src/Squidex.Domain.Apps.Entities/Contents/GraphQL/CachingGraphQLService.cs
  2. 14
      backend/src/Squidex.Domain.Apps.Entities/Contents/GraphQL/GraphQLOptions.cs
  3. 2
      backend/src/Squidex/Config/Domain/QueryServices.cs
  4. 65
      backend/tests/Squidex.Domain.Apps.Entities.Tests/Contents/GraphQL/GraphQLTestBase.cs
  5. 1
      backend/tests/docker-compose.yml
  6. 1
      backend/tools/TestSuite/TestSuite.ApiTests/GraphQLTests.cs

18
backend/src/Squidex.Domain.Apps.Entities/Contents/GraphQL/CachingGraphQLService.cs

@ -10,6 +10,7 @@ using System.Linq;
using System.Threading.Tasks; using System.Threading.Tasks;
using GraphQL.Utilities; using GraphQL.Utilities;
using Microsoft.Extensions.Caching.Memory; using Microsoft.Extensions.Caching.Memory;
using Microsoft.Extensions.Options;
using Squidex.Domain.Apps.Entities.Apps; using Squidex.Domain.Apps.Entities.Apps;
using Squidex.Domain.Apps.Entities.Contents.GraphQL.Types; using Squidex.Domain.Apps.Entities.Contents.GraphQL.Types;
using Squidex.Infrastructure; using Squidex.Infrastructure;
@ -22,14 +23,17 @@ namespace Squidex.Domain.Apps.Entities.Contents.GraphQL
private static readonly TimeSpan CacheDuration = TimeSpan.FromMinutes(10); private static readonly TimeSpan CacheDuration = TimeSpan.FromMinutes(10);
private readonly IMemoryCache cache; private readonly IMemoryCache cache;
private readonly IServiceProvider resolver; private readonly IServiceProvider resolver;
private readonly GraphQLOptions options;
public CachingGraphQLService(IMemoryCache cache, IServiceProvider resolver) public CachingGraphQLService(IMemoryCache cache, IServiceProvider resolver, IOptions<GraphQLOptions> options)
{ {
Guard.NotNull(cache, nameof(cache)); Guard.NotNull(cache, nameof(cache));
Guard.NotNull(resolver, nameof(resolver)); Guard.NotNull(resolver, nameof(resolver));
Guard.NotNull(options, nameof(options));
this.cache = cache; this.cache = cache;
this.resolver = resolver; this.resolver = resolver;
this.options = options.Value;
} }
public async Task<(bool HasError, object Response)> QueryAsync(Context context, params GraphQLQuery[] queries) public async Task<(bool HasError, object Response)> QueryAsync(Context context, params GraphQLQuery[] queries)
@ -81,19 +85,29 @@ namespace Squidex.Domain.Apps.Entities.Contents.GraphQL
private Task<GraphQLModel> GetModelAsync(IAppEntity app) private Task<GraphQLModel> GetModelAsync(IAppEntity app)
{ {
if (options.CacheDuration <= 0)
{
return CreateModelAsync(app);
}
var cacheKey = CreateCacheKey(app.Id, app.Version.ToString()); var cacheKey = CreateCacheKey(app.Id, app.Version.ToString());
return cache.GetOrCreateAsync(cacheKey, async entry => return cache.GetOrCreateAsync(cacheKey, async entry =>
{ {
entry.AbsoluteExpirationRelativeToNow = CacheDuration; entry.AbsoluteExpirationRelativeToNow = CacheDuration;
return await CreateModelAsync(app);
});
}
private async Task<GraphQLModel> CreateModelAsync(IAppEntity app)
{
var allSchemas = await resolver.GetRequiredService<IAppProvider>().GetSchemasAsync(app.Id); var allSchemas = await resolver.GetRequiredService<IAppProvider>().GetSchemasAsync(app.Id);
return new GraphQLModel(app, return new GraphQLModel(app,
allSchemas, allSchemas,
resolver.GetRequiredService<SharedTypes>(), resolver.GetRequiredService<SharedTypes>(),
resolver.GetRequiredService<ISemanticLog>()); resolver.GetRequiredService<ISemanticLog>());
});
} }
private static object CreateCacheKey(DomainId appId, string etag) private static object CreateCacheKey(DomainId appId, string etag)

14
backend/src/Squidex.Domain.Apps.Entities/Contents/GraphQL/GraphQLOptions.cs

@ -0,0 +1,14 @@
// ==========================================================================
// Squidex Headless CMS
// ==========================================================================
// Copyright (c) Squidex UG (haftungsbeschraenkt)
// All rights reserved. Licensed under the MIT license.
// ==========================================================================
namespace Squidex.Domain.Apps.Entities.Contents.GraphQL
{
public sealed class GraphQLOptions
{
public int CacheDuration { get; set; } = 10 * 60;
}
}

2
backend/src/Squidex/Config/Domain/QueryServices.cs

@ -21,6 +21,8 @@ namespace Squidex.Config.Domain
{ {
var exposeSourceUrl = config.GetOptionalValue("assetStore:exposeSourceUrl", true); var exposeSourceUrl = config.GetOptionalValue("assetStore:exposeSourceUrl", true);
services.Configure<GraphQLOptions>(config, "graphql");
services.AddSingletonAs(c => ActivatorUtilities.CreateInstance<UrlGenerator>(c, exposeSourceUrl)) services.AddSingletonAs(c => ActivatorUtilities.CreateInstance<UrlGenerator>(c, exposeSourceUrl))
.As<IUrlGenerator>(); .As<IUrlGenerator>();

65
backend/tests/Squidex.Domain.Apps.Entities.Tests/Contents/GraphQL/GraphQLTestBase.cs

@ -10,6 +10,7 @@ using System.Collections.Generic;
using FakeItEasy; using FakeItEasy;
using GraphQL.DataLoader; using GraphQL.DataLoader;
using Microsoft.Extensions.Caching.Memory; using Microsoft.Extensions.Caching.Memory;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options; using Microsoft.Extensions.Options;
using Newtonsoft.Json; using Newtonsoft.Json;
using Squidex.Domain.Apps.Core; using Squidex.Domain.Apps.Core;
@ -139,52 +140,40 @@ namespace Squidex.Domain.Apps.Entities.Contents.GraphQL
return serializer.Serialize(result); return serializer.Serialize(result);
} }
public sealed class TestServiceProvider : IServiceProvider private CachingGraphQLService CreateSut()
{ {
private readonly Dictionary<Type, object> services; var cache = new MemoryCache(Options.Create(new MemoryCacheOptions()));
public TestServiceProvider(GraphQLTestBase testBase)
{
var appProvider = A.Fake<IAppProvider>(); var appProvider = A.Fake<IAppProvider>();
A.CallTo(() => appProvider.GetSchemasAsync(testBase.appId.Id)) A.CallTo(() => appProvider.GetSchemasAsync(appId.Id))
.Returns(new List<ISchemaEntity> .Returns(new List<ISchemaEntity>
{ {
testBase.schema, schema,
testBase.schemaRef1, schemaRef1,
testBase.schemaRef2, schemaRef2,
testBase.schemaInvalidName schemaInvalidName
}); });
var dataLoaderContext = new DataLoaderContextAccessor(); var dataLoaderContext = (IDataLoaderContextAccessor)new DataLoaderContextAccessor();
var dataLoaderListener = new DataLoaderDocumentListener(dataLoaderContext);
var urlGenerator = new FakeUrlGenerator();
var services =
services = new Dictionary<Type, object> new ServiceCollection()
{ .AddMemoryCache()
[typeof(IAppProvider)] = appProvider, .AddSingleton(A.Fake<ISemanticLog>())
[typeof(IAssetQueryService)] = testBase.assetQuery, .AddSingleton(appProvider)
[typeof(ICommandBus)] = testBase.commandBus, .AddSingleton(assetQuery)
[typeof(IContentQueryService)] = testBase.contentQuery, .AddSingleton(commandBus)
[typeof(IDataLoaderContextAccessor)] = dataLoaderContext, .AddSingleton(contentQuery)
[typeof(IUrlGenerator)] = urlGenerator, .AddSingleton(dataLoaderContext)
[typeof(ISemanticLog)] = A.Fake<ISemanticLog>(), .AddSingleton(dataLoaderListener)
[typeof(DataLoaderDocumentListener)] = new DataLoaderDocumentListener(dataLoaderContext), .AddSingleton<SharedTypes>()
[typeof(SharedTypes)] = new SharedTypes(urlGenerator) .AddSingleton<IUrlGenerator,
}; FakeUrlGenerator>()
} .BuildServiceProvider();
public object GetService(Type serviceType) return new CachingGraphQLService(cache, services, Options.Create(new GraphQLOptions()));
{
return services.GetOrDefault(serviceType);
}
}
private CachingGraphQLService CreateSut()
{
var cache = new MemoryCache(Options.Create(new MemoryCacheOptions()));
return new CachingGraphQLService(cache, new TestServiceProvider(this));
} }
} }
} }

1
backend/tests/docker-compose.yml

@ -18,6 +18,7 @@ services:
- IDENTITY__ADMINCLIENTSECRET=xeLd6jFxqbXJrfmNLlO2j1apagGGGSyZJhFnIuHp4I0= - IDENTITY__ADMINCLIENTSECRET=xeLd6jFxqbXJrfmNLlO2j1apagGGGSyZJhFnIuHp4I0=
- STORE__MONGODB__CONFIGURATION=mongodb://mongo - STORE__MONGODB__CONFIGURATION=mongodb://mongo
- STORE__TYPE=MongoDB - STORE__TYPE=MongoDB
- GRAPHQL__CACHEDURATION=0
networks: networks:
- internal - internal
depends_on: depends_on:

1
backend/tools/TestSuite/TestSuite.ApiTests/GraphQLTests.cs

@ -19,7 +19,6 @@ using Xunit;
namespace TestSuite.ApiTests namespace TestSuite.ApiTests
{ {
[Trait("Category", "NotAutomated")]
public sealed class GraphQLTests : IClassFixture<ContentFixture> public sealed class GraphQLTests : IClassFixture<ContentFixture>
{ {
public ContentFixture _ { get; } public ContentFixture _ { get; }

Loading…
Cancel
Save