Browse Source

Tests fixed.

pull/479/head
Sebastian 6 years ago
parent
commit
c3a0aaf788
  1. 2
      frontend/app/framework/angular/forms/editors/tag-editor.component.scss
  2. 10
      frontend/app/framework/utils/error.spec.ts
  3. 6
      frontend/app/shared/components/assets/asset-dialog.component.html
  4. 2
      frontend/app/shared/components/assets/asset-dialog.component.ts
  5. 2
      frontend/app/shared/interceptors/auth.interceptor.spec.ts
  6. 14
      frontend/app/shared/state/assets.forms.spec.ts

2
frontend/app/framework/angular/forms/editors/tag-editor.component.scss

@ -34,6 +34,7 @@ $inner-height: 1.75rem;
&.focus {
border-color: $focus-color;
border-width: 1px;
box-shadow: 0 0 0 .2rem $focus-shadow;
}
@ -127,7 +128,6 @@ div {
padding: 1px .5rem;
vertical-align: top;
white-space: nowrap;
width: auto;
}
&.disabled {

10
frontend/app/framework/utils/error.spec.ts

@ -8,31 +8,31 @@
import { ErrorDto } from './error';
describe('ErrorDto', () => {
it('Should create simple message when no details are specified.', () => {
it('should create simple message when no details are specified.', () => {
const error = new ErrorDto(500, 'Error Message.');
expect(error.displayMessage).toBe('Error Message.');
});
it('Should append dot to message', () => {
it('should append dot to message', () => {
const error = new ErrorDto(500, 'Error Message');
expect(error.displayMessage).toBe('Error Message.');
});
it('Should create simple message when detail has one item', () => {
it('should create simple message when detail has one item', () => {
const error = new ErrorDto(500, 'Error Message.', ['Detail Message.']);
expect(error.displayMessage).toBe('Error Message.\n\n * Detail Message.\n');
});
it('Should create simple message with appended dots when detail has one item', () => {
it('should create simple message with appended dots when detail has one item', () => {
const error = new ErrorDto(500, 'Error Message', ['Detail Message']);
expect(error.displayMessage).toBe('Error Message.\n\n * Detail Message.\n');
});
it('Should create html list when error has more items.', () => {
it('should create html list when error has more items.', () => {
const error = new ErrorDto(500, 'Error Message', ['Detail1.', 'Detail2.']);
expect(error.displayMessage).toBe('Error Message.\n\n * Detail1.\n * Detail2.\n');

6
frontend/app/shared/components/assets/asset-dialog.component.html

@ -46,7 +46,7 @@
<sqx-control-errors for="fileName" [submitted]="annotateForm.submitted | async"></sqx-control-errors>
<input type="text" class="form-control" id="fileName" formControlName="fileName" />
<input type="text" class="form-control" id="fileName" formControlName="fileName" spellcheck="false" />
</div>
<div class="form-group">
@ -54,7 +54,7 @@
<sqx-control-errors for="slug" [submitted]="annotateForm.submitted | async"></sqx-control-errors>
<input type="text" class="form-control slug" id="slug" formControlName="slug" sqxTransformInput="Slugify" />
<input type="text" class="form-control slug" id="slug" formControlName="slug" sqxTransformInput="Slugify" spellcheck="false" />
<button type="button" class="btn btn-text-secondary btn-sm slug-generate" (click)="generateSlug()">
Generate
@ -76,7 +76,7 @@
<div class="col col-name pr-1">
<sqx-control-errors [for]="form.get('name')" fieldName="Name" [submitted]="annotateForm.submitted | async"></sqx-control-errors>
<input type="text" class="form-control" maxlength="1000" [formControl]="form.get('name')" placeholder="Name" />
<input type="text" class="form-control" maxlength="1000" [formControl]="form.get('name')" placeholder="Name" spellcheck="false" />
</div>
<div class="col pr-1">

2
frontend/app/shared/components/assets/asset-dialog.component.ts

@ -75,7 +75,7 @@ export class AssetDialogComponent implements OnInit {
this.annotateForm.setEnabled(this.isEditable);
if (this.asset.type === 'Image') {
this.selectableTabs = ['Image', 'Metadata'];
this.selectableTabs = ['Metadata', 'Image'];
} else {
this.selectableTabs = ['Metadata'];
}

2
frontend/app/shared/interceptors/auth.interceptor.spec.ts

@ -49,7 +49,7 @@ describe('AuthInterceptor', () => {
it('should append headers to request',
inject([HttpClient, HttpTestingController], (http: HttpClient, httpMock: HttpTestingController) => {
authService.setup(x => x.userChanges).returns(() => of(<any>{ authToken: 'letmein' }));
authService.setup(x => x.userChanges).returns(() => of(<any>{ authorization: 'letmein' }));
http.get('http://service/p/apps').subscribe();

14
frontend/app/shared/state/assets.forms.spec.ts

@ -32,7 +32,7 @@ describe('AnnotateAssetForm', () => {
form = new AnnotateAssetForm(new FormBuilder());
});
it('Should remov extension when loading asset file name', () => {
it('shoulde remov extension when loading asset file name', () => {
form.load(asset);
const slug = form.form.get('fileName')!.value;
@ -40,7 +40,7 @@ describe('AnnotateAssetForm', () => {
expect(slug).toBe('My File');
});
it('Should create slug from file name', () => {
it('should create slug from file name', () => {
form.load(asset);
form.generateSlug({} as any);
@ -49,7 +49,7 @@ describe('AnnotateAssetForm', () => {
expect(slug).toBe('my-file');
});
it('Should create slug from file name and append extension', () => {
it('should create slug from file name and append extension', () => {
form.form.get('fileName')!.setValue('My New File');
form.generateSlug(asset);
@ -58,7 +58,7 @@ describe('AnnotateAssetForm', () => {
expect(slug).toBe('my-new-file.png');
});
it('Should convert metadata when loading', () => {
it('should convert metadata when loading', () => {
form.load(asset);
const metadata = form.metadata.value;
@ -71,7 +71,7 @@ describe('AnnotateAssetForm', () => {
]);
});
it('Should convert values when submitting', () => {
it('should convert values when submitting', () => {
form.load(asset);
const request = form.submit({ fileName: 'Old File.png' } as any)!;
@ -80,7 +80,7 @@ describe('AnnotateAssetForm', () => {
expect(form.form.enabled).toBeFalsy();
});
it('Should return null when nothing changed before submit', () => {
it('should return null when nothing changed before submit', () => {
form.load(asset);
const result = form.submit(asset);
@ -89,7 +89,7 @@ describe('AnnotateAssetForm', () => {
expect(form.form.enabled).toBeTruthy();
});
it('Should remove previous metadata when loaded', () => {
it('should remove previous metadata when loaded', () => {
const newAsset: any = {
metadata: {
key1: 'Value'

Loading…
Cancel
Save