Browse Source

SA fixes.

pull/362/head
Sebastian Stehle 7 years ago
parent
commit
df16b28882
  1. 1
      Squidex.ruleset
  2. 3
      src/Squidex/Areas/Api/Config/Swagger/SecurityProcessor.cs
  3. 2
      src/Squidex/Areas/Api/Controllers/Apps/AppClientsController.cs
  4. 2
      src/Squidex/Areas/Api/Controllers/Apps/AppPatternsController.cs
  5. 2
      src/Squidex/Areas/Api/Controllers/Apps/Models/AppPatternDto.cs
  6. 30
      src/Squidex/Areas/Api/Controllers/Contents/ContentsController.cs
  7. 2
      src/Squidex/Areas/Api/Controllers/History/HistoryController.cs
  8. 2
      src/Squidex/Areas/Api/Controllers/Rules/Models/RuleEventDto.cs
  9. 2
      src/Squidex/Areas/IdentityServer/Config/IdentityServerExtensions.cs

1
Squidex.ruleset

@ -62,6 +62,7 @@
<Rule Id="SA1404" Action="None" /> <Rule Id="SA1404" Action="None" />
<Rule Id="SA1601" Action="None" /> <Rule Id="SA1601" Action="None" />
<Rule Id="SA1413" Action="None" /> <Rule Id="SA1413" Action="None" />
<Rule Id="SA0001" Action="None" />
</Rules> </Rules>
<Rules AnalyzerId="RefactoringEssentials" RuleNamespace="RefactoringEssentials"> <Rules AnalyzerId="RefactoringEssentials" RuleNamespace="RefactoringEssentials">
<Rule Id="RECS0061" Action="Error" /> <Rule Id="RECS0061" Action="Error" />

3
src/Squidex/Areas/Api/Config/Swagger/SecurityProcessor.cs

@ -6,6 +6,7 @@
// ========================================================================== // ==========================================================================
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq;
using Microsoft.Extensions.Options; using Microsoft.Extensions.Options;
using NSwag; using NSwag;
using NSwag.SwaggerGeneration.Processors.Security; using NSwag.SwaggerGeneration.Processors.Security;
@ -17,7 +18,7 @@ namespace Squidex.Areas.Api.Config.Swagger
public class SecurityProcessor : SecurityDefinitionAppender public class SecurityProcessor : SecurityDefinitionAppender
{ {
public SecurityProcessor(IOptions<UrlsOptions> urlOptions) public SecurityProcessor(IOptions<UrlsOptions> urlOptions)
: base(Constants.SecurityDefinition, CreateOAuthSchema(urlOptions.Value)) : base(Constants.SecurityDefinition, Enumerable.Empty<string>(), CreateOAuthSchema(urlOptions.Value))
{ {
} }

2
src/Squidex/Areas/Api/Controllers/Apps/AppClientsController.cs

@ -108,7 +108,7 @@ namespace Squidex.Areas.Api.Controllers.Apps
} }
/// <summary> /// <summary>
/// Revoke an app client /// Revoke an app client.
/// </summary> /// </summary>
/// <param name="app">The name of the app.</param> /// <param name="app">The name of the app.</param>
/// <param name="clientId">The id of the client that must be deleted.</param> /// <param name="clientId">The id of the client that must be deleted.</param>

2
src/Squidex/Areas/Api/Controllers/Apps/AppPatternsController.cs

@ -113,7 +113,7 @@ namespace Squidex.Areas.Api.Controllers.Apps
/// 404 => Pattern or app not found. /// 404 => Pattern or app not found.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// Schemas using this pattern will still function using the same Regular Expression /// Schemas using this pattern will still function using the same Regular Expression.
/// </remarks> /// </remarks>
[HttpDelete] [HttpDelete]
[Route("apps/{app}/patterns/{id}/")] [Route("apps/{app}/patterns/{id}/")]

2
src/Squidex/Areas/Api/Controllers/Apps/Models/AppPatternDto.cs

@ -17,7 +17,7 @@ namespace Squidex.Areas.Api.Controllers.Apps.Models
public sealed class AppPatternDto public sealed class AppPatternDto
{ {
/// <summary> /// <summary>
/// Identifier for Pattern /// Unique id of the pattern.
/// </summary> /// </summary>
public Guid PatternId { get; set; } public Guid PatternId { get; set; }

30
src/Squidex/Areas/Api/Controllers/Contents/ContentsController.cs

@ -54,7 +54,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 404 => Schema or app not found. /// 404 => Schema or app not found.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpGet] [HttpGet]
[HttpPost] [HttpPost]
@ -85,7 +85,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 404 => Schema or app not found. /// 404 => Schema or app not found.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpGet] [HttpGet]
[HttpPost] [HttpPost]
@ -117,7 +117,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 404 => App not found. /// 404 => App not found.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpGet] [HttpGet]
[Route("content/{app}/")] [Route("content/{app}/")]
@ -157,7 +157,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 404 => Schema or app not found. /// 404 => Schema or app not found.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpGet] [HttpGet]
[Route("content/{app}/{name}/")] [Route("content/{app}/{name}/")]
@ -196,7 +196,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 404 => Content, schema or app not found. /// 404 => Content, schema or app not found.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpGet] [HttpGet]
[Route("content/{app}/{name}/{id}/")] [Route("content/{app}/{name}/{id}/")]
@ -232,7 +232,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 400 => Content data is not valid. /// 400 => Content data is not valid.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpGet] [HttpGet]
[Route("content/{app}/{name}/{id}/{version}/")] [Route("content/{app}/{name}/{id}/{version}/")]
@ -268,7 +268,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 400 => Content data is not valid. /// 400 => Content data is not valid.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpPost] [HttpPost]
[Route("content/{app}/{name}/")] [Route("content/{app}/{name}/")]
@ -309,7 +309,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 400 => Content data is not valid. /// 400 => Content data is not valid.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpPut] [HttpPut]
[Route("content/{app}/{name}/{id}/")] [Route("content/{app}/{name}/{id}/")]
@ -342,7 +342,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 400 => Content patch is not valid. /// 400 => Content patch is not valid.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpPatch] [HttpPatch]
[Route("content/{app}/{name}/{id}/")] [Route("content/{app}/{name}/{id}/")]
@ -374,7 +374,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 400 => Content was already published. /// 400 => Content was already published.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpPut] [HttpPut]
[Route("content/{app}/{name}/{id}/publish/")] [Route("content/{app}/{name}/{id}/publish/")]
@ -404,7 +404,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 400 => Content was not published. /// 400 => Content was not published.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpPut] [HttpPut]
[Route("content/{app}/{name}/{id}/unpublish/")] [Route("content/{app}/{name}/{id}/unpublish/")]
@ -434,7 +434,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 400 => Content was already archived. /// 400 => Content was already archived.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpPut] [HttpPut]
[Route("content/{app}/{name}/{id}/archive/")] [Route("content/{app}/{name}/{id}/archive/")]
@ -464,7 +464,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 400 => Content was not archived. /// 400 => Content was not archived.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpPut] [HttpPut]
[Route("content/{app}/{name}/{id}/restore/")] [Route("content/{app}/{name}/{id}/restore/")]
@ -493,7 +493,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 400 => Content was not archived. /// 400 => Content was not archived.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can read the generated documentation for your app at /api/content/{appName}/docs /// You can read the generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpPut] [HttpPut]
[Route("content/{app}/{name}/{id}/discard/")] [Route("content/{app}/{name}/{id}/discard/")]
@ -521,7 +521,7 @@ namespace Squidex.Areas.Api.Controllers.Contents
/// 404 => Content, schema or app not found. /// 404 => Content, schema or app not found.
/// </returns> /// </returns>
/// <remarks> /// <remarks>
/// You can create an generated documentation for your app at /api/content/{appName}/docs /// You can create an generated documentation for your app at /api/content/{appName}/docs.
/// </remarks> /// </remarks>
[HttpDelete] [HttpDelete]
[Route("content/{app}/{name}/{id}/")] [Route("content/{app}/{name}/{id}/")]

2
src/Squidex/Areas/Api/Controllers/History/HistoryController.cs

@ -31,7 +31,7 @@ namespace Squidex.Areas.Api.Controllers.History
} }
/// <summary> /// <summary>
/// Get the events from the history /// Get the events from the history.
/// </summary> /// </summary>
/// <param name="app">The name of the app.</param> /// <param name="app">The name of the app.</param>
/// <param name="channel">The name of the channel.</param> /// <param name="channel">The name of the channel.</param>

2
src/Squidex/Areas/Api/Controllers/Rules/Models/RuleEventDto.cs

@ -27,7 +27,7 @@ namespace Squidex.Areas.Api.Controllers.Rules.Models
public Instant Created { get; set; } public Instant Created { get; set; }
/// <summary> /// <summary>
/// The description /// The description.
/// </summary> /// </summary>
[Required] [Required]
public string Description { get; set; } public string Description { get; set; }

2
src/Squidex/Areas/IdentityServer/Config/IdentityServerExtensions.cs

@ -26,7 +26,7 @@ namespace Squidex.Areas.IdentityServer.Config
{ {
app.UseIdentityServer(); app.UseIdentityServer();
return app; return app;
} }
public static IServiceProvider UseMyAdmin(this IServiceProvider services) public static IServiceProvider UseMyAdmin(this IServiceProvider services)

Loading…
Cancel
Save