tsai
/
squidex
mirror of https://github.com/Squidex/squidex.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Fix ready.

pull/596/head
Sebastian 5 years ago
parent
995a000c6f
commit
fc96248a46
2 changed files with 38 additions and 13 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 38
      backend/tests/Squidex.Domain.Apps.Core.Tests/Operations/ValidateContent/AssetsFieldTests.cs
  2. 13
      backend/tests/Squidex.Domain.Apps.Core.Tests/Operations/ValidateContent/ReferencesFieldTests.cs

38
backend/tests/Squidex.Domain.Apps.Core.Tests/Operations/ValidateContent/AssetsFieldTests.cs
View File

@ -14,6 +14,7 @@ using Squidex.Domain.Apps.Core.Schemas;
using Squidex.Domain.Apps.Core.TestHelpers;
using Squidex.Domain.Apps.Core.ValidateContent;
using Squidex.Domain.Apps.Core.ValidateContent.Validators;
using Squidex.Infrastructure;
using Squidex.Infrastructure.Json.Objects;
using Xunit;
@ -22,6 +23,8 @@ namespace Squidex.Domain.Apps.Core.Operations.ValidateContent
public class AssetsFieldTests : IClassFixture<TranslationsFixture>
{
private readonly List<string> errors = new List<string>();
private readonly DomainId asset1 = DomainId.NewGuid();
private readonly DomainId asset2 = DomainId.NewGuid();
private readonly IValidatorsFactory factory;
private class CustomFactory : IValidatorsFactory
@ -53,6 +56,21 @@ namespace Squidex.Domain.Apps.Core.Operations.ValidateContent
Assert.Equal("my-assets", sut.Name);
}
[Fact]
public async Task Should_not_add_error_if_assets_are_valid()
{
var sut = Field(new AssetsFieldProperties
{
IsRequired = true,
MinItems = 1,
MaxItems = 3
});
await sut.ValidateAsync(CreateValue(asset1), errors, factory: factory);
Assert.Empty(errors);
}
[Fact]
public async Task Should_not_add_error_if_assets_are_null_and_valid()
{
@ -68,17 +86,17 @@ namespace Squidex.Domain.Apps.Core.Operations.ValidateContent
{
var sut = Field(new AssetsFieldProperties { MinItems = 2, MaxItems = 2 });
await sut.ValidateAsync(CreateValue(Guid.NewGuid(), Guid.NewGuid()), errors, factory: factory);
await sut.ValidateAsync(CreateValue(asset1, asset2), errors, factory: factory);
Assert.Empty(errors);
}
[Fact]
public async Task Should_not_add_error_if_duplicate_values_are_ignored()
public async Task Should_not_add_error_if_duplicate_values_are_allowed()
{
var sut = Field(new AssetsFieldProperties { AllowDuplicates = true });
await sut.ValidateAsync(CreateValue(Guid.NewGuid(), Guid.NewGuid()), errors, factory: factory);
await sut.ValidateAsync(CreateValue(asset1, asset2), errors, factory: factory);
Assert.Empty(errors);
}
@ -110,7 +128,7 @@ namespace Squidex.Domain.Apps.Core.Operations.ValidateContent
{
var sut = Field(new AssetsFieldProperties { MinItems = 3 });
await sut.ValidateAsync(CreateValue(Guid.NewGuid(), Guid.NewGuid()), errors, factory: factory);
await sut.ValidateAsync(CreateValue(asset1, asset2), errors, factory: factory);
errors.Should().BeEquivalentTo(
new[] { "Must have at least 3 item(s)." });
@ -121,7 +139,7 @@ namespace Squidex.Domain.Apps.Core.Operations.ValidateContent
{
var sut = Field(new AssetsFieldProperties { MaxItems = 1 });
await sut.ValidateAsync(CreateValue(Guid.NewGuid(), Guid.NewGuid()), errors, factory: factory);
await sut.ValidateAsync(CreateValue(asset1, asset2), errors, factory: factory);
errors.Should().BeEquivalentTo(
new[] { "Must not have more than 1 item(s)." });
@ -132,17 +150,17 @@ namespace Squidex.Domain.Apps.Core.Operations.ValidateContent
{
var sut = Field(new AssetsFieldProperties());
var id = Guid.NewGuid();
await sut.ValidateAsync(CreateValue(id, id), errors, factory: factory);
await sut.ValidateAsync(CreateValue(asset1, asset1), errors, factory: factory);
errors.Should().BeEquivalentTo(
new[] { "Must not contain duplicate values." });
}
private static IJsonValue CreateValue(params Guid[]? ids)
private static IJsonValue CreateValue(params DomainId[]? ids)
{
return ids == null ? JsonValue.Null : JsonValue.Array(ids.Select(x => (object)x.ToString()).ToArray());
return ids == null ?
JsonValue.Null :
JsonValue.Array(ids.Select(x => (object)x.ToString()).ToArray());
}
private static RootField<AssetsFieldProperties> Field(AssetsFieldProperties properties)

13
backend/tests/Squidex.Domain.Apps.Core.Tests/Operations/ValidateContent/ReferencesFieldTests.cs
View File

@ -67,7 +67,12 @@ namespace Squidex.Domain.Apps.Core.Operations.ValidateContent
[Fact]
public async Task Should_not_add_error_if_references_are_valid()
{
var sut = Field(new ReferencesFieldProperties());
var sut = Field(new ReferencesFieldProperties
{
IsRequired = true,
MinItems = 1,
MaxItems = 3
});
await sut.ValidateAsync(CreateValue(ref1), errors, factory: factory);
@ -97,7 +102,7 @@ namespace Squidex.Domain.Apps.Core.Operations.ValidateContent
[Fact]
public async Task Should_not_add_error_if_duplicate_values_are_allowed()
{
var sut = Field(new ReferencesFieldProperties { MinItems = 2, MaxItems = 2, AllowDuplicates = true });
var sut = Field(new ReferencesFieldProperties { AllowDuplicates = true });
await sut.ValidateAsync(CreateValue(ref1, ref1), errors, factory: factory);
@ -161,7 +166,9 @@ namespace Squidex.Domain.Apps.Core.Operations.ValidateContent
private static IJsonValue CreateValue(params DomainId[]? ids)
{
return ids == null ? JsonValue.Null : JsonValue.Array(ids.Select(x => (object)x.ToString()).ToArray());
return ids == null ?
JsonValue.Null :
JsonValue.Array(ids.Select(x => (object)x.ToString()).ToArray());
}
private static RootField<ReferencesFieldProperties> Field(ReferencesFieldProperties properties)

Write Preview
Loading…
Cancel
Save