Fix incrementFailedLoginAttemptsByUserId

application/src/test/java/org/thingsboard/server/controller/TwoFactorAuthTest.java

@@ -319,7 +319,9 @@ public class TwoFactorAuthTest extends AbstractControllerTest {
             assertThat(successfulLogInAuditLog.getActionStatus()).isEqualTo(ActionStatus.SUCCESS);
             assertThat(successfulLogInAuditLog.getUserName()).isEqualTo(username);
         });
-        assertThat(userService.findUserById(tenantId, user.getId()).getAdditionalInfo()
+
+        loginTenantAdmin();
+        assertThat(doGet("/api/user/" + user.getId(), User.class).getAdditionalInfo()
                 .get("lastLoginTs").asLong())
                 .isGreaterThan(System.currentTimeMillis() - TimeUnit.SECONDS.toMillis(3));
     }

dao/src/main/java/org/thingsboard/server/dao/sql/user/UserCredentialsRepository.java

@@ -43,7 +43,6 @@ public interface UserCredentialsRepository extends JpaRepository<UserCredentials
     void updateLastLoginTsByUserId(UUID userId, long lastLoginTs);
 
     @Transactional
-    @Modifying
     @Query(value = "UPDATE user_credentials SET failed_login_attempts = coalesce(failed_login_attempts, 0) + 1 " +
             "WHERE user_id = :userId RETURNING failed_login_attempts", nativeQuery = true)
     int incrementFailedLoginAttemptsByUserId(UUID userId);