Browse Source

fixed test

pull/7762/head
dashevchenko 4 years ago
parent
commit
408afb67f3
  1. 2
      common/dao-api/src/main/java/org/thingsboard/server/dao/alarm/AlarmCommentService.java
  2. 7
      dao/src/main/java/org/thingsboard/server/dao/alarm/BaseAlarmCommentService.java
  3. 6
      rule-engine/rule-engine-components/src/main/java/org/thingsboard/rule/engine/util/TenantIdLoader.java
  4. 13
      rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/util/TenantIdLoaderTest.java

2
common/dao-api/src/main/java/org/thingsboard/server/dao/alarm/AlarmCommentService.java

@ -33,4 +33,6 @@ public interface AlarmCommentService {
ListenableFuture<AlarmComment> findAlarmCommentByIdAsync(TenantId tenantId, AlarmCommentId alarmCommentId);
AlarmComment findAlarmCommentById(TenantId tenantId, AlarmCommentId alarmCommentId);
}

7
dao/src/main/java/org/thingsboard/server/dao/alarm/BaseAlarmCommentService.java

@ -86,6 +86,13 @@ public class BaseAlarmCommentService extends AbstractEntityService implements Al
return alarmCommentDao.findAlarmCommentByIdAsync(tenantId, alarmCommentId.getId());
}
@Override
public AlarmComment findAlarmCommentById(TenantId tenantId, AlarmCommentId alarmCommentId) {
log.trace("Executing findAlarmCommentByIdAsync by alarmCommentId [{}]", alarmCommentId);
validateId(alarmCommentId, "Incorrect alarmCommentId " + alarmCommentId);
return alarmCommentDao.findById(tenantId, alarmCommentId.getId());
}
private AlarmCommentOperationResult createAlarmComment(TenantId tenantId, AlarmComment alarmComment) {
log.debug("New Alarm comment : {}", alarmComment);
if (alarmComment.getType() == null) {

6
rule-engine/rule-engine-components/src/main/java/org/thingsboard/rule/engine/util/TenantIdLoader.java

@ -18,6 +18,8 @@ package org.thingsboard.rule.engine.util;
import org.thingsboard.rule.engine.api.TbContext;
import org.thingsboard.server.common.data.EntityType;
import org.thingsboard.server.common.data.HasTenantId;
import org.thingsboard.server.common.data.alarm.AlarmComment;
import org.thingsboard.server.common.data.id.AlarmCommentId;
import org.thingsboard.server.common.data.id.AlarmId;
import org.thingsboard.server.common.data.id.ApiUsageStateId;
import org.thingsboard.server.common.data.id.AssetId;
@ -69,6 +71,10 @@ public class TenantIdLoader {
case ALARM:
tenantEntity = ctx.getAlarmService().findAlarmById(ctxTenantId, new AlarmId(id));
break;
case ALARM_COMMENT:
AlarmComment alarmComment = ctx.getAlarmCommentService().findAlarmCommentById(ctxTenantId, new AlarmCommentId(id));
tenantEntity = ctx.getAlarmService().findAlarmById(ctxTenantId, new AlarmId(alarmComment.getAlarmId().getId()));
break;
case RULE_CHAIN:
tenantEntity = ctx.getRuleChainService().findRuleChainById(ctxTenantId, new RuleChainId(id));
break;

13
rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/util/TenantIdLoaderTest.java

@ -41,9 +41,11 @@ import org.thingsboard.server.common.data.TbResource;
import org.thingsboard.server.common.data.TenantProfile;
import org.thingsboard.server.common.data.User;
import org.thingsboard.server.common.data.alarm.Alarm;
import org.thingsboard.server.common.data.alarm.AlarmComment;
import org.thingsboard.server.common.data.asset.Asset;
import org.thingsboard.server.common.data.asset.AssetProfile;
import org.thingsboard.server.common.data.edge.Edge;
import org.thingsboard.server.common.data.id.AlarmId;
import org.thingsboard.server.common.data.id.AssetProfileId;
import org.thingsboard.server.common.data.id.DeviceProfileId;
import org.thingsboard.server.common.data.id.EntityId;
@ -56,6 +58,7 @@ import org.thingsboard.server.common.data.rule.RuleChain;
import org.thingsboard.server.common.data.rule.RuleNode;
import org.thingsboard.server.common.data.widget.WidgetType;
import org.thingsboard.server.common.data.widget.WidgetsBundle;
import org.thingsboard.server.dao.alarm.AlarmCommentService;
import org.thingsboard.server.dao.asset.AssetService;
import org.thingsboard.server.dao.customer.CustomerService;
import org.thingsboard.server.dao.dashboard.DashboardService;
@ -93,6 +96,8 @@ public class TenantIdLoaderTest {
@Mock
private RuleEngineAlarmService alarmService;
@Mock
private AlarmCommentService alarmCommentService;
@Mock
private RuleChainService ruleChainService;
@Mock
private EntityViewService entityViewService;
@ -190,6 +195,14 @@ public class TenantIdLoaderTest {
when(ctx.getAlarmService()).thenReturn(alarmService);
doReturn(alarm).when(alarmService).findAlarmById(eq(tenantId), any());
break;
case ALARM_COMMENT:
AlarmComment alarmComment = new AlarmComment();
alarmComment.setAlarmId(new AlarmId(UUID.randomUUID()));
when(ctx.getAlarmCommentService()).thenReturn(alarmCommentService);
doReturn(alarmComment).when(alarmCommentService).findAlarmCommentById(eq(tenantId), any());
break;
case RULE_CHAIN:
RuleChain ruleChain = new RuleChain();

Loading…
Cancel
Save