Browse Source

fix(iot-hub): fix device review dialog after component refactor

- Remove stale iotHubApiService from dialog data (now directly injected)
- Fall back to regular detail dialog for items without installState
  (installed before the review mode feature)
pull/15508/head
Andrii Shvaika 6 months ago
parent
commit
59c88a89ad
  1. 11
      ui-ngx/src/app/modules/home/pages/iot-hub/iot-hub-installed-items.component.ts

11
ui-ngx/src/app/modules/home/pages/iot-hub/iot-hub-installed-items.component.ts

@ -255,7 +255,15 @@ export class TbIotHubInstalledItemsComponent implements OnInit, AfterViewInit, O
private openDeviceReviewDialog(item: IotHubInstalledItem): void { private openDeviceReviewDialog(item: IotHubInstalledItem): void {
const descriptor = item.descriptor as DeviceInstalledItemDescriptor; const descriptor = item.descriptor as DeviceInstalledItemDescriptor;
if (!descriptor.installState || !descriptor.selectedConnectivity) { if (!descriptor.installState || !descriptor.selectedConnectivity) {
return; // No install state stored — can't open review // No install state — fall back to regular detail dialog
this.iotHubApiService.getVersionInfo(item.itemVersionId, {ignoreLoading: true}).subscribe(versionView => {
this.dialog.open(TbIotHubItemDetailDialogComponent, {
panelClass: ['tb-dialog', 'tb-fullscreen-dialog'],
autoFocus: false,
data: { item: versionView, installedItem: item } as IotHubItemDetailDialogData
});
});
return;
} }
this.iotHubApiService.getVersionFileData(item.itemVersionId, { ignoreLoading: true }).subscribe({ this.iotHubApiService.getVersionFileData(item.itemVersionId, { ignoreLoading: true }).subscribe({
next: async (blob: Blob) => { next: async (blob: Blob) => {
@ -268,7 +276,6 @@ export class TbIotHubInstalledItemsComponent implements OnInit, AfterViewInit, O
data: { data: {
item: versionView, item: versionView,
zipData, zipData,
iotHubApiService: this.iotHubApiService,
reviewMode: true, reviewMode: true,
selectedConnectivity: descriptor.selectedConnectivity, selectedConnectivity: descriptor.selectedConnectivity,
installState: descriptor.installState installState: descriptor.installState

Loading…
Cancel
Save